Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for google_access_context_manager_service_perimeter ingress/egress policies #4535

Closed

Conversation

eadred
Copy link

@eadred eadred commented Feb 25, 2021

Adds beta support for egress and ingress policies to VPC Service Control perimeters.

Resolves Terraform provider Issue 8412.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

access_context_manager: added `status.egress_policies`, `status.ingress_policies`,
`spec.egress_policies` and `spec.ingress_policies` fields to
`google_access_context_manager_service_perimeter` resource (beta)

@google-cla google-cla bot added the cla: yes label Feb 25, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@eadred
Copy link
Author

eadred commented Feb 25, 2021

I'm having trouble running the TF provider tests, but opening this PR in case any review comments come out of it in the meantime.

Comment on lines +21 to +23
- !ruby/object:Api::Product::Version
name: beta
base_url: https://accesscontextmanager.googleapis.com/v1/
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the new properties are available in the v1 API version, the documentation indicates they are not GA (see the docs), hence why the same base_url is used for both ga and beta versions.

@eadred eadred changed the title Tf provider issue 8412 Support for google_access_context_manager_service_perimeter ingress/egress policies Feb 25, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 635 insertions(+))
Terraform Beta: Diff ( 4 files changed, 4063 insertions(+), 84 deletions(-))
Inspec: Diff ( 26 files changed, 1096 insertions(+))

@slevenick
Copy link
Contributor

This looks like a duplicate of #4509

@eadred
Copy link
Author

eadred commented Mar 1, 2021

Closing this as a duplicate of #4509.

@eadred eadred closed this Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_access_context_manager_service_perimeter - beta support for ingressPolicies and egressPolicies
3 participants