add support for available_secrets to google_cloudbuild_trigger

[cgroschupp]

add support for available_secrets to google_cloudbuild_trigger.
https://cloud.google.com/build/docs/api/reference/rest/v1/projects.builds#secrets

fixes hashicorp/terraform-provider-google#8808

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudbuild: added support for available_secrets to google_cloudbuild_trigger

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 179 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 179 insertions(+), 4 deletions(-))
Ansible: Diff ( 2 files changed, 132 insertions(+))
TF Conversion: Diff ( 1 file changed, 63 insertions(+))
TF OiCS: Diff ( 1 file changed, 9 insertions(+), 2 deletions(-))
Inspec: Diff ( 5 files changed, 95 insertions(+))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 179 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 179 insertions(+), 4 deletions(-))
Ansible: Diff ( 2 files changed, 132 insertions(+))
TF Conversion: Diff ( 1 file changed, 63 insertions(+))
TF OiCS: Diff ( 1 file changed, 9 insertions(+), 2 deletions(-))
Inspec: Diff ( 5 files changed, 95 insertions(+))

[cgroschupp]

@rileykarson Can you please look over this pr.

[rileykarson]

Sorry about that, I must have accidentally dismissed the notification! I've been a bit underwater on my email.

The test passes as-is, but given that the field supports update let's add an update test as well. https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/third_party/terraform/tests/resource_cloudbuild_trigger_test.go is a good file to reference- typically the most interesting test is to start with the value set, and then remove it eg:

    available_secrets {
      secret_manager {
        env          = "MY_SECRET"
        version_name = "projects/myProject/secrets/mySecret/versions/latest"
      }
    }

to

# intentionally blank

[cgroschupp]

@rileykarson ok, thanks for the hint. is it ok to add this to TestAccCloudBuildTrigger_basic test?

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 185 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 6 files changed, 188 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 63 insertions(+))
TF OiCS: Diff ( 1 file changed, 9 insertions(+), 2 deletions(-))

[msuarezd]

Hi @rileykarson, any news on this? It would be really helpful for us to get this merged.

[rileykarson]

Sorry, still super behind on email!

@cgroschupp: Would you mind adding a new case? We tend to try and keep _basic ones to a small set of core-to-the-resource fields, and this one is pretty additive.

[cgroschupp]

@rileykarson I have updated the tests.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 258 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 259 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 1 file changed, 63 insertions(+))
TF OiCS: Diff ( 1 file changed, 9 insertions(+), 2 deletions(-))

[franzs]

@rileykarson Sorry for bothering you. Is there any time frame we can expect a review? We are desperately waiting for this feature.
🙏

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 258 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 258 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 63 insertions(+))
TF Validator: Diff ( 1 file changed, 63 insertions(+))
TF OiCS: Diff ( 1 file changed, 9 insertions(+), 2 deletions(-))

[franzs]

@rileykarson Meanwhile the feature branch was updated to match the upstream by @cgroschupp.
Could you please have a look at the PR again?

[rileykarson]

Sorry about the delay! Code LGTM on a first pass, running tests. These are VCR tests that work by replaying old API results- we expect the new tests (and some random unrelated ones) to fail on a first pass as they aren't recorded, I need to inspect the RECORDING results.

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 276 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 4 files changed, 258 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 63 insertions(+))
TF Validator: Diff ( 1 file changed, 63 insertions(+))
TF OiCS: Diff ( 1 file changed, 9 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_available_secrets_config|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=227591

[franzs]

@rileykarson Thanks a lot. 🎊