Promote `google_gke_hub_membership` to GA #4982

upodroid · 2021-07-19T20:58:03Z

Fixes: hashicorp/terraform-provider-google#9569

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

gkehub: promoted `google_gke_hub_membership` to GA

modular-magician · 2021-07-19T20:58:19Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2021-07-19T20:59:27Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

upodroid · 2021-07-19T21:04:38Z

@rileykarson @slevenick

This resource is quite a mess.

GA DCL client is missing. https://github.com/GoogleCloudPlatform/declarative-resource-client-library/tree/main/services/google/gkehub
google_gke_hub_membership is a third resource that appears in the repo generated by mmv1.
google_gkehub_feature_membership should be renamed to google_gkehub_membership and promoted with that name to GA. The API doc only has two resources.
https://github.com/hashicorp/terraform-provider-google-beta/blob/master/google-beta/resource_gke_hub_feature_membership.go doesn't match this object https://cloud.google.com/anthos/multicluster-management/reference/rest/v1/projects.locations.memberships#Membership

modular-magician · 2021-07-19T21:09:21Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 2074 insertions(+))
Terraform Beta: Diff ( 1 file changed, 26 insertions(+), 26 deletions(-))

upodroid · 2021-07-19T21:18:05Z

Ignore my previous comment.

https://github.com/GoogleCloudPlatform/magic-modules/blob/master/mmv1/products/gkehub/api.yaml promoting this should be sufficient.

slevenick · 2021-07-19T21:36:53Z

/gcbrun

modular-magician · 2021-07-19T21:48:31Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 2074 insertions(+))
Terraform Beta: Diff ( 1 file changed, 26 insertions(+), 26 deletions(-))

modular-magician · 2021-07-19T22:00:10Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 800 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 2 files changed, 15 insertions(+), 17 deletions(-))
TF Conversion: Diff ( 2 files changed, 152 insertions(+))
TF OiCS: Diff ( 1 file changed, 3 deletions(-))

upodroid · 2021-07-19T22:24:54Z

This is ready.

The description field isn't returned by the API and it seems it is a legacy field not used anymore. Is it worth having a decoder that sets the initial value and mark it as ForceNew?

-----------------------------------------------------
2021/07/19 22:42:53 [DEBUG] Retry Transport: Stopping retries, last request was successful
2021/07/19 22:42:53 [DEBUG] Retry Transport: Returning after 1 attempts
2021/07/19 22:42:53 [DEBUG] Cluster "basiccluster73bnk4iskw" has status "RUNNING" with message "".
2021/07/19 22:42:53 [DEBUG] Unlocking "google-container-cluster/REDACTED/us-central1-a/basiccluster73bnk4iskw"
2021/07/19 22:42:53 [DEBUG] Unlocked "google-container-cluster/REDACTED/us-central1-a/basiccluster73bnk4iskw"
2021/07/19 22:42:53 [DEBUG] Creating new Membership: map[string]interface {}{"description":"test resource.", "endpoint":map[string]interface {}{"gkeCluster":map[string]interface {}{"resourceLink":"//container.googleapis.com/projects/REDACTED/locations/us-central1-a/clusters/basiccluster73bnk4iskw"}}}
2021/07/19 22:42:53 [DEBUG] Waiting for state to become: [success]
2021/07/19 22:42:53 [DEBUG] Retry Transport: starting RoundTrip retry loop
2021/07/19 22:42:53 [DEBUG] Retry Transport: request attempt 0
2021/07/19 22:42:53 [DEBUG] Google API Request Details:
---[ REQUEST ]---------------------------------------
POST /v1/projects/REDACTED/locations/global/memberships?alt=json&membershipId=basic73bnk4iskw HTTP/1.1
Host: gkehub.googleapis.com
User-Agent: Terraform/0.14.11 (+https://www.terraform.io) Terraform-Plugin-SDK/2.5.0 terraform-provider-google/acc
Content-Length: 186
Content-Type: application/json
Accept-Encoding: gzip

{
 "description": "test resource.",
 "endpoint": {
  "gkeCluster": {
   "resourceLink": "//container.googleapis.com/projects/REDACTED/locations/us-central1-a/clusters/basiccluster73bnk4iskw"
  }
 }
}

-----------------------------------------------------
2021/07/19 22:42:55 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 200 OK
Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
Cache-Control: private
Content-Type: application/json; charset=UTF-8
Date: Mon, 19 Jul 2021 21:42:55 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "name": "projects/REDACTED/locations/global/operations/operation-1626730974808-5c780d1e607e8-40139030-23cd21aa",
  "metadata": {
    "@type": "type.googleapis.com/google.cloud.gkehub.v1.OperationMetadata",
    "createTime": "2021-07-19T21:42:55.114339112Z",
    "target": "projects/REDACTED/locations/global/memberships/basic73bnk4iskw",
    "verb": "create",
    "cancelRequested": false,
    "apiVersion": "v1"
  },
  "done": false
}

-----------------------------------------------------
2021/07/19 22:42:55 [DEBUG] Retry Transport: Stopping retries, last request was successful
2021/07/19 22:42:55 [DEBUG] Retry Transport: Returning after 1 attempts
2021/07/19 22:42:55 [DEBUG] Waiting for state to become: [done: true]
2021/07/19 22:42:55 [DEBUG] Waiting for state to become: [success]
2021/07/19 22:42:55 [DEBUG] Retry Transport: starting RoundTrip retry loop
2021/07/19 22:42:55 [DEBUG] Retry Transport: request attempt 0
2021/07/19 22:42:55 [DEBUG] Google API Request Details:
---[ REQUEST ]---------------------------------------
GET /v1/projects/REDACTED/locations/global/operations/operation-1626730974808-5c780d1e607e8-40139030-23cd21aa?alt=json HTTP/1.1
Host: gkehub.googleapis.com
User-Agent: Terraform/0.14.11 (+https://www.terraform.io) Terraform-Plugin-SDK/2.5.0 terraform-provider-google/acc
Content-Type: application/json
Accept-Encoding: gzip


-----------------------------------------------------
2021/07/19 22:42:55 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 200 OK
Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
Cache-Control: private
Content-Type: application/json; charset=UTF-8
Date: Mon, 19 Jul 2021 21:42:55 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "name": "projects/REDACTED/locations/global/operations/operation-1626730974808-5c780d1e607e8-40139030-23cd21aa",
  "metadata": {
    "@type": "type.googleapis.com/google.cloud.gkehub.v1.OperationMetadata",
    "createTime": "2021-07-19T21:42:55.114339112Z",
    "target": "projects/REDACTED/locations/global/memberships/basic73bnk4iskw",
    "verb": "create",
    "cancelRequested": false,
    "apiVersion": "v1"
  },
  "done": false
}

-----------------------------------------------------
2021/07/19 22:42:55 [DEBUG] Retry Transport: Stopping retries, last request was successful
2021/07/19 22:42:55 [DEBUG] Retry Transport: Returning after 1 attempts
2021/07/19 22:42:55 [DEBUG] Got done: false while polling for operation projects/REDACTED/locations/global/operations/operation-1626730974808-5c780d1e607e8-40139030-23cd21aa's status
2021/07/19 22:43:05 [DEBUG] Waiting for state to become: [success]
2021/07/19 22:43:05 [DEBUG] Retry Transport: starting RoundTrip retry loop
2021/07/19 22:43:05 [DEBUG] Retry Transport: request attempt 0
2021/07/19 22:43:05 [DEBUG] Google API Request Details:
---[ REQUEST ]---------------------------------------
GET /v1/projects/REDACTED/locations/global/operations/operation-1626730974808-5c780d1e607e8-40139030-23cd21aa?alt=json HTTP/1.1
Host: gkehub.googleapis.com
User-Agent: Terraform/0.14.11 (+https://www.terraform.io) Terraform-Plugin-SDK/2.5.0 terraform-provider-google/acc
Content-Type: application/json
Accept-Encoding: gzip


-----------------------------------------------------
2021/07/19 22:43:06 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 200 OK
Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
Cache-Control: private
Content-Type: application/json; charset=UTF-8
Date: Mon, 19 Jul 2021 21:43:06 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "name": "projects/REDACTED/locations/global/operations/operation-1626730974808-5c780d1e607e8-40139030-23cd21aa",
  "metadata": {
    "@type": "type.googleapis.com/google.cloud.gkehub.v1.OperationMetadata",
    "createTime": "2021-07-19T21:42:55.114339112Z",
    "endTime": "2021-07-19T21:42:57.624353547Z",
    "target": "projects/REDACTED/locations/global/memberships/basic73bnk4iskw",
    "verb": "create",
    "cancelRequested": false,
    "apiVersion": "v1"
  },
  "done": true,
  "response": {
    "@type": "type.googleapis.com/google.cloud.gkehub.v1.Membership",
    "name": "projects/REDACTED/locations/global/memberships/basic73bnk4iskw",
    "endpoint": {
      "gkeCluster": {
        "resourceLink": "//container.googleapis.com/projects/REDACTED/locations/us-central1-a/clusters/basiccluster73bnk4iskw"
      }
    },
    "state": {
      "code": "READY"
    },
    "createTime": "2021-07-19T21:42:55.110471455Z",
    "updateTime": "2021-07-19T21:42:55.110471455Z",
    "externalId": "263b4242-b1b3-4b29-b8d1-58ea4eec6088",
    "uniqueId": "7645d272-21b1-463f-8212-5f0d65ccefc5"
  }
}

-----------------------------------------------------
2021/07/19 22:43:06 [DEBUG] Retry Transport: Stopping retries, last request was successful
2021/07/19 22:43:06 [DEBUG] Retry Transport: Returning after 1 attempts
2021/07/19 22:43:06 [DEBUG] Got done: true while polling for operation projects/REDACTED/locations/global/operations/operation-1626730974808-5c780d1e607e8-40139030-23cd21aa's status
2021/07/19 22:43:06 [DEBUG] Finished creating Membership "projects/REDACTED/locations/global/memberships/basic73bnk4iskw": map[string]interface {}{"done":false, "metadata":map[string]interface {}{"@type":"type.googleapis.com/google.cloud.gkehub.v1.OperationMetadata", "apiVersion":"v1", "cancelRequested":false, "createTime":"2021-07-19T21:42:55.114339112Z", "target":"projects/REDACTED/locations/global/memberships/basic73bnk4iskw", "verb":"create"}, "name":"projects/REDACTED/locations/global/operations/operation-1626730974808-5c780d1e607e8-40139030-23cd21aa"}
2021/07/19 22:43:06 [DEBUG] Waiting for state to become: [success]
2021/07/19 22:43:06 [DEBUG] Retry Transport: starting RoundTrip retry loop
2021/07/19 22:43:06 [DEBUG] Retry Transport: request attempt 0
2021/07/19 22:43:06 [DEBUG] Google API Request Details:
---[ REQUEST ]---------------------------------------
GET /v1/projects/REDACTED/locations/global/memberships/basic73bnk4iskw?alt=json HTTP/1.1
Host: gkehub.googleapis.com
User-Agent: Terraform/0.14.11 (+https://www.terraform.io) Terraform-Plugin-SDK/2.5.0 terraform-provider-google/acc
Content-Type: application/json
Accept-Encoding: gzip


-----------------------------------------------------
2021/07/19 22:43:07 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 200 OK
Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
Cache-Control: private
Content-Type: application/json; charset=UTF-8
Date: Mon, 19 Jul 2021 21:43:07 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "name": "projects/REDACTED/locations/global/memberships/basic73bnk4iskw",
  "endpoint": {
    "gkeCluster": {
      "resourceLink": "//container.googleapis.com/projects/REDACTED/locations/us-central1-a/clusters/basiccluster73bnk4iskw"
    }
  },
  "state": {
    "code": "READY"
  },
  "createTime": "2021-07-19T21:42:55.110471455Z",
  "updateTime": "2021-07-19T21:42:57.659745695Z",
  "externalId": "263b4242-b1b3-4b29-b8d1-58ea4eec6088",
  "uniqueId": "7645d272-21b1-463f-8212-5f0d65ccefc5"
}

-----------------------------------------------------
2021/07/19 22:43:07 [DEBUG] Retry Transport: Stopping retries, last request was successful
2021/07/19 22:43:07 [DEBUG] Retry Transport: Returning after 1 attempts
2021/07/19 22:43:11 [INFO] Authenticating using DefaultClient...
2021/07/19 22:43:11 [INFO]   -- Scopes: [https://www.googleapis.com/auth/compute https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/cloud-identity https://www.googleapis.com/auth/ndev.clouddns.readwrite https://www.googleapis.com/auth/devstorage.full_control https://www.googleapis.com/auth/userinfo.email]
2021/07/19 22:43:11 [INFO] Authenticating using DefaultClient...
2021/07/19 22:43:11 [INFO]   -- Scopes: [https://www.googleapis.com/auth/compute https://www.googleapis.com/auth/cloud-platform https://www.googleapis.com/auth/cloud-identity https://www.googleapis.com/auth/ndev.clouddns.readwrite https://www.googleapis.com/auth/devstorage.full_control https://www.googleapis.com/auth/userinfo.email]
2021/07/19 22:43:11 [DEBUG] Waiting for state to become: [success]
2021/07/19 22:43:11 [INFO] Terraform is using this identity: REDACTED
    provider_test.go:268: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # google_gke_hub_membership.membership will be updated in-place
          ~ resource "google_gke_hub_membership" "membership" {
              + description   = "test resource."
                id            = "projects/REDACTED/locations/global/memberships/basic73bnk4iskw"
                name          = "projects/REDACTED/locations/global/memberships/basic73bnk4iskw"
                # (2 unchanged attributes hidden)
        
                # (1 unchanged block hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.

modular-magician · 2021-07-19T23:14:58Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAssuredWorkloadsWorkload_basic|TestAccAssuredWorkloadsWorkload_full|TestAccBigqueryDataTransferConfig|TestAccCloudBuildTrigger_pubsub_config|TestAccCloudBuildTrigger_webhook_config|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstanceGroup_rename|TestAccContainerCluster_backend|TestAccContainerNodePool_withGPU|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateBasicExample|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateUpdate|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccDialogflowCXVersion_dialogflowcxVersionFullExample|TestAccDialogflowCXFlow_update|TestAccDialogflowCXVersion_update|TestAccNetworkServicesEdgeCacheKeyset_networkServicesEdgeCacheKeysetBasicExample|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginBasicExample|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginAdvancedExample|TestAccNetworkServicesEdgeCacheOrigin_updateAndImport|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceBasicExample|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample|TestAccNetworkServicesEdgeCacheService_updateAndImport|TestAccPrivatecaCertificate_privatecaCertificateCsrExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccPrivatecaCertificate_privatecaCertificateConfigExample|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample|TestAccSecurityCenterNotificationConfig_sccNotificationConfigBasicExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=197264

slevenick · 2021-07-21T00:03:31Z

Yeah, I think we'll want some way to prevent diffs on description.

I'm thinking of marking it as deprecated + url_param_only which should prevent it from being sent in the request body but also prevent it from being read & diffed against.

Alternatively we could write custom code to never diff on it

upodroid · 2021-07-21T16:45:24Z

Apparently, in beta it works normally.

I'll mark description as beta only.

---[ REQUEST ]---------------------------------------
POST /v1beta1/projects/REDACTED/locations/global/memberships?alt=json&membershipId=basicakbc1sh7zh HTTP/1.1
Host: gkehub.googleapis.com
User-Agent: Terraform/0.14.11 (+https://www.terraform.io) Terraform-Plugin-SDK/2.5.0 terraform-provider-google-beta/acc
Content-Length: 168
Content-Type: application/json
Accept-Encoding: gzip

{
 "description": "test resource.",
 "endpoint": {
  "gkeCluster": {
   "resourceLink": "//container.googleapis.com/projects/REDACTED/locations/us-central1-c/clusters/test"
  }
 }
}

-----------------------------------------------------
2021/07/21 15:16:46 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 200 OK
Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
Cache-Control: private
Content-Type: application/json; charset=UTF-8
Date: Wed, 21 Jul 2021 14:16:46 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "name": "projects/REDACTED/locations/global/operations/operation-1626877005905-5c7a2d207bced-e5da30ad-8ae88c05",
  "metadata": {
    "@type": "type.googleapis.com/google.cloud.gkehub.v1beta1.OperationMetadata",
    "createTime": "2021-07-21T14:16:46.113506135Z",
    "target": "projects/REDACTED/locations/global/memberships/basicakbc1sh7zh",
    "verb": "create",
    "cancelRequested": false,
    "apiVersion": "v1beta1"
  },
  "done": false
}

-----------------------------------------------------
2021/07/21 15:16:46 [DEBUG] Retry Transport: Stopping retries, last request was successful
2021/07/21 15:16:46 [DEBUG] Retry Transport: Returning after 1 attempts
2021/07/21 15:16:46 [DEBUG] Waiting for state to become: [done: true]
2021/07/21 15:16:46 [DEBUG] Waiting for state to become: [success]
2021/07/21 15:16:46 [DEBUG] Retry Transport: starting RoundTrip retry loop
2021/07/21 15:16:46 [DEBUG] Retry Transport: request attempt 0
2021/07/21 15:16:46 [DEBUG] Google API Request Details:
---[ REQUEST ]---------------------------------------
GET /v1beta1/projects/REDACTED/locations/global/operations/operation-1626877005905-5c7a2d207bced-e5da30ad-8ae88c05?alt=json HTTP/1.1
Host: gkehub.googleapis.com
User-Agent: Terraform/0.14.11 (+https://www.terraform.io) Terraform-Plugin-SDK/2.5.0 terraform-provider-google-beta/acc
Content-Type: application/json
Accept-Encoding: gzip


-----------------------------------------------------
2021/07/21 15:16:46 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 200 OK
Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
Cache-Control: private
Content-Type: application/json; charset=UTF-8
Date: Wed, 21 Jul 2021 14:16:46 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "name": "projects/REDACTED/locations/global/operations/operation-1626877005905-5c7a2d207bced-e5da30ad-8ae88c05",
  "metadata": {
    "@type": "type.googleapis.com/google.cloud.gkehub.v1beta1.OperationMetadata",
    "createTime": "2021-07-21T14:16:46.113506135Z",
    "target": "projects/REDACTED/locations/global/memberships/basicakbc1sh7zh",
    "verb": "create",
    "cancelRequested": false,
    "apiVersion": "v1beta1"
  },
  "done": false
}

-----------------------------------------------------
2021/07/21 15:16:46 [DEBUG] Retry Transport: Stopping retries, last request was successful
2021/07/21 15:16:46 [DEBUG] Retry Transport: Returning after 1 attempts
2021/07/21 15:16:46 [DEBUG] Got done: false while polling for operation projects/REDACTED/locations/global/operations/operation-1626877005905-5c7a2d207bced-e5da30ad-8ae88c05's status
2021/07/21 15:16:56 [DEBUG] Waiting for state to become: [success]
2021/07/21 15:16:56 [DEBUG] Retry Transport: starting RoundTrip retry loop
2021/07/21 15:16:56 [DEBUG] Retry Transport: request attempt 0
2021/07/21 15:16:56 [DEBUG] Google API Request Details:
---[ REQUEST ]---------------------------------------
GET /v1beta1/projects/REDACTED/locations/global/operations/operation-1626877005905-5c7a2d207bced-e5da30ad-8ae88c05?alt=json HTTP/1.1
Host: gkehub.googleapis.com
User-Agent: Terraform/0.14.11 (+https://www.terraform.io) Terraform-Plugin-SDK/2.5.0 terraform-provider-google-beta/acc
Content-Type: application/json
Accept-Encoding: gzip


-----------------------------------------------------
2021/07/21 15:16:57 [DEBUG] Google API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/2.0 200 OK
Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
Cache-Control: private
Content-Type: application/json; charset=UTF-8
Date: Wed, 21 Jul 2021 14:16:57 GMT
Server: ESF
Vary: Origin
Vary: X-Origin
Vary: Referer
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
  "name": "projects/REDACTED/locations/global/operations/operation-1626877005905-5c7a2d207bced-e5da30ad-8ae88c05",
  "metadata": {
    "@type": "type.googleapis.com/google.cloud.gkehub.v1beta1.OperationMetadata",
    "createTime": "2021-07-21T14:16:46.113506135Z",
    "endTime": "2021-07-21T14:16:47.559686774Z",
    "target": "projects/REDACTED/locations/global/memberships/basicakbc1sh7zh",
    "verb": "create",
    "cancelRequested": false,
    "apiVersion": "v1beta1"
  },
  "done": true,
  "response": {
    "@type": "type.googleapis.com/google.cloud.gkehub.v1beta1.Membership",
    "name": "projects/REDACTED/locations/global/memberships/basicakbc1sh7zh",
    "description": "test resource.",
    "endpoint": {
      "gkeCluster": {
        "resourceLink": "//container.googleapis.com/projects/REDACTED/locations/us-central1-c/clusters/test"
      }
    },
    "state": {
      "code": "READY"
    },
    "createTime": "2021-07-21T14:16:46.108555032Z",
    "updateTime": "2021-07-21T14:16:46.108555032Z",
    "externalId": "2c82f53a-8155-4f2e-84e3-58f9cb8c49ef",
    "uniqueId": "b18cb6ea-c19c-44d3-a39c-6b7691f15837",
    "infrastructureType": "MULTI_CLOUD"
  }
}

modular-magician · 2021-07-21T21:20:48Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 770 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 18 insertions(+), 20 deletions(-))
TF Conversion: Diff ( 2 files changed, 142 insertions(+))
TF OiCS: Diff ( 1 file changed, 3 deletions(-))

mmv1/products/gkehub/api.yaml

Co-authored-by: upodroid <[email protected]>

modular-magician · 2021-07-21T23:36:22Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 770 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 4 files changed, 21 insertions(+), 21 deletions(-))
TF Conversion: Diff ( 2 files changed, 142 insertions(+))
TF OiCS: Diff ( 1 file changed, 3 deletions(-))

* initial ga work * promote the right resource * remove description from ga * deprecate description Co-authored-by: upodroid <[email protected]>

initial ga work

1d06102

google-cla bot added the cla: yes label Jul 19, 2021

modular-magician requested a review from slevenick July 19, 2021 20:59

upodroid changed the title ~~Promote GKE Hub resources to GA~~ Promote google_gke_hub_membership to GA Jul 19, 2021

promote the right resource

cb6d5db

upodroid mentioned this pull request Jul 20, 2021

Allow google_container_cluster.id reference for the value for the gke_cluster of a google_gke_hub_membership #4985

Merged

5 tasks

remove description from ga

fc89f75

slevenick reviewed Jul 21, 2021

View reviewed changes

mmv1/products/gkehub/api.yaml Show resolved Hide resolved

deprecate description

e16236f

Co-authored-by: upodroid <[email protected]>

slevenick approved these changes Jul 22, 2021

View reviewed changes

slevenick merged commit e444e53 into GoogleCloudPlatform:master Jul 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote `google_gke_hub_membership` to GA #4982

Promote `google_gke_hub_membership` to GA #4982

upodroid commented Jul 19, 2021 •

edited

Loading

modular-magician commented Jul 19, 2021

modular-magician commented Jul 19, 2021

upodroid commented Jul 19, 2021 •

edited

Loading

modular-magician commented Jul 19, 2021

upodroid commented Jul 19, 2021

slevenick commented Jul 19, 2021

modular-magician commented Jul 19, 2021

modular-magician commented Jul 19, 2021

upodroid commented Jul 19, 2021

modular-magician commented Jul 19, 2021

slevenick commented Jul 21, 2021

upodroid commented Jul 21, 2021

modular-magician commented Jul 21, 2021

modular-magician commented Jul 21, 2021

Promote google_gke_hub_membership to GA #4982

Promote google_gke_hub_membership to GA #4982

Conversation

upodroid commented Jul 19, 2021 • edited Loading

modular-magician commented Jul 19, 2021

modular-magician commented Jul 19, 2021

upodroid commented Jul 19, 2021 • edited Loading

modular-magician commented Jul 19, 2021

Diff report:

upodroid commented Jul 19, 2021

slevenick commented Jul 19, 2021

modular-magician commented Jul 19, 2021

Diff report:

modular-magician commented Jul 19, 2021

Diff report:

upodroid commented Jul 19, 2021

modular-magician commented Jul 19, 2021

slevenick commented Jul 21, 2021

upodroid commented Jul 21, 2021

modular-magician commented Jul 21, 2021

Diff report:

modular-magician commented Jul 21, 2021

Diff report:

Promote `google_gke_hub_membership` to GA #4982

Promote `google_gke_hub_membership` to GA #4982

upodroid commented Jul 19, 2021 •

edited

Loading

upodroid commented Jul 19, 2021 •

edited

Loading