Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for diff suppress funcs #5050

Merged
merged 4 commits into from
Aug 9, 2021

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Aug 6, 2021

addresses hashicorp/terraform-provider-google#9700

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 288 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 289 insertions(+), 3 deletions(-))

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these :D

@megan07
Copy link
Contributor Author

megan07 commented Aug 9, 2021

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 288 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 288 insertions(+), 2 deletions(-))

@megan07 megan07 merged commit 7c5cf41 into GoogleCloudPlatform:master Aug 9, 2021
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
* add unit test for optionalPrefixSuppress

* add more unit tests

* add more diff suppress unit tests

* add new line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants