-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add soft deletion retention to KMS key #5131
Add soft deletion retention to KMS key #5131
Conversation
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_update|TestAccComposerEnvironment_withSoftwareConfig|TestAccKmsCryptoKey_destroyDuration|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=202618 |
Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccComposerEnvironment_withSoftwareConfig|TestAccComposerEnvironment_update Please fix these to complete your PR |
Similar to GoogleCloudPlatform#5131, and probably also required for the same customer. Apologies for the oversight.
* Add import-only to KMS key Similar to #5131, and probably also required for the same customer. Apologies for the oversight. * Fix test failure * Ignore skip_initial_version_creation during ImportStateVerify The request attribute `skip_initial_version_creation` controls a creation-time behavior that cannot be subsequently verified.
* Add import-only to KMS key Similar to GoogleCloudPlatform#5131, and probably also required for the same customer. Apologies for the oversight. * Fix test failure * Ignore skip_initial_version_creation during ImportStateVerify The request attribute `skip_initial_version_creation` controls a creation-time behavior that cannot be subsequently verified.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)