Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soft deletion retention to KMS key #5131

Merged

Conversation

slevenick
Copy link
Contributor

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

kms: added support for `destroy_scheduled_duration` to `google_kms_crypto_key`

@google-cla google-cla bot added the cla: yes label Aug 24, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 96 insertions(+))
Terraform Beta: Diff ( 4 files changed, 97 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_update|TestAccComposerEnvironment_withSoftwareConfig|TestAccKmsCryptoKey_destroyDuration|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=202618

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccComposerEnvironment_withSoftwareConfig|TestAccComposerEnvironment_update Please fix these to complete your PR

@slevenick slevenick requested review from a team and c2thorn and removed request for a team August 25, 2021 16:24
@slevenick slevenick merged commit 02f686d into GoogleCloudPlatform:master Aug 25, 2021
@bdhess bdhess mentioned this pull request Aug 26, 2021
5 tasks
bdhess added a commit to bdhess/magic-modules that referenced this pull request Sep 23, 2021
Similar to GoogleCloudPlatform#5131, and probably also required for the same customer.
Apologies for the oversight.
melinath pushed a commit that referenced this pull request Sep 24, 2021
* Add import-only to KMS key

Similar to #5131, and probably also required for the same customer.
Apologies for the oversight.

* Fix test failure

* Ignore skip_initial_version_creation during ImportStateVerify

The request attribute `skip_initial_version_creation` controls a
creation-time behavior that cannot be subsequently verified.
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
* Add import-only to KMS key

Similar to GoogleCloudPlatform#5131, and probably also required for the same customer.
Apologies for the oversight.

* Fix test failure

* Ignore skip_initial_version_creation during ImportStateVerify

The request attribute `skip_initial_version_creation` controls a
creation-time behavior that cannot be subsequently verified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants