Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs for TFC backend #5228

Merged
merged 4 commits into from
Sep 22, 2021
Merged

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Sep 22, 2021

Fixes hashicorp/terraform-provider-google#9917

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 14 insertions(+))
Terraform Beta: Diff ( 4 files changed, 17 insertions(+), 2 deletions(-))

@google-cla
Copy link

google-cla bot commented Sep 22, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 22, 2021
Comment on lines 92 to 93
3. Mark the variable as **Sensitive** and click **Save variable**.
All runs within the workspace will use the `GOOGLE_CREDENTIALS` variable to authenticate with Google Cloud Platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Mark the variable as **Sensitive** and click **Save variable**.
All runs within the workspace will use the `GOOGLE_CREDENTIALS` variable to authenticate with Google Cloud Platform.
3. Mark the variable as **Sensitive** and click **Save variable**.
All runs within the workspace will use the `GOOGLE_CREDENTIALS` variable to authenticate with Google Cloud Platform.

Comment on lines 180 to 181
3. Mark the variable as **Sensitive** and click **Save variable**.
All runs within the workspace will use the `GOOGLE_CREDENTIALS` variable to authenticate with Google Cloud Platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Mark the variable as **Sensitive** and click **Save variable**.
All runs within the workspace will use the `GOOGLE_CREDENTIALS` variable to authenticate with Google Cloud Platform.
3. Mark the variable as **Sensitive** and click **Save variable**.
All runs within the workspace will use the `GOOGLE_CREDENTIALS` variable to authenticate with Google Cloud Platform.

@google-cla
Copy link

google-cla bot commented Sep 22, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Comment on lines 188 to 189
3. Mark the variable as **Sensitive** and click **Save variable**.
All runs within the workspace will use the `GOOGLE_CREDENTIALS` variable to authenticate with Google Cloud Platform.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Mark the variable as **Sensitive** and click **Save variable**.
All runs within the workspace will use the `GOOGLE_CREDENTIALS` variable to authenticate with Google Cloud Platform.
3. Mark the variable as **Sensitive** and click **Save variable**.
All runs within the workspace will use the `GOOGLE_CREDENTIALS` variable to authenticate with Google Cloud Platform.

@google-cla
Copy link

google-cla bot commented Sep 22, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 16 insertions(+))
Terraform Beta: Diff ( 3 files changed, 17 insertions(+), 2 deletions(-))

@laurapacilio
Copy link
Contributor

@googlebot I fixed it.

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 22, 2021
@megan07 megan07 merged commit 1ccc343 into GoogleCloudPlatform:master Sep 22, 2021
trodge pushed a commit to trodge/magic-modules that referenced this pull request Sep 28, 2021
* update docs for TFC backend

* Update mmv1/third_party/terraform/website/docs/guides/provider_reference.html.markdown

Co-authored-by: Laura Pacilio <[email protected]>

* move TFC block

* add line breaks

Co-authored-by: Laura Pacilio <[email protected]>
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
* update docs for TFC backend

* Update mmv1/third_party/terraform/website/docs/guides/provider_reference.html.markdown

Co-authored-by: Laura Pacilio <[email protected]>

* move TFC block

* add line breaks

Co-authored-by: Laura Pacilio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve documentation on how to authenticate to GCP from TFC/TFE
4 participants