-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force-send min_ready_sec #5402
Force-send min_ready_sec #5402
Conversation
running rigm now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did this work previously? It doesn't seem like we ever force sent this field
Ah- it didn't work previously is the answer, we never tested unsetting it. I removed most of the times we set it from our tests when removing it from GA. Adding the appropriate changelog entries. |
RIGM passes, waiting on linters to merge.
|
Followup to #5262,
min_ready_sec
needs to be force-sent to the API in PATCH to set it to zero. That's different than most GCP APIs which only check patch on the top level.No changelog needed, this falls under the previous change.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)