Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not validate INTERNAL_MANAGED backend service capacity. #5484

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

nat-henderson
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#10624.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Fixed incorrectly failing validation for `INTERNAL_MANAGED` `google_compute_region_backend_service`.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 2 insertions(+))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+))
TF Validator: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=223362

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the failing TestAccComputeRegionBackendService_withBackendInternalManaged VCR test related?

@nat-henderson
Copy link
Contributor Author

Yes, in that it is testing for the behavior I removed - will remove!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 8 deletions(-))
TF Validator: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 149 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 149 deletions(-))
TF Validator: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeHealthCheckDatasource_basic|TestAccDataSourceComputeNetworkEndpointGroup|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceComputeImage|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceComputeHaVpnGateway|TestAccDataSourceComputeImageFilter|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceComputeNodeTypes_basic|TestAccComputeRegions_basic|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccInstanceTemplateDatasource_name|TestAccInstanceTemplateDatasource_filter|TestAccDataSourceGoogleNetwork|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccDataSourceComputeInstance_basic|TestAccDataSourceComputeRegionSslCertificate|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceComputeRouter|TestAccComputeZones_basic|TestAccComputeZones_filter|TestAccDataSourceComputeSslCertificate|TestAccDataSourceGoogleSslPolicy|TestAccDataSourceGoogleSubnetwork|TestAccDataSourceGoogleVpnGateway|TestAccContainerClusterDatasource_zonal|TestAccContainerClusterDatasource_regional|TestAccDataSourceGoogleGlobalForwardingRule|TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceSqlDatabaseInstance_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccComputeDiskIamBindingGenerated|TestAccComputeDiskIamMemberGenerated|TestAccComputeImageIamBindingGenerated|TestAccComputeImageIamMemberGenerated|TestAccComputeDiskIamPolicyGenerated|TestAccComputeImageIamPolicyGenerated|TestAccComputeImageIamMemberGenerated_withCondition|TestAccComputeImageIamBindingGenerated_withCondition|TestAccComputeInstanceIamBindingGenerated|TestAccComputeInstanceIamMemberGenerated|TestAccComputeImageIamPolicyGenerated_withCondition|TestAccComputeInstanceIamPolicyGenerated|TestAccComputeInstanceIamBindingGenerated_withCondition|TestAccComputeInstanceIamMemberGenerated_withCondition|TestAccComputeMachineImageIamBindingGenerated|TestAccComputeInstanceIamPolicyGenerated_withCondition|TestAccComputeMachineImageIamMemberGenerated|TestAccComputeMachineImageIamBindingGenerated_withCondition|TestAccComputeMachineImageIamPolicyGenerated|TestAccComputeMachineImageIamMemberGenerated_withCondition|TestAccComputeRegionDiskIamBindingGenerated|TestAccComputeMachineImageIamPolicyGenerated_withCondition|TestAccComputeRegionDiskIamMemberGenerated|TestAccComputeSubnetworkIamBindingGenerated|TestAccComputeSubnetworkIamMemberGenerated|TestAccComputeRegionDiskIamPolicyGenerated|TestAccComputeSubnetworkIamBindingGenerated_withCondition|TestAccComputeSubnetworkIamPolicyGenerated|TestAccComputeSubnetworkIamMemberGenerated_withCondition|TestAccComputeSubnetworkIamPolicyGenerated_withCondition|TestAccIapTunnelInstanceIamBindingGenerated|TestAccIapTunnelInstanceIamMemberGenerated|TestAccIapTunnelInstanceIamPolicyGenerated|TestAccIapTunnelInstanceIamBindingGenerated_withCondition|TestAccIapTunnelInstanceIamMemberGenerated_withCondition|TestAccIapTunnelInstanceIamPolicyGenerated_withCondition|TestAccIapWebBackendServiceIamBindingGenerated|TestAccIapWebBackendServiceIamMemberGenerated|TestAccIapWebBackendServiceIamPolicyGenerated|TestAccIapWebBackendServiceIamBindingGenerated_withCondition|TestAccIapWebBackendServiceIamMemberGenerated_withCondition|TestAccIapWebBackendServiceIamPolicyGenerated_withCondition|TestAccPubsubTopicIamBindingGenerated|TestAccPubsubTopicIamMemberGenerated|TestAccPubsubTopicIamPolicyGenerated|TestAccRuntimeConfigConfigIamPolicyGenerated|TestAccProviderBasePath_setBasePath|TestAccProviderMeta_setModuleName|TestAccApiGatewayApi_apigatewayApiBasicExample|TestAccApiGatewayApi_apigatewayApiFullExample|TestAccApiGatewayGateway_apigatewayGatewayFullExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryBasicExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryCmekExample|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccArtifactRegistryRepository_artifactRegistryRepositoryIamExample|TestAccBillingBudget_billingBudgetCurrencycode|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccCloudRunService_cloudRunServiceSecretEnvironmentVariablesExample|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudSchedulerJob_schedulerJobOauthExample|TestAccCloudSchedulerJob_schedulerJobOidcExample|TestAccCloudRunService_secretVolume|TestAccCloudRunService_secretEnvironmentVariable|TestAccCloudFunctionsFunction_basic|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_serviceAccountEmail|TestAccCloudFunctionsFunction_vpcConnector|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_private|TestAccComposerEnvironment_privateWithWebServerControl|TestAccComposerEnvironment_withDatabaseConfig|TestAccComposerEnvironment_withWebServerConfig|TestAccComposerEnvironment_withNodeConfig|TestAccComposerEnvironment_withMaintenanceWindow|TestAccComposerEnvironment_withUpdateOnCreate|TestAccComputeAddress_addressBasicExample|TestAccComputeAddress_addressWithSubnetworkExample|TestAccComputeAddress_addressWithGceEndpointExample|TestAccComposerEnvironment_withEncryptionConfig|TestAccComputeAddress_instanceWithIpExample|TestAccComputeAddress_addressWithSharedLoadbalancerVipExample|TestAccComputeAddress_computeAddressIpsecInterconnectExample|TestAccComputeAddress_networkTier|TestAccComputeAddress_internal|TestAccComputeAttachedDisk_basic|TestAccComputeAttachedDisk_full|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAttachedDisk_region|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAttachedDisk_count|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_update|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeBackendBucket_backendBucketBasicExample|TestAccComputeBackendService_backendServiceCacheSimpleExample|TestAccComputeBackendService_backendServiceCacheExample|TestAccComputeBackendService_backendServiceBasicExample|TestAccComputeBackendService_backendServiceTrafficDirectorRoundRobinExample|TestAccComputeBackendBucket_backendBucketFullExample|TestAccComputeBackendService_backendServiceTrafficDirectorRingHashExample|TestAccComputeBackendBucketSignedUrlKey_basic|TestAccComputeBackendBucket_basicModified|TestAccComputeBackendBucket_withCdnPolicy|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeBackendServiceSignedUrlKey_basic|TestAccComputeBackendService_withConnectionDraining|TestAccComputeBackendService_basic|TestAccComputeBackendService_updatePreservesOptionalParameters|TestAccComputeBackendService_withHttpsHealthCheck|TestAccComputeBackendService_withConnectionDrainingAndUpdate|TestAccComputeBackendService_withSecurityPolicy|TestAccComputeBackendService_withCdnPolicy|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withCDNEnabled|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_withSessionAffinity|TestAccComputeBackendService_withAffinityCookieTtlSec|TestAccComputeDiskResourcePolicyAttachment_diskResourcePolicyAttachmentBasicExample|TestAccComputeBackendService_withCustomHeaders|TestAccComputeBackendService_withLogConfig|TestAccComputeDiskResourcePolicyAttachment_update|TestAccComputeBackendService_trafficDirectorUpdateBasic|TestAccComputeDisk_fromSnapshot|TestAccComputeDisk_encryption|TestAccComputeBackendService_trafficDirectorUpdateFull|TestAccComputeDisk_update|TestAccComputeDisk_diskBasicExample|TestAccComputeDisk_encryptionKMS|TestAccComputeDisk_deleteDetach|TestAccComputeDisk_resourcePolicies|TestAccComputeDisk_multiWriter|TestAccComputeFirewall_firewallBasicExample|TestAccComputeFirewall_priority|TestAccComputeFirewall_update|TestAccComputeFirewall_denied|TestAccComputeFirewall_egress|TestAccComputeBackendService_regionNegBackend|TestAccComputeFirewall_disabled|TestAccComputeFirewall_enableLogging|TestAccComputeFirewall_serviceAccounts|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_networkTier|TestAccComputeGlobalAddress_globalAddressBasicExample|TestAccComputeGlobalAddress_globalAddressPrivateServicesConnectExample|TestAccComputeGlobalAddress_ipv6|TestAccComputeGlobalAddress_internal|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalNetworkEndpointGroup_globalNetworkEndpointGroupExample|TestAccComputeGlobalNetworkEndpointGroup_globalNetworkEndpointGroupIpAddressExample|TestAccComputeGlobalNetworkEndpoint_networkEndpointsBasic|TestAccComputeHaVpnGateway_haVpnGatewayBasicExample|TestAccComputeHaVpnGateway_computeHaVpnGatewayEncryptedInterconnectExample|TestAccComputeHealthCheck_healthCheckTcpExample|TestAccComputeHealthCheck_healthCheckTcpFullExample|TestAccComputeHealthCheck_healthCheckSslExample|TestAccComputeHealthCheck_healthCheckSslFullExample|TestAccComputeHealthCheck_healthCheckHttpExample|TestAccComputeHealthCheck_healthCheckHttpFullExample|TestAccComputeHealthCheck_healthCheckHttpsExample|TestAccComputeHealthCheck_healthCheckHttpsFullExample|TestAccComputeHealthCheck_healthCheckHttp2FullExample|TestAccComputeHealthCheck_healthCheckHttp2Example|TestAccComputeHealthCheck_healthCheckGrpcFullExample|TestAccComputeHealthCheck_healthCheckGrpcExample|TestAccComputeHealthCheck_healthCheckWithLoggingExample|TestAccComputeHealthCheck_tcp_update|TestAccComputeHealthCheck_ssl_port_spec|TestAccComputeHealthCheck_https_serving_port|TestAccComputeHealthCheck_typeTransition|TestAccComputeHealthCheck_http_port_spec|TestAccComputeHttpHealthCheck_httpHealthCheckBasicExample|TestAccComputeHealthCheck_logConfigDisabled|TestAccComputeImage_withLicense|TestAccComputeHttpHealthCheck_update|TestAccComputeHttpsHealthCheck_httpsHealthCheckBasicExample|TestAccComputeHttpsHealthCheck_update|TestAccComputeImage_imageBasicExample|TestAccComputeImage_imageGuestOsExample|TestAccComputeImage_sourceImage|TestAccComputeImage_basedondisk|TestAccComputeImage_sourceSnapshot|TestAccComputeImage_resolveImage|TestAccComputeImage_update|TestAccComputeInstanceFromTemplate_basic|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromTemplate_overrideScheduling|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_waitForStatus|TestAccComputeInstanceGroup_basic|TestAccComputeInstanceGroup_rename|TestAccComputeInstanceGroup_outOfOrderInstances|TestAccComputeInstanceGroup_update|TestAccComputeInstanceGroup_network|TestAccComputeInstanceTemplate_basic|TestAccComputeInstanceTemplate_preemptible|TestAccComputeInstanceTemplate_IP|TestAccComputeInstanceTemplate_networkTier|TestAccComputeInstanceTemplate_networkIP|TestAccComputeInstanceTemplate_networkIPAddress|TestAccComputeInstanceIamPolicy|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceTemplate_imageShorthand|TestAccComputeInstanceTemplate_disksInvalid|TestAccComputeInstanceTemplate_regionDisks|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_soleTenantNodeAffinities|TestAccComputeInstanceTemplate_EncryptKMS|TestAccComputeInstanceTemplate_reservationAffinities|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_ConfidentialInstanceConfigMain|TestAccComputeInstanceTemplate_AdvancedMachineFeatures|TestAccComputeInstanceTemplate_enableDisplay|TestAccComputeInstanceTemplate_withScratchDisk|TestAccComputeInstanceTemplate_resourcePolicies|TestAccComputeInstance_basic1|TestAccComputeInstance_basic3|TestAccComputeInstance_basic2|TestAccComputeInstance_IP|TestAccComputeInstance_basic4|TestAccComputeInstanceTemplate_nictype_update|TestAccComputeInstance_basic5|TestAccComputeInstance_PTRRecord|TestAccComputeInstance_diskEncryption|TestAccComputeInstance_diskEncryptionRestart|TestAccComputeInstance_networkTier|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeInstance_attachedDisk_modeRo|TestAccComputeInstance_attachedDisk_sourceUrl|TestAccComputeInstance_attachedDisk|TestAccComputeInstance_attachedDiskUpdate|TestAccComputeInstance_bootDisk_sourceUrl|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_bootDisk_type|TestAccComputeInstance_bootDisk_mode|TestAccComputeInstance_forceNewAndChangeMetadata|TestAccComputeInstance_scratchDisk|TestAccComputeInstance_update|TestAccComputeInstance_stopInstanceToUpdate|TestAccComputeInstance_serviceAccount|TestAccComputeInstance_serviceAccount_updated|TestAccComputeInstance_serviceAccount_updated0to1to0scopes|TestAccComputeInstance_scheduling|TestAccComputeInstance_advancedMachineFeatures|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_reservationAffinities|TestAccComputeInstance_subnet_auto|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_network_ip_custom|TestAccComputeInstance_networkIPAuto|TestAccComputeInstance_private_image_family|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_forceChangeMachineTypeManually|TestAccComputeInstance_multiNic|TestAccComputeInstance_guestAcceleratorSkip|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_deletionProtectionExplicitFalse|TestAccComputeInstance_minCpuPlatform|TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse|TestAccComputeInstance_primaryAliasIpRange|TestAccComputeInstance_secondaryAliasIpRange|TestAccComputeInstance_hostname|TestAccComputeInstanceConfidentialInstanceConfigMain|TestAccComputeInstance_shieldedVmConfig|TestAccComputeInstance_nictype_update|TestAccComputeInstance_enableDisplay|TestAccComputeInstance_desiredStatusOnCreation|TestAccComputeInstance_desiredStatusTerminatedUpdateFields|TestAccComputeInstance_desiredStatusUpdateBasic|TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeInstance_resourcePolicyCollocate|TestAccComputeInstance_subnetworkUpdate|TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample|TestAccComputeMachineImage_machineImageBasicExample|TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample|TestAccComputeNetwork_networkBasicExample|TestAccComputeNetworkEndpointGroup_networkEndpointGroupExample|TestAccComputeNetwork_networkCustomMtuExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample|TestAccComputeNetworkPeering_subnetRoutes|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccComputeNetworkPeering_basic|TestAccComputeNetworkPeering_customRoutesUpdate|TestAccComputeNetwork_explicitAutoSubnet|TestAccComputeMachineImage_computeMachineImageKmsExample|TestAccComputeNetwork_customSubnet|TestAccComputeNetwork_routingModeAndUpdate|TestAccComputeNetwork_default_routing_mode|TestAccComputeNodeTemplate_nodeTemplateServerBindingExample|TestAccComputeNetwork_networkDeleteDefaultRoute|TestAccComputeNodeGroup_nodeGroupAutoscalingPolicyExample|TestAccComputeNodeGroup_nodeGroupBasicExample|TestAccComputeNodeGroup_updateNodeTemplate|TestAccComputeNodeTemplate_nodeTemplateBasicExample|TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyBasicExample|TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleBasicExample|TestAccComputePerInstanceConfig_update|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleUpdateExample|TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyUpdateExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeProjectMetadataItem_basic|TestAccComputeProjectMetadataItem_basicWithEmptyVal|TestAccComputeProjectMetadataItem_basicUpdate|TestAccComputeProjectMetadataItem_exists|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_regionBackendServiceCacheExample|TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample|TestAccComputeRegionBackendService_regionBackendServiceExternalExample|TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_ilbUpdateBasic|TestAccComputeProjectDefaultNetworkTier_basic|TestAccComputeProjectDefaultNetworkTier_modify|TestAccComputeRegionDiskResourcePolicyAttachment_regionDiskResourcePolicyAttachmentBasicExample|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeRegionDisk_regionDiskBasicExample|TestAccComputeProjectMetadata_modify_1|TestAccComputeProjectMetadata_basic|TestAccComputeProjectMetadata_modify_2|TestAccComputeRegionDisk_basic|TestAccComputeRegionDisk_basicUpdate|TestAccComputeRegionDisk_encryption|TestAccComputeRegionDisk_deleteDetach|TestAccComputeRegionHealthCheck_regionHealthCheckTcpExample|TestAccComputeRegionHealthCheck_regionHealthCheckTcpFullExample|TestAccComputeRegionHealthCheck_regionHealthCheckSslExample|TestAccComputeRegionHealthCheck_regionHealthCheckSslFullExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttpExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttpLogsExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttpFullExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttpsExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttp2Example|TestAccComputeRegionHealthCheck_regionHealthCheckHttpsFullExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttp2FullExample|TestAccComputeRegionHealthCheck_regionHealthCheckGrpcExample|TestAccComputeRegionHealthCheck_regionHealthCheckGrpcFullExample|TestAccComputeRegionHealthCheck_tcp_update|TestAccComputeRegionHealthCheck_ssl_port_spec|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccComputeRegionHealthCheck_https_serving_port|TestAccRegionInstanceGroupManager_update|TestAccComputeRegionHealthCheck_http_port_spec|TestAccComputeRegionHealthCheck_typeTransition|TestAccRegionInstanceGroupManager_versions|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyHttpsRedirectExample|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample|TestAccComputeRegionTargetHttpProxy_update|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample|TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionUrlMap_regionUrlMapBasicExample|TestAccComputeRegionTargetHttpsProxy_update|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample|TestAccComputeRegionUrlMap_update_path_matcher|TestAccComputeRegionUrlMap_advanced|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample|TestAccComputeRegionUrlMap_noPathRulesWithUpdate|TestAccComputeRegionUrlMap_ilbPathUpdate|TestAccComputeRegionUrlMap_ilbRouteUpdate|TestAccComputeRegionUrlMap_defaultUrlRedirect|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample|TestAccComputeRegionUrlMap_defaultUrlRedirectWithinPathMatcher|TestAccComputeReservation_reservationBasicExample|TestAccComputeResourcePolicy_attached|TestAccComputeReservation_update|TestAccComputeResourcePolicy_resourcePolicyBasicExample|TestAccComputeResourcePolicy_resourcePolicyFullExample|TestAccComputeResourcePolicy_resourcePolicyPlacementPolicyExample|TestAccComputeRoute_hopInstance|TestAccComputeResourcePolicy_resourcePolicyInstanceSchedulePolicyExample|TestAccComputeRoute_routeBasicExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_defaultInternetGateway|TestAccComputeRouterPeer_basic|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouter_routerBasicExample|TestAccComputeRouter_computeRouterEncryptedInterconnectExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterInterface_basic|TestAccComputeRouterNat_update|TestAccComputeRouterNat_basic|TestAccComputeRouterNat_withDisabledIndependentEndpointMapping|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeRouter_basic|TestAccComputeRouter_full|TestAccComputeRouter_noRegion|TestAccComputeRouter_update|TestAccComputeRouter_updateAddRemoveBGP|TestAccComputeSecurityPolicy_basic|TestAccComputeSecurityPolicy_withRule|TestAccComputeSecurityPolicy_withRuleExpr|TestAccComputeSecurityPolicy_withAdaptiveProtection|TestAccComputeSecurityPolicy_update|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeSnapshot_snapshotBasicExample|TestAccComputeSnapshot_encryption|TestAccComputeSslPolicy_sslPolicyBasicExample|TestAccComputeSslPolicy_update|TestAccComputeSslPolicy_update_to_custom|TestAccComputeSslPolicy_update_from_custom|TestAccComputeSubnetwork_subnetworkBasicExample|TestAccComputeSubnetwork_subnetworkLoggingConfigExample|TestAccComputeSubnetwork_subnetworkInternalL7lbExample|TestAccComputeSubnetwork_basic|TestAccComputeSubnetwork_update|TestAccComputeSubnetworkIamPolicy|TestAccComputeSubnetwork_secondaryIpRanges|TestAccComputeSubnetwork_flowLogsMigrate|TestAccComputeSharedVpc_basic|TestAccComputeSubnetwork_flowLogs|TestAccComputeTargetGrpcProxy_targetGrpcProxyBasicExample|TestAccComputeTargetGrpcProxy_update|TestAccComputeTargetHttpProxy_targetHttpProxyBasicExample|TestAccComputeTargetInstance_targetInstanceBasicExample|TestAccComputeTargetHttpProxy_targetHttpProxyHttpsRedirectExample|TestAccComputeTargetHttpProxy_update|TestAccComputeTargetInstance_targetInstanceCustomNetworkExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyBasicExample|TestAccComputeTargetHttpsProxy_update|TestAccComputeTargetPool_basic|TestAccComputeTargetPool_update|TestAccComputeTargetSslProxy_targetSslProxyBasicExample|TestAccComputeTargetSslProxy_update|TestAccComputeTargetTcpProxy_targetTcpProxyBasicExample|TestAccComputeTargetTcpProxy_update|TestAccComputeUrlMap_urlMapTrafficDirectorRoutePartialExample|TestAccComputeUrlMap_urlMapTrafficDirectorRouteExample|TestAccComputeUrlMap_urlMapTrafficDirectorPathExample|TestAccComputeUrlMap_urlMapBasicExample|TestAccComputeUrlMap_urlMapTrafficDirectorPathPartialExample|TestAccComputeUrlMap_urlMapHeaderBasedRoutingExample|TestAccComputeUrlMap_update_path_matcher|TestAccComputeUrlMap_advanced|TestAccComputeUrlMap_urlMapParameterBasedRoutingExample|TestAccComputeUrlMap_defaultRouteActionPathUrlRewrite|TestAccComputeUrlMap_defaultRouteActionUrlRewrite|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorPathUpdate|TestAccComputeUrlMap_noPathRulesWithUpdate|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorUpdate|TestAccComputeUrlMap_trafficDirectorUpdate|TestAccComputeUrlMap_defaultUrlRedirect|TestAccComputeUrlMap_trafficDirectorRemoveRouteRule|TestAccComputeUrlMap_trafficDirectorPathUpdate|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccContainerCluster_basic|TestAccContainerCluster_misc|TestAccContainerCluster_withAddons|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_regional|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withTpu|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withVersion|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_updateVersion|TestAccContainerCluster_network|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_backend|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_basic|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withNetworkConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_resize|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_version|TestAccContainerNodePool_shieldedInstanceConfig|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagChildPoliciesExample|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagBasicExample|TestAccDataCatalogTaxonomy_dataCatalogTaxonomyBasicExample|TestAccDataFusionInstance_dataFusionInstanceBasicExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccDataprocCluster_withInternalIpOnlyTrueAndShieldedConfig|TestAccDataprocWorkflowTemplate_basic|TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample|TestAccDNSManagedZone_dnsManagedZonePrivateExample|TestAccDNSManagedZone_dnsManagedZonePrivatePeeringExample|TestAccDNSManagedZone_dnsManagedZoneServiceDirectoryExample|TestAccDNSManagedZone_privateUpdate|TestAccDNSManagedZone_privateForwardingUpdate|TestAccDNSManagedZone_reverseLookup|TestAccDNSPolicy_dnsPolicyBasicExample|TestAccDNSPolicy_update|TestAccDNSRecordSet_basic|TestAccDNSRecordSet_Update|TestAccDNSRecordSet_changeType|TestAccDNSRecordSet_nestedNS|TestAccDNSRecordSet_quotedTXT|TestAccDNSRecordSet_uppercaseMX|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccEssentialContactsContact_essentialContactExample|TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccFilestoreInstance_update|TestAccFirestoreIndex_firestoreIndexBasicExample|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccSecurityScannerScanConfig_scanConfigUpdate|TestAccProject_deleteDefaultNetwork|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample|TestAccHealthcareHl7V2Store_healthcareHl7V2StoreParserConfigExample|TestAccHealthcareHl7V2Store_healthcareHl7V2StoreUnschematizedExample|TestAccIAMBetaWorkloadIdentityPool_iamWorkloadIdentityPoolBasicExample|TestAccIAMBetaWorkloadIdentityPool_iamWorkloadIdentityPoolFullExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderAwsBasicExample|TestAccHealthcareHl7V2Store_basic|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderAwsFullExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcBasicExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcFullExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestAddressesExample|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginBasicExample|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccNotebooksInstance_create_vm_image|TestAccNotebooksInstance_update|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccPrivatecaCertificate_privatecaCertificateConfigExample|TestAccPrivatecaCertificate_privatecaCertificateCsrExample|TestAccPubsubLiteTopic_pubsubLiteTopicBasicExample|TestAccPubsubTopic_pubsubTopicBasicExample|TestAccRedisInstance_redisInstanceFullExample|TestAccSecurityScannerScanConfig_scanConfigBasicExample|TestAccServiceDirectoryEndpoint_serviceDirectoryEndpointBasicExample|TestAccServiceNetworkingConnection_create|TestAccServiceDirectoryNamespace_serviceDirectoryNamespaceBasicExample|TestAccServiceNetworkingConnection_update|TestAccServiceDirectoryService_serviceDirectoryServiceBasicExample|TestAccServiceUsageConsumerQuotaOverride_consumerQuotaOverrideExample|TestAccServiceUsageConsumerQuotaOverride_consumerQuotaOverrideZeroValueExample|TestAccServiceUsageConsumerQuotaOverride_regionConsumerQuotaOverrideExample|TestAccSQLDatabase_sqlDatabaseBasicExample|TestAccSqlDatabaseInstance_basicSecondGen|TestAccSqlDatabaseInstance_basicMSSQL|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_settings_checkServiceNetworking|TestAccSqlDatabaseInstance_replica|TestAccSqlDatabaseInstance_highAvailability|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_diskspecs|TestAccSqlDatabaseInstance_maintenance|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_multipleOperations|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccSqlDatabaseInstance_withPrivateNetwork|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled|TestAccSqlDatabaseInstance_BackupRetention|TestAccSqlDatabase_basic|TestAccSqlDatabaseInstance_insights|TestAccSqlDatabase_update|TestAccSqlClientCert_mysql|TestAccSqlClientCert_postgres|TestAccSqlUser_postgres|TestAccSqlUser_postgresAbandon|TestAccSqlUser_postgresIAM|TestAccStorageBucketAcl_predefined|TestAccStorageBucket_requesterPays|TestAccStorageBucket_lowercaseLocation|TestAccStorageBucket_customAttributes|TestAccStorageBucket_basic|TestAccStorageBucket_lifecycleRuleStateLive|TestAccStorageBucket_lifecycleRuleStateArchived|TestAccStorageBucket_versioning|TestAccStorageBucket_update_requesterPays|TestAccStorageBucket_forceDestroy|TestAccStorageBucket_defaultEventBasedHold|TestAccStorageBucket_cors|TestAccStorageBucket_forceDestroyObjectDeleteError|TestAccStorageBucket_forceDestroyWithVersioning|TestAccStorageBucket_logging|TestAccStorageDefaultObjectAcl_basic|TestAccStorageDefaultObjectAcl_noRoleEntity|TestAccStorageBucket_retentionPolicy|TestAccStorageBucket_uniformBucketAccessOnly|TestAccStorageDefaultObjectAcl_upgrade|TestAccStorageBucket_lifecycleRuleStateAny|TestAccStorageDefaultObjectAcl_downgrade|TestAccStorageDefaultObjectAcl_unordered|TestAccStorageBucket_labels|TestAccStorageBucket_website|TestAccStorageTransferJob_basic|TestAccTPUNode_tpuNodeFullExample|TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample|TestAccVPCAccessConnector_vpcAccessConnectorThroughput|TestAccComputeResourceUsageExportBucket You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=226118

@nat-henderson
Copy link
Contributor Author

Wow, something exciting must have been merged recently.

@nat-henderson
Copy link
Contributor Author

Okay - the union of the (eventual) failures there and the failures before show that this is good to merge, since that was just test code getting removed.

@nat-henderson nat-henderson merged commit a9fb176 into master Dec 1, 2021
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
…udPlatform#5484)

* Do not validate INTERNAL_MANAGED backend service capacity.

* remove test expecting this behavior.

* remove a bunch of dead code that the linter complained about.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_region_backend_service using INTERNAL_MANAGED not handling cloud run in group
3 participants