Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer GA update #5492

Merged

Conversation

kubasieron
Copy link
Contributor

@kubasieron kubasieron commented Nov 26, 2021

Move several fields to GA. Those fields are already supported by Cloud Composer API. Fields list:

  • web_server_network_access_control,
  • database_config,
  • web_server_config,
  • encryption_config.

It is just a preview of change, it should work on beta envs, but won't on GA envs until composer v2 fields are added to go API: https://pkg.go.dev/google.golang.org/[email protected]/composer/v1

fixes hashicorp/terraform-provider-google/issues/10643

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloud_composer: Added GA support for following fields:  `web_server_network_access_control`, `database_config`, `web_server_config`, `encryption_config`.

@google-cla google-cla bot added the cla: yes label Nov 26, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 724 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 8 deletions(-))

@kubasieron kubasieron changed the title Composer GA update [DO NOT MERGE] Composer GA update Nov 27, 2021
@kubasieron
Copy link
Contributor Author

kubasieron commented Dec 10, 2021

Any updates/problems with that PR? In my opinion it should be straightforward @ScottSuarez

@ScottSuarez
Copy link
Contributor

Can you update your note to follow the Release Notes Guidelines?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 765 insertions(+), 48 deletions(-))
Terraform Beta: Diff ( 2 files changed, 44 insertions(+), 48 deletions(-))

@ScottSuarez
Copy link
Contributor

/gcbrun

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 725 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccContainerNodePool_withInvalidUpgradeSettings You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=237989

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccApigeeEnvironmentIamBindingGenerated Please fix these to complete your PR

@ScottSuarez ScottSuarez merged commit 45405d8 into GoogleCloudPlatform:master Jan 4, 2022
xuchenma pushed a commit to xuchenma/magic-modules that referenced this pull request Jan 7, 2022
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move several fields from Cloud Composer to GA
3 participants