-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer GA update #5492
Composer GA update #5492
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
Any updates/problems with that PR? In my opinion it should be straightforward @ScottSuarez |
Can you update your note to follow the Release Notes Guidelines? |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccContainerNodePool_withInvalidUpgradeSettings You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=237989 |
Tests failed during RECORDING mode: TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccApigeeEnvironmentIamBindingGenerated Please fix these to complete your PR |
Move several fields to GA. Those fields are already supported by Cloud Composer API. Fields list:
It is just a preview of change, it should work on beta envs, but won't on GA envs until composer v2 fields are added to go API: https://pkg.go.dev/google.golang.org/[email protected]/composer/v1
fixes hashicorp/terraform-provider-google/issues/10643
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)