-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry GCE's (new?) 403 ReadRequests errors #5723
Retry GCE's (new?) 403 ReadRequests errors #5723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding quotas for reads feels like it will have a negative impact for Terraform in general. Do we have the ability to push back on the service team that implemented this?
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=258553 |
Hm- may not have been an API change, see thread in chat. Not sure of the quota pressure source, if that's the case. |
This is causing around 100 failing tests/night. This will squeeze our test times out even further, unfortunately, but that's better than 10% of our tests failing between this and the folder fanout stuff that should be resolved soon. Submitted b/219804040 to get more quota to mitigate that.
Also see b/176370895 where another Google team ran into the issue.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)