-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dialect to spanner database #5799
Merged
rileykarson
merged 9 commits into
GoogleCloudPlatform:main
from
rahul2393:spanner-dialect
Mar 28, 2022
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1c43a52
Add dialect to spanner database
rahul2393 4572337
fix tests
rahul2393 15f8c93
fix tests
rahul2393 0aea37b
fix database name when using POSTGRESQL dialect
rahul2393 85a4b2c
use `default_from_api` for backward compatibility
rahul2393 a95eb1a
incorporate requested changes
rahul2393 e29385a
fix tests
rahul2393 a01a629
incorporate requested changes
rahul2393 efaf6a4
remove unused code
rahul2393 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
obj["createStatement"] = fmt.Sprintf("CREATE DATABASE `%s`", obj["name"]) | ||
if dialect, ok := obj["databaseDialect"]; ok && dialect == "POSTGRESQL" { | ||
obj["createStatement"] = fmt.Sprintf("CREATE DATABASE %s", obj["name"]) | ||
} | ||
delete(obj, "name") | ||
delete(obj, "instance") | ||
return obj, nil |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gonna be a pretty bad experience for Terraform users as it's a strong expectation in the ecosystem that a single
terraform apply
will finish setting up your infrastructure in one go. It's your team's API, though, and if this is the UX you want we'll accept it. I will note, our team will not amend this ourselves if that's the chosen path.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the known limitation for now that DDL statements are not part of create database call.
cc: @aseering