-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access Approval custom signing key support #5865
Conversation
# Conflicts: # mmv1/third_party/terraform/utils/provider.go.erb
…(to avoid eventually consistency errors caused by creating a folder and then using it)
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 20 files changed, 1081 insertions(+), 2 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceAccessApprovalFolderServiceAccount_basic|TestAccDataprocMetastoreServiceDatasource_basic|TestAccAccessApprovalSettings|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccSpannerDatabase_postgres You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=273908 |
Fixes hashicorp/terraform-provider-google#11370
Adds fields for configuring custom signing key for Access Approval. Adds data sources to fetch service account name for configuring IAM policy on signing keys.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)