Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAM support for privateca CertificateTemplate #5904

Merged

Conversation

gfxcc
Copy link
Contributor

@gfxcc gfxcc commented Apr 6, 2022

Fixes hashicorp/terraform-provider-google#10938

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_privateca_certificate_template_iam_binding`
`google_privateca_certificate_template_iam_member`
`google_privateca_certificate_template_iam_policy`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@shuyama1, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 711 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1046 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 355 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@gfxcc
Copy link
Contributor Author

gfxcc commented Apr 6, 2022

Fixed the mentioned release-note issue.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1975
Passed tests 1704
Skipped tests: 239
Failed tests: 32

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessApprovalSettings|TestAccAccessContextManager|TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_regionFromLocation|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceBasicExample|TestAccComputeUrlMap_defaultUrlRedirect|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeInstance_serviceAccount_updated|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccComposerEnvironment_composerV2MasterAuthNetworksUpdate|TestAccComposerEnvironment_composerV2MasterAuthNetworks|TestAccComposerEnvironment_composerV1MasterAuthNetworksUpdate|TestAccComposerEnvironment_composerV1MasterAuthNetworks|TestAccComposerEnvironment_composerV2PrivateServiceConnect|TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironment_ComposerV2|TestAccComposerEnvironmentAirflow2_withSoftwareConfig|TestAccComposerEnvironment_withSoftwareConfig|TestAccCGCSnippet_storageNewBucketExample|TestAccCGCSnippet_flaskGoogleCloudQuickstartExample|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccRedisInstanceDatasource_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

@shuyama1
Copy link
Member

shuyama1 commented Apr 8, 2022

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 711 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1046 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 355 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1979
Passed tests 1727
Skipped tests: 239
Failed tests: 13

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample[view]
TestAccServiceNetworkingPeeredDNSDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition[view]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition[view]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition[view]
TestAccPrivatecaCertificateTemplateIamMemberGenerated[view]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated[view]
TestAccPrivatecaCertificateTemplateIamBindingGenerated[view]

Tests failed during RECORDING mode:
TestAccAccessContextManager[view]
TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample[view]
TestAccContainerCluster_withAuthenticatorGroupsConfig[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@shuyama1
Copy link
Member

/gcbrun

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you so much for your contribution! Will merge this after all tests done.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 711 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1046 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 355 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1979
Passed tests 1736
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccComputeForwardingRule_update[view]

Tests failed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@shuyama1 shuyama1 merged commit 1a8e59e into GoogleCloudPlatform:main Apr 11, 2022
@gfxcc
Copy link
Contributor Author

gfxcc commented Apr 11, 2022

Thank you @shuyama1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support google_privateca_certificate_template_iam_*
3 participants