-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exclusion scope in the maintenance exclusion #5914
Add exclusion scope in the maintenance exclusion #5914
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
|
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 295 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccServiceNetworkingPeeredDNSDomain_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
@ScottSuarez Can you please help review this PR? |
/gcbrun |
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
|
Sure! Thanks for the ping, this fell off my radar |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 295 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccServiceNetworkingPeeredDNSDomain_basic |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccConfigLoadValidate_impersonated|TestAccConfigLoadValidate_accessTokenImpersonated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccAccessContextManager|TestAccCGCSnippet_sqlDatabaseInstanceSqlserverExample|TestAccCGCSnippet_sqlDatabaseInstanceMySqlExample|TestAccCGCSnippet_sqlSqlserverInstanceBackupExample|TestAccCGCSnippet_sqlSqlserverInstanceBackupLocationExample|TestAccCGCSnippet_sqlSqlserverInstanceBackupRetentionExample|TestAccCGCSnippet_sqlMysqlInstanceReplicaExample|TestAccCGCSnippet_sqlSqlserverInstancePrivateIpExample|TestAccCloudRunService_cloudRunServiceUpdate|TestAccCloudRunService_foregroundDeletion|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeSecurityPolicy_withRuleExpr|TestAccComputeSecurityPolicy_withRateLimitOptions|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccContainerCluster_withAddons|TestAccContainerAzureCluster_BasicHandWritten|TestAccDataprocCluster_withImageVersion|TestAccDataprocWorkflowTemplate_basic|TestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXEntityType_dialogflowcxEntityTypeFullExample|TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentFullExample|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccDialogflowCXIntent_dialogflowcxIntentFullExample|TestAccDialogflowCXPage_dialogflowcxPageFullExample|TestAccDialogflowCXVersion_dialogflowcxVersionFullExample|TestAccDialogflowCXEntityType_update|TestAccDialogflowCXEnvironment_update|TestAccDialogflowCXIntent_update|TestAccDialogflowCXFlow_update|TestAccDialogflowCXPage_update|TestAccDialogflowCXVersion_update|TestAccDialogflowCXAgent_update|TestAccFirebaserulesRelease_BasicRelease|TestAccOrganizationPolicy|TestAccNotebooksRuntime_notebookRuntimeBasicContainerExample|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccSpannerDatabase_postgres|TestAccSQLDatabase_sqlDatabaseBasicExample|TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=287932 |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 301 insertions(+), 8 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease |
Add support for exclusion scope in the maintenance exclusion
hashicorp/terraform-provider-google#11274
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.