Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclusion scope in the maintenance exclusion #5914

Merged
merged 6 commits into from
May 6, 2022

Conversation

600lyy
Copy link
Member

@600lyy 600lyy commented Apr 8, 2022

Add support for exclusion scope in the maintenance exclusion
hashicorp/terraform-provider-google#11274

If this PR is for Terraform, I acknowledge that I have:

  • [ x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ x] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ x] Read the Release Notes Guide before writing my release note below.
container: added field `exclusion_options` to `google_container_cluster`

@modular-magician
Copy link
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 295 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 295 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1975
Passed tests 1729
Skipped tests: 238
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccServiceNetworkingPeeredDNSDomain_basic

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccContainerCluster_updateMaintenanceExclusionOptions[view]
TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample[view]
TestAccServiceNetworkingPeeredDNSDomain_basic[view]
TestAccContainerCluster_withMaintenanceExclusionOptions[view]
TestAccContainerCluster_deleteMaintenanceExclusionOptions[view]

Tests failed during RECORDING mode:
TestAccAccessContextManager[view]
TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample[view]
TestAccContainerCluster_withAuthenticatorGroupsConfig[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@600lyy
Copy link
Member Author

600lyy commented May 6, 2022

@ScottSuarez Can you please help review this PR?

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

@ScottSuarez
Copy link
Contributor

Sure! Thanks for the ping, this fell off my radar

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 295 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 295 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2011
Passed tests 1767
Skipped tests: 242
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccServiceNetworkingPeeredDNSDomain_basic

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccServiceNetworkingPeeredDNSDomain_basic[view]

All tests passed
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccConfigLoadValidate_impersonated|TestAccConfigLoadValidate_accessTokenImpersonated|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccAccessContextManager|TestAccCGCSnippet_sqlDatabaseInstanceSqlserverExample|TestAccCGCSnippet_sqlDatabaseInstanceMySqlExample|TestAccCGCSnippet_sqlSqlserverInstanceBackupExample|TestAccCGCSnippet_sqlSqlserverInstanceBackupLocationExample|TestAccCGCSnippet_sqlSqlserverInstanceBackupRetentionExample|TestAccCGCSnippet_sqlMysqlInstanceReplicaExample|TestAccCGCSnippet_sqlSqlserverInstancePrivateIpExample|TestAccCloudRunService_cloudRunServiceUpdate|TestAccCloudRunService_foregroundDeletion|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeIlbVipExample|TestAccComputeSecurityPolicy_withRuleExpr|TestAccComputeSecurityPolicy_withRateLimitOptions|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccContainerCluster_withAddons|TestAccContainerAzureCluster_BasicHandWritten|TestAccDataprocCluster_withImageVersion|TestAccDataprocWorkflowTemplate_basic|TestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXEntityType_dialogflowcxEntityTypeFullExample|TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentFullExample|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccDialogflowCXIntent_dialogflowcxIntentFullExample|TestAccDialogflowCXPage_dialogflowcxPageFullExample|TestAccDialogflowCXVersion_dialogflowcxVersionFullExample|TestAccDialogflowCXEntityType_update|TestAccDialogflowCXEnvironment_update|TestAccDialogflowCXIntent_update|TestAccDialogflowCXFlow_update|TestAccDialogflowCXPage_update|TestAccDialogflowCXVersion_update|TestAccDialogflowCXAgent_update|TestAccFirebaserulesRelease_BasicRelease|TestAccOrganizationPolicy|TestAccNotebooksRuntime_notebookRuntimeBasicContainerExample|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccSpannerDatabase_postgres|TestAccSQLDatabase_sqlDatabaseBasicExample|TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=287932

@ScottSuarez
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 301 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 6 files changed, 303 insertions(+), 10 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2013
Passed tests 1770
Skipped tests: 242
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]

All tests passed
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants