-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertex model deployment #6160
Vertex model deployment #6160
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 50 files changed, 4633 insertions(+), 58 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRuleset_MinimalRuleset|TestAccFirebaserulesRuleset_BasicRuleset|TestAccFirebaserulesRelease_MinimalRelease|TestAccFirebaserulesRelease_BasicRelease|TestAccEventarcTrigger_BasicHandWritten|TestAccOsConfigOsPolicyAssignment_PercentOsPolicyAssignment|TestAccOsConfigOsPolicyAssignment_FixedOsPolicyAssignment|TestAccOrgPolicyPolicy_OrganizationPolicy|TestAccDataprocWorkflowTemplate_basic|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccContainerCluster_withConfidentialNodes|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccOrgPolicyPolicy_FolderPolicy|TestAccContainerCluster_withAddons|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccContainerAzureNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccContainerAzureCluster_BetaBasicHandWritten|TestAccContainerAzureCluster_BasicHandWritten|TestAccContainerAzureClient_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccOrgPolicyPolicy_EnforcePolicy|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsCluster_BasicHandWritten|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterInterface_basic|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_regionFromGateway|TestAccDataplexLake_BasicLake|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_update|TestAccComputeFirewallPolicy_update|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicyAssociation_basic|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccCloudbuildWorkerPool_basic|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccCloudRunService_eventarcBasicTfExample|TestAccBigqueryReservationAssignment_BasicHandWritten|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccApikeysKey_IosKey|TestAccApikeysKey_ServerKey|TestAccApikeysKey_BasicKey|TestAccApikeysKey_AndroidKey|TestAccApikeysKey_MinimalKey|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccClouddeployTarget_Target|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccCloudbuildWorkerPool_withNetwork|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccSqlUser_mysqlDisabled|TestAccVertexAiEndpoint_NetworkHandWritten|TestAccVertexAiEndpoint_BasicEndpoint|TestAccVertexAIDataset_vertexAiDatasetExample|TestAccVertexAiModel_BasicModel|TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten|TestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccNetworkConnectivityHub_BasicHub|TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccRecaptchaEnterpriseKey_WebScoreKey|TestAccRecaptchaEnterpriseKey_WebKey|TestAccRecaptchaEnterpriseKey_MinimalKey|TestAccRecaptchaEnterpriseKey_IosKey|TestAccRecaptchaEnterpriseKey_AndroidKey|TestAccLoggingLogView_BasicHandWritten|TestAccMonitoringMonitoredProject_BasicMonitoredProject|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceGoogleGlobalForwardingRule |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
c0ed1ed
to
0c889ab
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 55 files changed, 4631 insertions(+), 82 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccClouddeployTarget_Target|TestAccVertexAiEndpoint_BasicEndpoint|TestAccVertexAIDataset_vertexAiDatasetExample|TestAccVertexAiModel_BasicModel|TestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccVertexAiEndpoint_NetworkHandWritten |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 55 files changed, 4611 insertions(+), 85 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccClouddeployTarget_Target|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample|TestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAiModel_BasicModel|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccVertexAiEndpoint_NetworkHandWritten|TestAccVertexAIDataset_vertexAiDatasetExample|TestAccVertexAiEndpoint_BasicEndpoint |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 55 files changed, 4611 insertions(+), 85 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccVertexAiModel_BasicModel|TestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccVertexAiEndpoint_NetworkHandWritten|TestAccVertexAiEndpoint_BasicEndpoint|TestAccVertexAIDataset_vertexAiDatasetExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
99e975e
to
a795b70
Compare
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 54 files changed, 4599 insertions(+), 85 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccVertexAiModel_BasicModel|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 54 files changed, 4601 insertions(+), 85 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAiModel_BasicModel|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 54 files changed, 4601 insertions(+), 85 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccVertexAiModel_BasicModel|TestAccVertexAiModelDeployment_BasicModelDeployment |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
06aaedb
to
401901a
Compare
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 51 files changed, 4584 insertions(+), 102 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlUser_mysqlDisabled |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be split into a few different PRs? Namely, a PR per resource, and a separate one for the ID function change (unless there's a strong requirement for making that change that it's paired with a resource, which is sometimes the case).
Multi-resource reviews are hard to keep track of as a reviewer, and can have extremely long review cycles as they take enough time to go through that review iterations happen once a day or less. If it's necessary we hold all the resources and release them at once we can use a branch, similar to use a diffbase internally. The litmus test I use personally is that each PR should so one thing- "add X resource", "add y feature", or "change z assumption/rule".
Closing this PR - seems like it's no longer relevant. |
Add the following resources:
google_vertex_ai_endpoint
google_vertex_ai_endpoint_traffic_split
google_vertex_ai_metadata_schema
google_vertex_ai_model
google_vertex_ai_model_deployment
part of hashicorp/terraform-provider-google#9298
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)