Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex model deployment #6160

Closed
wants to merge 18 commits into from

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Jun 23, 2022

Add the following resources:
google_vertex_ai_endpoint
google_vertex_ai_endpoint_traffic_split
google_vertex_ai_metadata_schema
google_vertex_ai_model
google_vertex_ai_model_deployment
part of hashicorp/terraform-provider-google#9298

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_vertex_ai_endpoint
google_vertex_ai_endpoint_traffic_split
google_vertex_ai_metadata_schema
google_vertex_ai_model
google_vertex_ai_model_deployment

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 50 files changed, 4633 insertions(+), 58 deletions(-))
Terraform Beta: Diff ( 53 files changed, 4788 insertions(+), 64 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2060
Passed tests 1720
Skipped tests: 226
Failed tests: 114

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRuleset_MinimalRuleset|TestAccFirebaserulesRuleset_BasicRuleset|TestAccFirebaserulesRelease_MinimalRelease|TestAccFirebaserulesRelease_BasicRelease|TestAccEventarcTrigger_BasicHandWritten|TestAccOsConfigOsPolicyAssignment_PercentOsPolicyAssignment|TestAccOsConfigOsPolicyAssignment_FixedOsPolicyAssignment|TestAccOrgPolicyPolicy_OrganizationPolicy|TestAccDataprocWorkflowTemplate_basic|TestAccOrgPolicyPolicy_ProjectPolicy|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccContainerCluster_withConfidentialNodes|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccOrgPolicyPolicy_FolderPolicy|TestAccContainerCluster_withAddons|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccContainerAzureNodePool_BetaBasicHandWritten|TestAccContainerAzureNodePool_BasicHandWritten|TestAccContainerAzureCluster_BetaBasicHandWritten|TestAccContainerAzureCluster_BasicHandWritten|TestAccContainerAzureClient_BasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccOrgPolicyPolicy_EnforcePolicy|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsCluster_BasicHandWritten|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterInterface_basic|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccComputeVpnTunnel_regionFromGateway|TestAccDataplexLake_BasicLake|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeForwardingRule_serviceDirectoryRegistrations|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_update|TestAccComputeFirewallPolicy_update|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicyAssociation_basic|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccCloudbuildWorkerPool_basic|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccCloudRunService_eventarcBasicTfExample|TestAccBigqueryReservationAssignment_BasicHandWritten|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccApikeysKey_IosKey|TestAccApikeysKey_ServerKey|TestAccApikeysKey_BasicKey|TestAccApikeysKey_AndroidKey|TestAccApikeysKey_MinimalKey|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccClouddeployTarget_Target|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccCloudbuildWorkerPool_withNetwork|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccSqlUser_mysqlDisabled|TestAccVertexAiEndpoint_NetworkHandWritten|TestAccVertexAiEndpoint_BasicEndpoint|TestAccVertexAIDataset_vertexAiDatasetExample|TestAccVertexAiModel_BasicModel|TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten|TestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccNetworkConnectivityHub_BasicHub|TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccRecaptchaEnterpriseKey_WebScoreKey|TestAccRecaptchaEnterpriseKey_WebKey|TestAccRecaptchaEnterpriseKey_MinimalKey|TestAccRecaptchaEnterpriseKey_IosKey|TestAccRecaptchaEnterpriseKey_AndroidKey|TestAccLoggingLogView_BasicHandWritten|TestAccMonitoringMonitoredProject_BasicMonitoredProject|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceGoogleGlobalForwardingRule

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccSqlUser_mysqlDisabled[view]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleForwardingRule[view]
TestAccComputeRouterInterface_withTunnel[view]
TestAccVertexAiModel_BasicModel[view]
TestAccVertexAiModelDeployment_BasicModelDeployment[view]
TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample[view]
TestAccVertexAiMetadataSchema_BasicHandWritten[view]
TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample[view]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[view]
TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit[view]
TestAccVertexAiEndpoint_NetworkHandWritten[view]
TestAccVertexAiEndpoint_BasicEndpoint[view]
TestAccVertexAIDataset_vertexAiDatasetExample[view]
TestAccRecaptchaEnterpriseKey_WebScoreKey[view]
TestAccRecaptchaEnterpriseKey_WebKey[view]
TestAccRecaptchaEnterpriseKey_MinimalKey[view]
TestAccRecaptchaEnterpriseKey_IosKey[view]
TestAccRecaptchaEnterpriseKey_AndroidKey[view]
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate[view]
TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample[view]
TestAccOsConfigOsPolicyAssignment_PercentOsPolicyAssignment[view]
TestAccOsConfigOsPolicyAssignment_FixedOsPolicyAssignment[view]
TestAccOrgPolicyPolicy_ProjectPolicy[view]
TestAccOrgPolicyPolicy_OrganizationPolicy[view]
TestAccOrgPolicyPolicy_FolderPolicy[view]
TestAccOrgPolicyPolicy_EnforcePolicy[view]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten[view]
TestAccNetworkConnectivityHub_BasicHub[view]
TestAccMonitoringMonitoredProject_BasicMonitoredProject[view]
TestAccLoggingLogView_BasicHandWritten[view]
TestAccFirebaserulesRuleset_MinimalRuleset[view]
TestAccFirebaserulesRuleset_BasicRuleset[view]
TestAccFirebaserulesRelease_MinimalRelease[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccEventarcTrigger_BasicHandWritten[view]
TestAccDataprocWorkflowTemplate_basic[view]
TestAccDataplexLake_BasicLake[view]
TestAccContainerCluster_withConfidentialNodes[view]
TestAccContainerCluster_withAddons[view]
TestAccContainerAzureNodePool_BetaBasicHandWritten[view]
TestAccContainerAzureNodePool_BasicHandWritten[view]
TestAccContainerAzureCluster_BetaBasicHandWritten[view]
TestAccContainerAzureCluster_BasicHandWritten[view]
TestAccContainerAzureClient_BasicHandWritten[view]
TestAccContainerAwsNodePool_BetaBasicHandWritten[view]
TestAccContainerAwsNodePool_BasicHandWritten[view]
TestAccContainerAwsCluster_BetaBasicHandWritten[view]
TestAccContainerAwsCluster_BasicHandWritten[view]
TestAccComputeVpnTunnel_defaultTrafficSelectors[view]
TestAccComputeVpnTunnel_router[view]
TestAccComputeVpnTunnel_regionFromGateway[view]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[view]
TestAccComputeVpnTunnel_vpnTunnelBasicExample[view]
TestAccComputeVpnGateway_targetVpnGatewayBasicExample[view]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[view]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[view]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[view]
TestAccComputeForwardingRule_forwardingRuleBasicExample[view]
TestAccComputeRouterInterface_basic[view]
TestAccComputeRouterPeer_bfd[view]
TestAccComputeRouterPeer_enable[view]
TestAccComputeRouterPeer_advertiseMode[view]
TestAccComputeRouterPeer_basic[view]
TestAccComputeRoute_routeIlbVipExample[view]
TestAccComputeRoute_routeIlbExample[view]
TestAccComputePacketMirroring_computePacketMirroringFullExample[view]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccComputeGlobalForwardingRule_labels[view]
TestAccComputeGlobalForwardingRule_ipv6[view]
TestAccComputeGlobalForwardingRule_updateTarget[view]
TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[view]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[view]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[view]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[view]
TestAccComputeForwardingRule_serviceDirectoryRegistrations[view]
TestAccComputeForwardingRule_networkTier[view]
TestAccComputeForwardingRule_ip[view]
TestAccComputeForwardingRule_update[view]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[view]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[view]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[view]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[view]
TestAccBigqueryReservationAssignment_BasicHandWritten[view]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[view]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[view]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[view]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[view]
TestAccComputeFirewallPolicy_update[view]
TestAccComputeFirewallPolicyRule_multipleRules[view]
TestAccComputeFirewallPolicyRule_update[view]
TestAccComputeFirewallPolicyAssociation_basic[view]
TestAccClouddeployTarget_Target[view]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[view]
TestAccCloudbuildWorkerPool_withNetwork[view]
TestAccCloudbuildWorkerPool_basic[view]
TestAccCloudRunService_eventarcBasicTfExample[view]
TestAccApikeysKey_AndroidKey[view]
TestAccAssuredWorkloadsWorkload_FullHandWritten[view]
TestAccAssuredWorkloadsWorkload_BasicHandWritten[view]
TestAccApikeysKey_ServerKey[view]
TestAccApikeysKey_MinimalKey[view]
TestAccApikeysKey_IosKey[view]
TestAccApikeysKey_BasicKey[view]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated[view]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition[view]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition[view]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition[view]
TestAccPrivatecaCertificateTemplateIamBindingGenerated[view]
TestAccPrivatecaCertificateTemplateIamMemberGenerated[view]
TestAccDataSourceGoogleGlobalForwardingRule[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@trodge trodge force-pushed the vertex-model-deployment branch 3 times, most recently from c0ed1ed to 0c889ab Compare June 28, 2022 21:00
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 55 files changed, 4631 insertions(+), 82 deletions(-))
Terraform Beta: Diff ( 57 files changed, 4781 insertions(+), 92 deletions(-))
TF Validator: Diff ( 2 files changed, 7 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2065
Passed tests 1822
Skipped tests: 226
Failed tests: 17

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccClouddeployTarget_Target|TestAccVertexAiEndpoint_BasicEndpoint|TestAccVertexAIDataset_vertexAiDatasetExample|TestAccVertexAiModel_BasicModel|TestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccVertexAiEndpoint_NetworkHandWritten

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 55 files changed, 4611 insertions(+), 85 deletions(-))
Terraform Beta: Diff ( 57 files changed, 4761 insertions(+), 97 deletions(-))
TF Validator: Diff ( 2 files changed, 7 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2065
Passed tests 1823
Skipped tests: 226
Failed tests: 16

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccClouddeployTarget_Target|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample|TestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAiModel_BasicModel|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccVertexAiEndpoint_NetworkHandWritten|TestAccVertexAIDataset_vertexAiDatasetExample|TestAccVertexAiEndpoint_BasicEndpoint

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccClouddeployTarget_Target[view]
TestAccContainerAwsNodePool_BetaBasicHandWritten[view]
TestAccContainerAwsNodePool_BasicHandWritten[view]
TestAccContainerAwsCluster_BetaBasicHandWritten[view]

Tests failed during RECORDING mode:
TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit[view]
TestAccVertexAiModel_BasicModel[view]
TestAccVertexAiModelDeployment_BasicModelDeployment[view]
TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample[view]
TestAccVertexAiMetadataSchema_BasicHandWritten[view]
TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample[view]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[view]
TestAccContainerCluster_withConfidentialNodes[view]
TestAccVertexAiEndpoint_NetworkHandWritten[view]
TestAccVertexAiEndpoint_BasicEndpoint[view]
TestAccVertexAIDataset_vertexAiDatasetExample[view]
TestAccContainerCluster_withAddons[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@trodge
Copy link
Contributor Author

trodge commented Jun 29, 2022

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 55 files changed, 4611 insertions(+), 85 deletions(-))
Terraform Beta: Diff ( 57 files changed, 4761 insertions(+), 97 deletions(-))
TF Validator: Diff ( 2 files changed, 7 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2068
Passed tests 1828
Skipped tests: 226
Failed tests: 14

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccVertexAiModel_BasicModel|TestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample|TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccVertexAiEndpoint_NetworkHandWritten|TestAccVertexAiEndpoint_BasicEndpoint|TestAccVertexAIDataset_vertexAiDatasetExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccVertexAiEndpoint_NetworkHandWritten[view]
TestAccVertexAiEndpoint_BasicEndpoint[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]

Tests failed during RECORDING mode:
TestAccContainerCluster_withAddons[view]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[view]
TestAccVertexAiModel_BasicModel[view]
TestAccVertexAiModelDeployment_BasicModelDeployment[view]
TestAccVertexAIMetadataStore_vertexAiMetadataStoreExample[view]
TestAccVertexAiMetadataSchema_BasicHandWritten[view]
TestAccVertexAIFeaturestore_vertexAiFeaturestoreExample[view]
TestAccVertexAIDataset_vertexAiDatasetExample[view]
TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit[view]
TestAccContainerCluster_withConfidentialNodes[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@trodge
Copy link
Contributor Author

trodge commented Jun 30, 2022

/gcbrun

@trodge trodge closed this Jun 30, 2022
@trodge trodge reopened this Jun 30, 2022
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 54 files changed, 4599 insertions(+), 85 deletions(-))
Terraform Beta: Diff ( 56 files changed, 4749 insertions(+), 97 deletions(-))
TF Validator: Diff ( 2 files changed, 7 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2075
Passed tests 1841
Skipped tests: 226
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccVertexAiModel_BasicModel|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDataSourceGoogleServiceAccountAccessToken_basic[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccVertexAiMetadataSchema_BasicHandWritten[view]
TestAccVertexAiModel_BasicModel[view]
TestAccVertexAiModelDeployment_BasicModelDeployment[view]
TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 54 files changed, 4601 insertions(+), 85 deletions(-))
Terraform Beta: Diff ( 56 files changed, 4751 insertions(+), 97 deletions(-))
TF Validator: Diff ( 2 files changed, 7 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2075
Passed tests 1842
Skipped tests: 226
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccVertexAiModelDeployment_BasicModelDeployment|TestAccVertexAiModel_BasicModel|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Tests failed during RECORDING mode:
TestAccVertexAiMetadataSchema_BasicHandWritten[view]
TestAccVertexAiModel_BasicModel[view]
TestAccVertexAiModelDeployment_BasicModelDeployment[view]
TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 54 files changed, 4601 insertions(+), 85 deletions(-))
Terraform Beta: Diff ( 56 files changed, 4751 insertions(+), 97 deletions(-))
TF Validator: Diff ( 2 files changed, 7 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2078
Passed tests 1846
Skipped tests: 226
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit|TestAccVertexAiMetadataSchema_BasicHandWritten|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccVertexAiModel_BasicModel|TestAccVertexAiModelDeployment_BasicModelDeployment

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccVertexAiMetadataSchema_BasicHandWritten[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]

Tests failed during RECORDING mode:
TestAccVertexAiModelDeployment_BasicModelDeployment[view]
TestAccVertexAiModel_BasicModel[view]
TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[view]
TestAccVertexAiEndpointTrafficSplit_BasicEndpointTrafficSplit[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@trodge trodge marked this pull request as ready for review July 16, 2022 02:17
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 51 files changed, 4584 insertions(+), 102 deletions(-))
Terraform Beta: Diff ( 53 files changed, 4623 insertions(+), 110 deletions(-))
TF Validator: Diff ( 2 files changed, 5 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2114
Passed tests 1883
Skipped tests: 226
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlUser_mysqlDisabled

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccSqlUser_mysqlDisabled[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be split into a few different PRs? Namely, a PR per resource, and a separate one for the ID function change (unless there's a strong requirement for making that change that it's paired with a resource, which is sometimes the case).

Multi-resource reviews are hard to keep track of as a reviewer, and can have extremely long review cycles as they take enough time to go through that review iterations happen once a day or less. If it's necessary we hold all the resources and release them at once we can use a branch, similar to use a diffbase internally. The litmus test I use personally is that each PR should so one thing- "add X resource", "add y feature", or "change z assumption/rule".

@melinath
Copy link
Member

Closing this PR - seems like it's no longer relevant.

@melinath melinath closed this Nov 16, 2022
@trodge trodge deleted the vertex-model-deployment branch August 21, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants