-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for evaluationMissingData in AlertPolicy #6295
Add support for evaluationMissingData in AlertPolicy #6295
Conversation
@@ -25,6 +25,13 @@ overrides: !ruby/object:Overrides::ResourceOverrides | |||
primary_resource_id: "alert_policy" | |||
vars: | |||
alert_policy_display_name: "My Alert Policy" | |||
- !ruby/object:Provider::Terraform::Examples | |||
# skipping tests because the API is full of race conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copy-pasted these lines from the example above.
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccSqlUser_mysqlDisabled |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Resolves hashicorp/terraform-provider-google#11161, resolves hashicorp/terraform-provider-google#11227.
This PR adds a support for EvaluationMissingData.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
NOTE: I saw a weird diff after running
make terraform
:This seems to be irrelevant to my change, so I ignored this change and reverted this file before running
make testacc
.