Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for evaluationMissingData in AlertPolicy #6295

Merged

Conversation

genkami
Copy link
Contributor

@genkami genkami commented Jul 19, 2022

Resolves hashicorp/terraform-provider-google#11161, resolves hashicorp/terraform-provider-google#11227.

This PR adds a support for EvaluationMissingData.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

monitoring: added `evaluation_missing_data` field to `google_monitoring_alert_policy`

NOTE: I saw a weird diff after running make terraform:

$ git diff
diff --git a/google-beta/resource_compute_subnetwork.go b/google-beta/resource_compute_subnetwork.go
index 59dd5e28c..8a620b94f 100644
--- a/google-beta/resource_compute_subnetwork.go
+++ b/google-beta/resource_compute_subnetwork.go
@@ -22,7 +22,6 @@ import (
        "reflect"
        "time"

-       "github.com/apparentlymart/go-cidr/cidr"
        "github.com/hashicorp/terraform-plugin-sdk/v2/helper/customdiff"
        "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )

This seems to be irrelevant to my change, so I ignored this change and reverted this file before running make testacc.

@@ -25,6 +25,13 @@ overrides: !ruby/object:Overrides::ResourceOverrides
primary_resource_id: "alert_policy"
vars:
alert_policy_display_name: "My Alert Policy"
- !ruby/object:Provider::Terraform::Examples
# skipping tests because the API is full of race conditions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy-pasted these lines from the example above.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 90 insertions(+))
Terraform Beta: Diff ( 2 files changed, 90 insertions(+))
TF Validator: Diff ( 3 files changed, 25 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2109
Passed tests 1878
Skipped tests: 226
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccSqlUser_mysqlDisabled

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccSqlUser_mysqlDisabled[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@shuyama1 shuyama1 requested review from a team and slevenick and removed request for a team July 19, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants