promote cfn2 to ga

[DrFaust92]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudfunction2: promote to `google_cloudfunctions2_function` ga

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 3078 insertions(+), 45 deletions(-))
Terraform Beta: Diff ( 4 files changed, 38 insertions(+), 125 deletions(-))
TF Validator: Diff ( 7 files changed, 1015 insertions(+), 3 deletions(-))
TF Cloud Doc Samples: Diff ( 4 files changed, 34 deletions(-))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

[modular-magician]

Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

[modular-magician]

Tests analytics

Total tests: 2128
Passed tests 1892
Skipped tests: 227
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccFirebaserulesRelease_BasicRelease|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[DrFaust92]

c2thorn gentle reminder 😊

[DrFaust92]

test-test was weird

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 3095 insertions(+), 56 deletions(-))
Terraform Beta: Diff ( 4 files changed, 87 insertions(+), 170 deletions(-))
TF Validator: Diff ( 7 files changed, 1016 insertions(+), 3 deletions(-))
TF Cloud Doc Samples: Diff ( 4 files changed, 5 insertions(+), 39 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2130
Passed tests 1888
Skipped tests: 227
Failed tests: 15

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudfunctions2function_cloudfunctions2FullExample|TestAccCloudfunctions2function_cloudfunctions2BasicExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2functionIamBindingGenerated|TestAccCloudfunctions2functionIamPolicyGenerated|TestAccCloudfunctions2functionIamMemberGenerated

[modular-magician]

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccCloudfunctions2function_cloudfunctions2FullExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]
TestAccCloudfunctions2functionIamBindingGenerated[view]
TestAccCloudfunctions2functionIamPolicyGenerated[view]
TestAccCloudfunctions2functionIamMemberGenerated[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[c2thorn]

Let me run the suit of CF2 tests in GA, our VCR tests only run beta

[c2thorn]

looks good so far, waiting on test results.

[averikitsch]

@c2thorn Accepting this PR broke our tutorials. Can you revert?

[c2thorn]

@averikitsch reverting would completely remove the resource from the GA provider which is a large breaking change. We can discuss offline about the impact?

[iennae]

@c2thorn why was the sample changed though? The provider and validator I can understand, but why was the sample modified?

[c2thorn]

@iennae The idea was to update all examples/tests to GA to prove it works correctly for both. I think while doing that, the contributor updated some names within the sample to conform with other tests within our provider.

It was my mistake in not understanding/verifying the effect changing the samples could have outside of the provider. I can revert the change for the samples specifically. Since we haven't fully switched away from MM for CGC samples, I'll make the change now

[bharathkkb]

@c2thorn @iennae @averikitsch I fixed this in https://github.com/terraform-google-modules/terraform-docs-samples/blob/switch-ci/cloudfunctions2_full/main.tf. Should we turn off MM and merge terraform-google-modules/terraform-docs-samples#143?

[c2thorn]

Thanks @bharathkkb, yes we can go with the approach. I'll turn off CGC sample generation in MM ASAP. Let's move further discussion off of this pull request, as it no longer seems related.