Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Datastream service & for ConnectionProfile resource #6479
Added support for Datastream service & for ConnectionProfile resource #6479
Changes from 3 commits
5685a85
59ae10b
d5b0dbf
d74bf48
5266ca2
d7cdfd3
b5a58a6
065f680
1163d50
b90ea5e
0c0883b
799ad33
8ace307
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to prefer renaming connection_profile_id -> name and omitting the output-only name variable because it should be identical to the resource's
id
field, but there is precedence for both ways so I won't block on thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the absence of a right way - I'd rather leave it called connection_profile_id because that matches the API field. would it make sense to just remove support for the
name
field since it duplicatesid
?