Promote Vertex AI FeatureStore resources (GA only) #6565

shotarok · 2022-09-18T03:33:18Z

part of hashicorp/terraform-provider-google#9298

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_vertex_ai_featurestore` (ga only)
`google_vertex_ai_featurestore_entitytype` (ga only)
`google_vertex_ai_featurestore_entitytype_feature` (ga only)

modular-magician · 2022-09-18T03:34:14Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-09-18T03:45:10Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 1264 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 4 files changed, 4 insertions(+), 14 deletions(-))
TF Validator: Diff ( 4 files changed, 260 insertions(+), 3 deletions(-))

modular-magician · 2022-09-18T04:55:57Z

Tests analytics

Total tests: 2174
Passed tests 1934
Skipped tests: 238
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician · 2022-09-18T05:01:10Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shotarok · 2022-09-18T05:12:48Z

It looks like the two tests also fail in the other PRs regardless of the PR contents. BTW, I can't see the build log or the debug log either due to the permission errors. Is this an expected behavior?

[UPDATED] I found the following note on README.md. I understand that community developers don't need permission too see the logs.

The false positive rate on these tests is extremely high between changes in the API, Cloud Build bugs, and eventual consistency issues in test recordings so we don't expect contributors to wholly interpret the results- that's the responsibility of your reviewer.

shotarok · 2022-09-26T07:49:08Z

Hi @slevenick, could you please review this PR?

slevenick · 2022-09-27T19:28:21Z

Hmmm, it looks like some fields may not be supported in GA at the API level (or were renamed, removed or something else)

This test fails:
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample

Can you see what is going on with that test? I see this failure message:

"description": "Invalid JSON payload received. Unknown name \"monitoringInterval\" at 'entity_type.monitoring_config.snapshot_analysis': Cannot find field.",

shotarok · 2022-09-27T21:32:25Z

@slevenick Thank you for your comment! I found out the following things:

monitoringInterval is deprecated in v1beta1 like below
stalenessDays and monitoringIntervalDays are supported in both v1 and v1beta1

I'll remove monitoringInterval in this PR and keep this PR only for GA. Apart from that, I'll create another PR to support the new fields. Please let me know if you'd recommend containing both changes in this PR. Thanks!

shotarok · 2022-09-27T21:39:22Z

As for the error messages, I'm afraid I couldn't find the visible link to my account. Could you please give me the link to see the error? The following links returned permission errors to me.

View the build log or the debug log for each test

modular-magician · 2022-09-27T22:05:58Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 1239 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 5 files changed, 4 insertions(+), 45 deletions(-))
TF Validator: Diff ( 4 files changed, 249 insertions(+), 3 deletions(-))

slevenick · 2022-09-27T22:14:46Z

Yikes, so this is going to be a bit of a tricky situation. We have pretty strict guidelines around backwards compatibility, where we cannot remove a field until a major version change. That means that we can't remove the field from the beta provider, but we also can't have it present in the GA provider. Maybe we can mark that field as min_version: beta to prevent it from being in the GA provider, and then deprecate it so we can remove it in the next major version

shotarok · 2022-09-27T22:46:33Z

Maybe we can mark that field as min_version: beta to prevent it from being in the GA provider, and then deprecate it so we can remove it in the next major version

Thank you for sharing the release policy. This approach looks good to me. I'll update the PR, and get back to you!

modular-magician · 2022-09-27T22:57:50Z

Tests analytics

Total tests: 2182
Passed tests 1942
Skipped tests: 238
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician · 2022-09-27T22:59:46Z

Tests failed during RECORDING mode:
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

This reverts commit 89d6672.

modular-magician · 2022-09-28T22:20:12Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 1241 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 5 files changed, 9 insertions(+), 18 deletions(-))
TF Validator: Diff ( 4 files changed, 249 insertions(+), 3 deletions(-))

modular-magician · 2022-09-28T23:20:32Z

Tests analytics

Total tests: 2192
Passed tests 1938
Skipped tests: 240
Failed tests: 14

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_networkTier|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccComputeRouterInterface_basic|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade|TestAccComputeFirewallPolicyRule_update|TestAccComputeFirewallPolicy_update

shotarok · 2022-09-28T23:36:49Z

Hello @slevenick, I removed monitoring_interval from the example, but it seems TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample still is failing. Could you help me what the error message is? I'll also try to reproduce the error locally. Thanks

modular-magician · 2022-09-28T23:57:36Z

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeForwardingRule_networkTier[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]
TestAccComputeRouterInterface_basic[Debug log]
TestAccComputeVpnTunnel_vpnTunnelBetaExample[Debug log]
TestAccSqlDatabaseInstance_mysqlMajorVersionUpgrade[Debug log]
TestAccComputeFirewallPolicyRule_update[Debug log]
TestAccComputeFirewallPolicy_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

slevenick

Error is:

    provider_test.go:315: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # google_vertex_ai_featurestore_entitytype.entity will be updated in-place
          ~ resource "google_vertex_ai_featurestore_entitytype" "entity" {
                id           = "projects/ci-test-project-188019/locations/us-central1/featurestores/terraformxhbvcoal6r/entityTypes/terraformxhbvcoal6r"
                name         = "terraformxhbvcoal6r"
                # (4 unchanged attributes hidden)
        
              + monitoring_config {
                  + snapshot_analysis {
                      + disabled = false
                    }
                }
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample (67.11s)

Looks like if monitoring_interval isn't specified we get an empty block back. Can you specify the other field in that test?

shotarok · 2022-09-30T00:44:05Z

Thank you for letting me know about the error!

The stalenessDays and monitoringIntervalDays are the other fields, but they're new fields for the provider. The PR becomes not only GA. So I'd try to use monitoring_config.snapshot_analysis.disabled = true.

Apart from that, I added google_vertex_ai_featurestore_entitytype_feature to the beta provider in #6568. It's also a GA-ready feature store resource. So I'll make it promoted in this PR.

…estore-resources

slevenick · 2022-09-30T17:32:02Z

Still seeing:

              ~ monitoring_config {
                  ~ snapshot_analysis {
                      - monitoring_interval = "0s" -> null
                        # (1 unchanged attribute hidden)
                    }
                }
            }

Are you able to run these tests yourself?

shotarok · 2022-09-30T22:28:38Z

Thank you for your comment. I tried reproducing the error with the auto-generated branch on my local machine like below, but the test passed on my machine. So I might have overlooked something. I attached test.log.

➜  terraform-provider-google git:(auto-pr-6565)  git show HEAD  | head -n 1
commit b769b21056499b22faf81f5f0bf14a1d74b20042

➜  terraform-provider-google git:(auto-pr-6565)  TF_LOG=TRACE make testacc GOOGLE_ORG=test GOOGLE_BILLING_ACCOUNT=test GOOGLE_USE_DEFAULT_CREDENTIALS=true GCLOUD_PROJECT=kouzoh-p-kohama GCLOUD_REGION=us-central1 GCLOUD_ZONE=us-central1-a TEST=./google TESTARGS='-run=TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample' | tee test.log
go generate  ./...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample
=== PAUSE TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample
=== CONT  TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample
...
--- PASS: TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample (96.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-google/google	(cached)

slevenick · 2022-09-30T22:31:51Z

Thank you for your comment. I tried reproducing the error with the auto-generated branch on my local machine like below, but the test passed on my machine. So I might have overlooked something. I attached test.log.

➜  terraform-provider-google git:(auto-pr-6565)  git show HEAD  | head -n 1
commit b769b21056499b22faf81f5f0bf14a1d74b20042

➜  terraform-provider-google git:(auto-pr-6565)  TF_LOG=TRACE make testacc GOOGLE_ORG=test GOOGLE_BILLING_ACCOUNT=test GOOGLE_USE_DEFAULT_CREDENTIALS=true GCLOUD_PROJECT=kouzoh-p-kohama GCLOUD_REGION=us-central1 GCLOUD_ZONE=us-central1-a TEST=./google TESTARGS='-run=TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample' | tee test.log
go generate  ./...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -v -run=TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample
=== PAUSE TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample
=== CONT  TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample
...
--- PASS: TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample (96.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-google/google	(cached)

It's failing on the beta provider specifically, so maybe it's a beta vs GA difference?

shotarok · 2022-09-30T23:52:48Z

It's failing on the beta provider specifically, so maybe it's a beta vs GA difference?

Ah, I could reproduce the error with the beta provider locally. I'll look into it. Thanks!

modular-magician · 2022-10-01T13:56:45Z

Hi there, I'm the Modular magician - !

modular-magician · 2022-10-01T14:45:58Z

Tests analytics

Total tests: 2197
Passed tests 1950
Skipped tests: 240
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccFirebaserulesRelease_BasicRelease|TestAccBillingSubaccount_renameOnDestroy|TestAccBillingSubaccount_basic|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccVertexAIFeaturestoreEntitytypeFeature_vertexAiFeaturestoreEntitytypeFeatureExample

modular-magician · 2022-10-01T14:51:12Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccBillingSubaccount_renameOnDestroy[Debug log]
TestAccBillingSubaccount_basic[Debug log]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[Debug log]
TestAccVertexAIFeaturestoreEntitytypeFeature_vertexAiFeaturestoreEntitytypeFeatureExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shotarok · 2022-10-01T21:19:35Z

Hi @slevenick I added the default value of the monitoring_interval and I confirmed the tests passed. Could you review the change when you have time? Thanks!

slevenick · 2022-10-05T18:30:06Z

mmv1/products/vertexai/api.yaml

@@ -273,7 +271,11 @@ objects:
                  The monitoring schedule for snapshot analysis. For EntityType-level config: unset / disabled = true indicates disabled by default for Features under it; otherwise by default enable snapshot analysis monitoring with monitoringInterval for Features under it.
              - !ruby/object:Api::Type::String
                name: 'monitoringInterval'
+                default_value: "0s"


We can't add a default value in a minor version of the provider. It's technically considered a breaking change even if it was the implicit default value before

@slevenick Got it! I'll revert the change. BTW, could you give me an example to test a beta field? I'd like to test monitoring_interval only in the google-beta.

For example, can we define an additional google_vertex_ai_featurestore_entitytype only in the test of the google-beta provider?

resource "google_vertex_ai_featurestore_entitytype" "entity" { name = "<%= ctx[:vars]['name'] %>" labels = { foo = "bar" } featurestore = google_vertex_ai_featurestore.featurestore.id monitoring_config { snapshot_analysis { disabled = true } } } <%- if is_beta %> resource "google_vertex_ai_featurestore_entitytype" "entity_for_beta" { provider = google-beta name = "<%= ctx[:vars]['name'] + '_for_beta' %>" labels = { foo = "bar" } featurestore = google_vertex_ai_featurestore.featurestore.id monitoring_config { snapshot_analysis { disabled = false monitoring_interval = "86400s" } } } <%- end %>

Yes, you can find examples of the version tag needed to make some code only exist in the beta provider. I think its something like <%- unless version == "ga" %>

@slevenick it turns out there is no version information in the bindings to render the example. I'm wondering if there is another way to test a beta field. Or should I pass the version to render the example?

magic-modules/mmv1/provider/terraform/examples.rb

Lines 259 to 267 in 3132afe

body = lines(compile_file(

{

vars: rand_vars.merge(overrides),

test_env_vars: test_env_vars.map { |k, _| [k, "%{#{k}}"] }.to_h,

primary_resource_id: primary_resource_id,

primary_resource_type: primary_resource_type

},

pwd + '/' + config_path

))

I understood we could define multiple examples for a resource, and we can define min_version of an example object. I'll add two example erb files.

I could define an example only for the beta provider by min_version of an example object. However, I couldn't define an example only for the ga provider only with the min_version.

magic-modules/mmv1/templates/terraform/examples/base_configs/test_file.go.erb

Lines 29 to 32 in 13f6fa6

object.examples

.reject(&:skip_test)

.reject { |e| @api.version_obj_or_closest(version) < @api.version_obj_or_closest(e.min_version) }

.each do |example|

I created two examples. One is without monitoring_interval, which works for both ga and beta. Another example is with monitoring_interval, which only works for beta.

mmv1/products/vertexai/api.yaml

This reverts commit d3b5090.

modular-magician · 2022-10-12T17:36:26Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 1846 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 7 files changed, 202 insertions(+), 30 deletions(-))
TF Validator: Diff ( 5 files changed, 339 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 267 insertions(+))

modular-magician · 2022-10-12T18:14:50Z

Tests analytics

Total tests: 2194
Passed tests 1949
Skipped tests: 239
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccVertexAIFeaturestoreEntitytypeFeature_vertexAiFeaturestoreEntitytypeFeatureWithBetaFieldsExample|TestAccVertexAIFeaturestoreEntitytypeFeature_vertexAiFeaturestoreEntitytypeFeatureExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample|TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeWithBetaFieldsExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeInstance_soleTenantNodeAffinities

modular-magician · 2022-10-12T18:20:11Z

Tests passed during RECORDING mode:
TestAccVertexAIFeaturestoreEntitytypeFeature_vertexAiFeaturestoreEntitytypeFeatureWithBetaFieldsExample[Debug log]
TestAccVertexAIFeaturestoreEntitytypeFeature_vertexAiFeaturestoreEntitytypeFeatureExample[Debug log]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeExample[Debug log]
TestAccVertexAIFeaturestoreEntitytype_vertexAiFeaturestoreEntitytypeWithBetaFieldsExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shotarok · 2022-10-12T18:24:11Z

@slevenick OK, the added tests passed in the recording mode. Could you please review this PR again when you have time? Thanks

slevenick

Great thanks! Good call on adding a separate test for the beta-only field

feat: promote vertex ai feature store resources (ga only)

626404e

modular-magician requested a review from slevenick September 18, 2022 03:34

shotarok mentioned this pull request Sep 18, 2022

feat: make it possible to deifine a feature in Vertex AI FeatureStore #6568

Merged

5 tasks

feat: deprecate the field: monitoring_interval

89d6672

shotarok added 2 commits September 28, 2022 21:25

Revert "feat: deprecate the field: monitoring_interval"

3e76e59

This reverts commit 89d6672.

feat: update the example to use only the GA fields

b600ab9

This was referenced Sep 29, 2022

feat: make it possible to deifine a feature in Vertex AI FeatureStore hashicorp/terraform-provider-google-beta#4736

Merged

feat: make it possible to deifine a feature in Vertex AI FeatureStore hashicorp/terraform-provider-google#12684

Merged

slevenick reviewed Sep 30, 2022

View reviewed changes

shotarok added 2 commits September 30, 2022 09:49

Merge remote-tracking branch 'gcp/main' into promote-vertex-ai-featur…

a540bf2

…estore-resources

fix: diable monitoring_config.snapshot_analysis in the example

c37fbcd

shotarok added 2 commits October 1, 2022 22:44

fix: add default_value to fix the unintentional diff

d3b5090

feat: update the link to the api doc

2b0982d

slevenick reviewed Oct 5, 2022

View reviewed changes

shotarok added 3 commits October 8, 2022 13:32

Revert "fix: add default_value to fix the unintentional diff"

acc9fb1

This reverts commit d3b5090.

refactor: use deprecation_message to clarify the deprecated field

c87fbf6

feat: add a new example to test beta fields

9662dd4

modular-magician requested a review from slevenick October 12, 2022 17:22

fix: use a different resource name to run tests in parallel

6d8c548

slevenick approved these changes Oct 14, 2022

View reviewed changes

slevenick merged commit 679dd04 into GoogleCloudPlatform:main Oct 14, 2022

shotarok deleted the promote-vertex-ai-featurestore-resources branch October 16, 2022 14:25

	body = lines(compile_file(
	{
	vars: rand_vars.merge(overrides),
	test_env_vars: test_env_vars.map { \|k, _\| [k, "%{#{k}}"] }.to_h,
	primary_resource_id: primary_resource_id,
	primary_resource_type: primary_resource_type
	},
	pwd + '/' + config_path
	))

	object.examples
	.reject(&:skip_test)
	.reject { \|e\| @api.version_obj_or_closest(version) < @api.version_obj_or_closest(e.min_version) }
	.each do \|example\|

Promote Vertex AI FeatureStore resources (GA only) #6565

Promote Vertex AI FeatureStore resources (GA only) #6565

Conversation

shotarok commented Sep 18, 2022 • edited Loading

modular-magician commented Sep 18, 2022

modular-magician commented Sep 18, 2022

Diff report:

modular-magician commented Sep 18, 2022

Tests analytics

Action taken

modular-magician commented Sep 18, 2022

shotarok commented Sep 18, 2022 • edited Loading

shotarok commented Sep 26, 2022

slevenick commented Sep 27, 2022

shotarok commented Sep 27, 2022 • edited Loading

shotarok commented Sep 27, 2022

modular-magician commented Sep 27, 2022

Diff report:

slevenick commented Sep 27, 2022

shotarok commented Sep 27, 2022

modular-magician commented Sep 27, 2022

Tests analytics

Action taken

modular-magician commented Sep 27, 2022

modular-magician commented Sep 28, 2022

Diff report:

modular-magician commented Sep 28, 2022

Tests analytics

Action taken

shotarok commented Sep 28, 2022 • edited Loading

modular-magician commented Sep 28, 2022

slevenick left a comment

Choose a reason for hiding this comment

shotarok commented Sep 30, 2022

slevenick commented Sep 30, 2022

shotarok commented Sep 30, 2022

slevenick commented Sep 30, 2022

shotarok commented Sep 30, 2022

modular-magician commented Oct 1, 2022

modular-magician commented Oct 1, 2022

Tests analytics

Action taken

modular-magician commented Oct 1, 2022

shotarok commented Oct 1, 2022

slevenick Oct 5, 2022

Choose a reason for hiding this comment

shotarok Oct 8, 2022

Choose a reason for hiding this comment

shotarok Oct 8, 2022

Choose a reason for hiding this comment

slevenick Oct 10, 2022

Choose a reason for hiding this comment

shotarok Oct 12, 2022

Choose a reason for hiding this comment

shotarok Oct 12, 2022 • edited Loading

Choose a reason for hiding this comment

shotarok Oct 12, 2022 • edited Loading

Choose a reason for hiding this comment

shotarok Oct 12, 2022 • edited Loading

Choose a reason for hiding this comment

modular-magician commented Oct 12, 2022

Diff report:

modular-magician commented Oct 12, 2022

Tests analytics

Action taken

modular-magician commented Oct 12, 2022

shotarok commented Oct 12, 2022

slevenick left a comment

Choose a reason for hiding this comment

shotarok commented Sep 18, 2022 •

edited

Loading

shotarok commented Sep 18, 2022 •

edited

Loading

shotarok commented Sep 27, 2022 •

edited

Loading

shotarok commented Sep 28, 2022 •

edited

Loading

shotarok Oct 12, 2022 •

edited

Loading

shotarok Oct 12, 2022 •

edited

Loading

shotarok Oct 12, 2022 •

edited

Loading