Add the vertex endpoint resource. #6661

trodge · 2022-10-06T17:16:06Z

Add the google_vertex_ai_endpoint resource.

part of hashicorp/terraform-provider-google#9298

Differs from #6583 in that endpoint location is now required and other vertex resources are left unchanged.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_vertex_ai_endpoint

modular-magician · 2022-10-06T17:17:03Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-10-06T17:27:33Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 1520 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1520 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-06T18:03:10Z

Tests analytics

Total tests: 2207
Passed tests 1965
Skipped tests: 240
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-10-06T18:08:18Z

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-06T20:14:35Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1512 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1512 insertions(+), 18 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-06T20:15:40Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2022-10-06T20:43:22Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1512 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1512 insertions(+), 26 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-06T20:44:24Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2022-10-06T21:17:03Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1514 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 10 files changed, 1514 insertions(+), 26 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-06T21:17:57Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2022-10-06T22:39:19Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1512 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1512 insertions(+), 28 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-06T22:40:18Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2022-10-06T22:57:00Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1512 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1512 insertions(+), 46 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-06T23:41:30Z

Tests analytics

Total tests: 2207
Passed tests 1963
Skipped tests: 240
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_update|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-10-06T23:46:54Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-14T18:40:59Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1562 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1562 insertions(+), 46 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-14T19:25:24Z

Tests analytics

Total tests: 2187
Passed tests 1947
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccVertexAIEndpoint_vertexAiEndpointNetwork

modular-magician · 2022-10-14T19:26:11Z

Tests failed during RECORDING mode:
TestAccVertexAIEndpoint_vertexAiEndpointNetwork[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

trodge · 2022-10-14T20:11:34Z

/gcbrun

modular-magician · 2022-10-14T20:25:07Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1562 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1562 insertions(+), 46 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-14T21:01:47Z

Tests analytics

Total tests: 2187
Passed tests 1946
Skipped tests: 239
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccVertexAIEndpoint_vertexAiEndpointNetwork

modular-magician · 2022-10-14T21:02:36Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccVertexAIEndpoint_vertexAiEndpointNetwork[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

trodge · 2022-10-17T16:30:07Z

/gcbrun

modular-magician · 2022-10-17T16:43:39Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 1562 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1562 insertions(+), 46 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-17T17:31:31Z

Tests analytics

Total tests: 2192
Passed tests 1951
Skipped tests: 239
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccVertexAIEndpoint_vertexAiEndpointNetwork

modular-magician · 2022-10-17T17:32:20Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccVertexAIEndpoint_vertexAiEndpointNetwork[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-19T18:19:56Z

Tests failed during RECORDING mode:
TestAccVertexAIEndpoint_vertexAiEndpointNetwork[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

slevenick · 2022-10-19T22:03:39Z

mmv1/products/vertexai/api.yaml

@@ -37,6 +37,9 @@ objects:
          'https://cloud.google.com/vertex-ai/docs'
      api: 'https://cloud.google.com/vertex-ai/docs/reference/rest/v1/projects.locations.datasets'
    async: !ruby/object:Api::OpAsync
+      actions:


Looks like this fixes another bug that exists in dataset. hashicorp/terraform-provider-google#12799

slevenick

I have concerns around not sending the endpointId during create, but other than that it seems fine

slevenick · 2022-10-19T22:05:16Z

mmv1/products/vertexai/api.yaml

+  - !ruby/object:Api::Resource
+    name: Endpoint
+    base_url: projects/{{project}}/locations/{{location}}/endpoints
+    create_url: projects/{{project}}/locations/{{location}}/endpoints


Do we not send the endpointId during create? As specified on https://cloud.google.com/vertex-ai/docs/reference/rest/v1beta1/projects.locations.endpoints/create

slevenick · 2022-10-19T22:08:09Z

Can we either fix the networking issue before merging this or disable the test in VCR? I don't want to add a test that will fail on every PR commit

modular-magician · 2022-10-20T22:21:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 1589 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1589 insertions(+), 46 deletions(-))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))

slevenick · 2022-10-20T22:40:01Z

mmv1/third_party/terraform/tests/resource_vertex_ai_endpoint_test.go

@@ -27,6 +27,7 @@ func TestAccVertexAIEndpoint_vertexAiEndpointNetwork(t *testing.T) {
 	t.Parallel()

 	context := map[string]interface{}{
+		"endpoint_name": fmt.Sprint(randInt(t) % 9999999999),


Is endpoint_name strictly an integer? We try to prefix all names with tf-test- so that sweepers can clean them up if they get left around accidentally

Yes, endpoint name must be numeric and at most 10 digits.

mmv1/products/vertexai/api.yaml

modular-magician · 2022-10-20T23:07:13Z

Tests analytics

Total tests: 2201
Passed tests 1961
Skipped tests: 240
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

modular-magician · 2022-10-20T23:56:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 1556 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1556 insertions(+), 46 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-21T00:41:19Z

Tests analytics

Total tests: 2201
Passed tests 1961
Skipped tests: 240
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

mmv1/products/vertexai/api.yaml

slevenick · 2022-10-21T17:47:02Z

mmv1/third_party/terraform/tests/resource_vertex_ai_endpoint_test.go

+)
+
+func TestAccVertexAIEndpoint_vertexAiEndpointNetwork(t *testing.T) {
+	t.Skip("Skip this test until b/254073292 is resolved")


If we write a test without a network will it pass even with the quota issues? I'd prefer having some test rather than none even if it doesn't cover the network functionality

It looks like the bug has been resolved, so I've removed the skip.

… and describe format of name field.

modular-magician · 2022-10-21T20:23:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 1554 insertions(+), 46 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1554 insertions(+), 46 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-21T21:03:36Z

Tests analytics

Total tests: 2203
Passed tests 1963
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccVertexAIEndpoint_vertexAiEndpointNetwork

modular-magician · 2022-10-21T21:06:11Z

Tests passed during RECORDING mode:
TestAccVertexAIEndpoint_vertexAiEndpointNetwork[Debug log]

All tests passed
View the build log or the debug log for each test

modular-magician requested a review from slevenick October 6, 2022 17:17

trodge force-pushed the vertex-endpoint-mmv1 branch from cd441cd to 7a28b40 Compare October 6, 2022 20:31

trodge force-pushed the vertex-endpoint-mmv1 branch from ae429d3 to de33385 Compare October 6, 2022 22:26

trodge force-pushed the vertex-endpoint-mmv1 branch from 5240f39 to 5d9c037 Compare October 14, 2022 18:28

slevenick reviewed Oct 19, 2022

View reviewed changes

slevenick requested changes Oct 19, 2022

View reviewed changes

Make endpoint name user-specified.

a07c33f

modular-magician requested a review from slevenick October 20, 2022 22:03

Skip the vertex endpoint test.

03000b1

slevenick reviewed Oct 20, 2022

View reviewed changes

Make vertex endpoint name field required, url param only, and immutable.

541d262

modular-magician requested a review from slevenick October 20, 2022 23:41

slevenick reviewed Oct 21, 2022

View reviewed changes

Unskip test, add link to cloud console to deployedModels description,…

205c1a3

… and describe format of name field.

modular-magician requested a review from slevenick October 21, 2022 20:08

slevenick approved these changes Oct 21, 2022

View reviewed changes

trodge merged commit 057fa7f into GoogleCloudPlatform:main Oct 21, 2022

This was referenced Oct 21, 2022

Add the vertex endpoint resource. hashicorp/terraform-provider-google-beta#4815

Merged

Add the vertex endpoint resource. hashicorp/terraform-provider-google#12858

Merged

Add the vertex endpoint resource. GoogleCloudPlatform/terraform-validator#1073

Merged

trodge deleted the vertex-endpoint-mmv1 branch October 24, 2022 17:32

slevenick mentioned this pull request Oct 31, 2022

Dataset : updating a label throws an error after timeout hashicorp/terraform-provider-google#12799

Closed

edwardmedia mentioned this pull request Oct 31, 2022

update patch process #6721

Closed

5 tasks

shotarok mentioned this pull request Nov 11, 2022

feat(vertexai): add google_vertex_ai_index for Vertex AI Matching Engine #6728

Merged

5 tasks

alwhelan22 mentioned this pull request Jul 26, 2023

Add vertex model deployment resource hashicorp/terraform-provider-google#15303

Open

Add the vertex endpoint resource. #6661

Add the vertex endpoint resource. #6661

Conversation

trodge commented Oct 6, 2022

modular-magician commented Oct 6, 2022

modular-magician commented Oct 6, 2022

Diff report:

modular-magician commented Oct 6, 2022

Tests analytics

Action taken

modular-magician commented Oct 6, 2022

modular-magician commented Oct 6, 2022

Diff report:

modular-magician commented Oct 6, 2022

Tests analytics

modular-magician commented Oct 6, 2022

Diff report:

modular-magician commented Oct 6, 2022

Tests analytics

modular-magician commented Oct 6, 2022

Diff report:

modular-magician commented Oct 6, 2022

Tests analytics

modular-magician commented Oct 6, 2022

Diff report:

modular-magician commented Oct 6, 2022

Tests analytics

modular-magician commented Oct 6, 2022

Diff report:

modular-magician commented Oct 6, 2022

Tests analytics

Action taken

modular-magician commented Oct 6, 2022

modular-magician commented Oct 14, 2022

Diff report:

modular-magician commented Oct 14, 2022

Tests analytics

Action taken

modular-magician commented Oct 14, 2022

trodge commented Oct 14, 2022

modular-magician commented Oct 14, 2022

Diff report:

modular-magician commented Oct 14, 2022

Tests analytics

Action taken

modular-magician commented Oct 14, 2022

trodge commented Oct 17, 2022

modular-magician commented Oct 17, 2022

Diff report:

modular-magician commented Oct 17, 2022

Tests analytics

Action taken

modular-magician commented Oct 17, 2022

modular-magician commented Oct 19, 2022

slevenick Oct 19, 2022

Choose a reason for hiding this comment

slevenick left a comment

Choose a reason for hiding this comment

slevenick Oct 19, 2022

Choose a reason for hiding this comment

slevenick commented Oct 19, 2022

modular-magician commented Oct 20, 2022

Diff report

slevenick Oct 20, 2022

Choose a reason for hiding this comment

trodge Oct 20, 2022

Choose a reason for hiding this comment

modular-magician commented Oct 20, 2022

Tests analytics

modular-magician commented Oct 20, 2022

Diff report

modular-magician commented Oct 21, 2022

Tests analytics

slevenick Oct 21, 2022

Choose a reason for hiding this comment

trodge Oct 21, 2022

Choose a reason for hiding this comment

modular-magician commented Oct 21, 2022

Diff report

modular-magician commented Oct 21, 2022