Add new resource WorkforcePool #6719

bohengy · 2022-10-19T18:47:29Z

Add new resource WorkforcePool.

API: https://cloud.google.com/iam/docs/reference/rest/v1/locations.workforcePools

Issue: hashicorp/terraform-provider-google#12836

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_iam_workforce_pool`

modular-magician · 2022-10-19T18:48:23Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-10-19T19:02:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1128 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1128 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 153 insertions(+), 3 deletions(-))

modular-magician · 2022-10-19T19:49:44Z

Tests analytics

Total tests: 2200
Passed tests 1956
Skipped tests: 239
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccIAMWorkforceWorkforcePool_iamWorkforcePoolBasicExample|TestAccIAMWorkforceWorkforcePool_iamWorkforcePoolFullExample|TestAccIAMWorkforceWorkforcePool_minimal|TestAccIAMWorkforceWorkforcePool_full

modular-magician · 2022-10-19T19:50:08Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccIAMWorkforceWorkforcePool_iamWorkforcePoolBasicExample[Error message] [Debug log]
TestAccIAMWorkforceWorkforcePool_iamWorkforcePoolFullExample[Error message] [Debug log]
TestAccIAMWorkforceWorkforcePool_minimal[Error message] [Debug log]
TestAccIAMWorkforceWorkforcePool_full[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

slevenick · 2022-10-19T20:01:47Z

Does this API exist yet? It currently seems to fail with a 404:
Error: Error creating WorkforcePool: googleapi: Error 404: Method not found.

bohengy · 2022-10-19T20:51:00Z

It is because the resource has a visibility label. The user project is necessary in order to access the method, so the X-Goog-User-Project header is needed. I enabled user_project_override locally and all the tests passed.

modular-magician · 2022-10-19T20:59:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1128 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1128 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 153 insertions(+), 3 deletions(-))

slevenick · 2022-10-19T21:17:27Z

It is because the resource has a visibility label. The user project is necessary in order to access the method, so the X-Goog-User-Project header is needed. I enabled user_project_override locally and all the tests passed.

Will the visibility label be removed in the future do you know?

modular-magician · 2022-10-19T21:35:26Z

Tests analytics

Total tests: 2200
Passed tests 1956
Skipped tests: 239
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccIAMWorkforcePoolWorkforcePool_minimal|TestAccIAMWorkforcePoolWorkforcePool_full|TestAccIAMWorkforcePoolWorkforcePool_iamWorkforcePoolFullExample|TestAccIAMWorkforcePoolWorkforcePool_iamWorkforcePoolBasicExample|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-10-19T21:35:50Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePool_minimal[Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePool_full[Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePool_iamWorkforcePoolFullExample[Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePool_iamWorkforcePoolBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

slevenick · 2022-10-19T23:28:09Z

/gcbrun

modular-magician · 2022-10-19T23:43:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 1128 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1128 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 153 insertions(+), 3 deletions(-))

modular-magician · 2022-10-20T15:43:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 151 insertions(+))
Terraform Beta: Diff ( 9 files changed, 1138 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-20T16:20:29Z

Tests analytics

Total tests: 2203
Passed tests 1959
Skipped tests: 239
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccIAMWorkforcePoolWorkforcePool_minimal|TestAccIAMWorkforcePoolWorkforcePool_full|TestAccIAMWorkforcePoolWorkforcePool_iamWorkforcePoolFullExample|TestAccIAMWorkforcePoolWorkforcePool_iamWorkforcePoolBasicExample|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-10-20T16:22:02Z

Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePool_minimal[Debug log]
TestAccIAMWorkforcePoolWorkforcePool_full[Debug log]
TestAccIAMWorkforcePoolWorkforcePool_iamWorkforcePoolFullExample[Debug log]
TestAccIAMWorkforcePoolWorkforcePool_iamWorkforcePoolBasicExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

slevenick · 2022-10-20T16:35:22Z

mmv1/templates/terraform/constants/iam_workforce_pool.go.erb

@@ -0,0 +1,37 @@
+const workforcePoolIdRegexp = `^[0-9a-z-]+$`
+
+func validateWorkforcePoolId(v interface{}, k string) (ws []string, errors []error) {


Do we need this much effort client-side to validate names?

Typically we avoid adding too much validation client-side and let the server validate fields like this, as validation tends to change over time. If the validation changes server-side, clients don't need to change to use it, but if it's client-side and needs to change it causes delays in users being able to use the new validation

I see. I will delete some of the checks. Thank you for pointing this out.

modular-magician · 2022-10-20T17:59:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 151 insertions(+))
Terraform Beta: Diff ( 9 files changed, 1121 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

mmv1/products/iamworkforcepool/api.yaml

modular-magician · 2022-10-20T18:53:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 151 insertions(+))
Terraform Beta: Diff ( 9 files changed, 1112 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-20T19:46:54Z

Tests analytics

Total tests: 2203
Passed tests 1961
Skipped tests: 239
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccIAMWorkforcePoolWorkforcePool_minimal|TestAccIAMWorkforcePoolWorkforcePool_full|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-10-20T19:48:41Z

Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePool_minimal[Debug log]
TestAccIAMWorkforcePoolWorkforcePool_full[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

slevenick · 2022-10-20T23:01:42Z

/gcbrun

slevenick

Couple small notes, but LGTM overall. I'll merge after the little fixes

mmv1/products/iamworkforcepool/api.yaml

mmv1/products/iamworkforcepool/terraform.yaml

mmv1/products/iamworkforcepool/api.yaml

mmv1/templates/terraform/custom_check_destroy/iam_workforce_pool.go.erb

modular-magician · 2022-10-20T23:15:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 151 insertions(+))
Terraform Beta: Diff ( 9 files changed, 1112 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-21T00:10:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 154 insertions(+))
Terraform Beta: Diff ( 9 files changed, 1115 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-10-21T00:57:07Z

Tests analytics

Total tests: 2204
Passed tests 1964
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample

modular-magician · 2022-10-21T01:03:24Z

Tests passed during RECORDING mode:
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]

All tests passed
View the build log or the debug log for each test

bohengy added 2 commits October 19, 2022 08:37

added workforce pool

6376cda

fixed bugs

1f9d7a8

modular-magician requested a review from slevenick October 19, 2022 18:48

renamed the product and fixed an error message

2f60a33

bohengy added 2 commits October 20, 2022 00:29

updated version setting

74f7f0e

changed to provider-beta

7b495fc

slevenick reviewed Oct 20, 2022

View reviewed changes

updated id validator

554baa9

modular-magician requested a review from slevenick October 20, 2022 17:44

slevenick reviewed Oct 20, 2022

View reviewed changes

mmv1/products/iamworkforcepool/api.yaml Show resolved Hide resolved

mmv1/products/iamworkforcepool/api.yaml Show resolved Hide resolved

mmv1/products/iamworkforcepool/api.yaml Show resolved Hide resolved

mmv1/products/iamworkforcepool/api.yaml Show resolved Hide resolved

updated parent field

11b87bf

modular-magician requested a review from slevenick October 20, 2022 18:40

slevenick reviewed Oct 20, 2022

View reviewed changes

fixed bugs

a0ecea4

modular-magician requested a review from slevenick October 20, 2022 23:58

slevenick approved these changes Oct 24, 2022

View reviewed changes

slevenick merged commit 0689d0d into GoogleCloudPlatform:main Oct 24, 2022

This was referenced Oct 24, 2022

Add new resource WorkforcePool hashicorp/terraform-provider-google-beta#4818

Merged

Add new resource WorkforcePool hashicorp/terraform-provider-google#12863

Merged

Add new resource WorkforcePool GoogleCloudPlatform/terraform-validator#1075

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new resource WorkforcePool #6719

Add new resource WorkforcePool #6719

bohengy commented Oct 19, 2022

modular-magician commented Oct 19, 2022

modular-magician commented Oct 19, 2022

modular-magician commented Oct 19, 2022

modular-magician commented Oct 19, 2022

slevenick commented Oct 19, 2022

bohengy commented Oct 19, 2022

modular-magician commented Oct 19, 2022

slevenick commented Oct 19, 2022

modular-magician commented Oct 19, 2022

modular-magician commented Oct 19, 2022

slevenick commented Oct 19, 2022

modular-magician commented Oct 19, 2022

modular-magician commented Oct 20, 2022

modular-magician commented Oct 20, 2022

modular-magician commented Oct 20, 2022

slevenick Oct 20, 2022

bohengy Oct 20, 2022

modular-magician commented Oct 20, 2022

modular-magician commented Oct 20, 2022

modular-magician commented Oct 20, 2022

modular-magician commented Oct 20, 2022

slevenick commented Oct 20, 2022

slevenick left a comment

modular-magician commented Oct 20, 2022

modular-magician commented Oct 21, 2022

modular-magician commented Oct 21, 2022

modular-magician commented Oct 21, 2022

		@@ -0,0 +1,37 @@
		const workforcePoolIdRegexp = `^[0-9a-z-]+$`

		func validateWorkforcePoolId(v interface{}, k string) (ws []string, errors []error) {

Add new resource WorkforcePool #6719

Add new resource WorkforcePool #6719

Conversation

bohengy commented Oct 19, 2022

modular-magician commented Oct 19, 2022

modular-magician commented Oct 19, 2022

Diff report

modular-magician commented Oct 19, 2022

Tests analytics

Action taken

modular-magician commented Oct 19, 2022

slevenick commented Oct 19, 2022

bohengy commented Oct 19, 2022

modular-magician commented Oct 19, 2022

Diff report

slevenick commented Oct 19, 2022

modular-magician commented Oct 19, 2022

Tests analytics

Action taken

modular-magician commented Oct 19, 2022

slevenick commented Oct 19, 2022

modular-magician commented Oct 19, 2022

Diff report

modular-magician commented Oct 20, 2022

Diff report

modular-magician commented Oct 20, 2022

Tests analytics

Action taken

modular-magician commented Oct 20, 2022

slevenick Oct 20, 2022

Choose a reason for hiding this comment

bohengy Oct 20, 2022

Choose a reason for hiding this comment

modular-magician commented Oct 20, 2022

Diff report

modular-magician commented Oct 20, 2022

Diff report

modular-magician commented Oct 20, 2022

Tests analytics

Action taken

modular-magician commented Oct 20, 2022

slevenick commented Oct 20, 2022

slevenick left a comment

Choose a reason for hiding this comment

modular-magician commented Oct 20, 2022

Diff report

modular-magician commented Oct 21, 2022

Diff report

modular-magician commented Oct 21, 2022

Tests analytics

Action taken

modular-magician commented Oct 21, 2022