Add max_run_duration to instance and instance template on Beta

[andrewyz]

Add max_run_duration support that will set a deadline for running VM (Beta).

See MaxRunDuration section in
https://pkg.go.dev/google.golang.org/[email protected]/compute/v0.beta

part of hashicorp/terraform-provider-google#13005

Testing disclaimer: I verified the VM is created successfully, and the parameter is correct, however, the test is failed, I think it is more like the environment/framework issue, and I can not figure out how to fix.
provider_test.go:307: Failed state verification, resource with ID projects/debian-cloud/global/images/debian-11-bullseye-v20221102 not found

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `max_run_duration` field to `google_compute_instance` and `google_compute_instance_template` resource (beta)

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 7 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 164 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2240
Passed tests 1996
Skipped tests: 241
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_spotVM|TestAccComputeInstance_spotVM_update|TestAccComputeInstanceTemplate_spot

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeInstance_spotVM[Debug log]
TestAccComputeInstance_spotVM_update[Debug log]
TestAccComputeInstanceTemplate_spot[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 7 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 164 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2278
Passed tests 2033
Skipped tests: 244
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings

[modular-magician]

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

[shuyama1]

I tested the feature a bit locally. 1. I don't think the duration can be updated after it got specified. 2. I'm not 100% sure if this will work well with Terraform. It seems the vm will terminated after it hit the max run duration and running terraform apply after will just keep re-applying the max_run_duration

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 7 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 164 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2288
Passed tests 2042
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccLoggingBucketConfigProject_cmekSettings

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 101 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 353 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2382
Passed tests 2126
Skipped tests: 248
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccComputeInstance_spotVM_maxRunDuration_update|TestAccComputeInstance_spotVM_maxRunDration|TestAccComputeInstance_spotVM|TestAccComputeInstance_spotVM_update|TestAccComputeInstanceTemplate_spot_maxRunDuration|TestAccComputeInstanceTemplate_spot

[modular-magician]

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccComputeInstance_spotVM_maxRunDuration_update[Debug log]
TestAccComputeInstance_spotVM_maxRunDration[Debug log]
TestAccComputeInstance_spotVM[Debug log]
TestAccComputeInstance_spotVM_update[Debug log]
TestAccComputeInstanceTemplate_spot_maxRunDuration[Debug log]
TestAccComputeInstanceTemplate_spot[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 101 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 355 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 101 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 359 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2407
Passed tests 2152
Skipped tests: 251
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccRegionInstanceGroupManager_stateful

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

Tests failed during RECORDING mode:
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[shuyama1]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 101 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 7 files changed, 359 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2410
Passed tests 2159
Skipped tests: 251
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

[shuyama1]

LGTM! Thank you!