Promoted managed_prometheus field in google_container_cluster` to GA

[IIBenII]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: promoted `managed_prometheus` field in google_container_cluster` to GA

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 34 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[shuyama1]

Do you know if we have tests on managed_prometheus? If so, can we promote the corresponding tests to GA as well; If not, would you mind adding a test / modifying an existing one? Please let me know if you have any questions!

[IIBenII]

Do you know if we have tests on managed_prometheus? If so, can we promote the corresponding tests to GA as well; If not, would you mind adding a test / modifying an existing one? Please let me know if you have any questions!

@shuyama1 Test already exists I just remove the flag beta

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 118 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2281
Passed tests 2035
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

[shuyama1]

GA tests: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/356203

[IIBenII]

@shuyama1 I'm sorry i don't have access to it. Everything ok?

[shuyama1]

Tests failed due to:

provider_test.go:307: Step 7/16 error: Error running pre-apply refresh: exit status 1
2022/11/28 21:06:40 [DEBUG] Using modified User-Agent: Terraform/0.12.30 HashiCorp-terraform-exec/0.17.2
Error: expected monitoring_config.0.enable_components.4 to be one of [SYSTEM_COMPONENTS APISERVER CONTROLLER_MANAGER SCHEDULER], got WORKLOADS
on terraform_plugin_test.tf line 8, in resource "google_container_cluster" "primary":
8:          enable_components = [ "SYSTEM_COMPONENTS", "APISERVER", "CONTROLLER_MANAGER", "SCHEDULER", "WORKLOADS" ]
testing_new.go:84: Error running post-test destroy, there may be dangling resources: exit status 1
2022/11/28 21:06:41 [DEBUG] Using modified User-Agent: Terraform/0.12.30 HashiCorp-terraform-exec/0.17.2
Error: expected monitoring_config.0.enable_components.4 to be one of [SYSTEM_COMPONENTS APISERVER CONTROLLER_MANAGER SCHEDULER], got WORKLOADS
on terraform_plugin_test.tf line 8, in resource "google_container_cluster" "primary":
8:          enable_components = [ "SYSTEM_COMPONENTS", "APISERVER", "CONTROLLER_MANAGER", "SCHEDULER", "WORKLOADS" ]
--- FAIL: TestAccContainerCluster_withMonitoringConfig (1094.60s)
FAIL

Did you happen to run the test against GA provider locally? If so, are you able to get them passed?
Let me know if you need help debugging?

[IIBenII]

It's because inside the function testAccContainerCluster_withLoggingConfigUpdated the attributes enable_components has value WORKLOADS. This attributes is only in Beta and will be deprecated in GKE 1.24 https://cloud.google.com/stackdriver/docs/solutions/gke/workload-metrics

I think it's safe to remove the value in the test. Are you agree?

[shuyama1]

Thanks for the update. That sounds reasonable! Or we can keep this test step in beta (keep the beta flag) and add a new step in the test with managed_prometheus in GA. Just want to be extra cautious and make sure we will be able to catch any errors caused by deprecation in the future.

[IIBenII]

Ok got it, I pushed a version without workload just to make sure everything is ok. I will try tomorrow to add this new test, I don't know how, but I'll figure it out.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 119 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2294
Passed tests 2047
Skipped tests: 244
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccContainerCluster_withLoggingConfig|TestAccComputeForwardingRule_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccContainerCluster_withLoggingConfig[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 97 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 5 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2302
Passed tests 2047
Skipped tests: 244
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccVertexAIIndex_updated|TestAccVertexAIIndex_vertexAiIndexStreamingExample|TestAccVertexAIIndex_vertexAiIndexExample|TestAccDataFusionInstanceIamPolicyGenerated|TestAccDataFusionInstanceIamMemberGenerated|TestAccDataFusionInstanceIamBindingGenerated|TestAccDataFusionInstance_dataFusionInstanceZoneExample|TestAccDataFusionInstance_dataFusionInstanceEventExample|TestAccContainerCluster_withMonitoringConfig|TestAccDataFusionInstance_dataFusionInstanceFullExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccVertexAIIndex_vertexAiIndexStreamingExample[Debug log]
TestAccVertexAIIndex_vertexAiIndexExample[Debug log]
TestAccDataFusionInstanceIamPolicyGenerated[Debug log]
TestAccDataFusionInstanceIamMemberGenerated[Debug log]
TestAccDataFusionInstanceIamBindingGenerated[Debug log]
TestAccDataFusionInstance_dataFusionInstanceZoneExample[Debug log]
TestAccDataFusionInstance_dataFusionInstanceEventExample[Debug log]
TestAccDataFusionInstance_dataFusionInstanceFullExample[Debug log]

Tests failed during RECORDING mode:
TestAccVertexAIIndex_updated[Error message] [Debug log]
TestAccContainerCluster_withMonitoringConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 97 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 5 insertions(+), 4 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[IIBenII]

@shuyama1 the last version, I pushed, tests run without errors locally. Can you check on your CI if it's ok? Thanks 🙏

[modular-magician]

Tests analytics

Total tests: 2302
Passed tests 2052
Skipped tests: 244
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withMonitoringConfig|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withMonitoringConfig[Debug log]
TestAccCloudFunctions2Function_fullUpdate[Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Debug log]

All tests passed
View the build log or the debug log for each test

[IIBenII]

@shuyama1 everything is ok ?

[shuyama1]

Thanks for the ping! GA test passed https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/356471?buildTab=tests&status=passed

[shuyama1]

Thank you!