Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metastore_service - add telemetry_config #6993

Merged
merged 5 commits into from
Jan 10, 2023

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Dec 19, 2022

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

metastore: Added `telemetry_config` field to `google_dataproc_metastore_service`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @SarahFrench, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 90 insertions(+))
Terraform Beta: Diff ( 3 files changed, 134 insertions(+))
TF Validator: Diff ( 3 files changed, 32 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 115 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2355
Passed tests 2104
Skipped tests: 247
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccDataprocMetastoreService_dataprocMetastoreServiceTelemetryExample|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccLoggingBucketConfigProject_cmekSettings

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

Tests failed during RECORDING mode:
TestAccDataprocMetastoreService_dataprocMetastoreServiceTelemetryExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@DrFaust92 DrFaust92 marked this pull request as draft December 19, 2022 19:57
@DrFaust92 DrFaust92 marked this pull request as ready for review December 31, 2022 18:32
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 134 insertions(+))
Terraform Beta: Diff ( 3 files changed, 134 insertions(+))
TF Validator: Diff ( 3 files changed, 32 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 115 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2381
Passed tests 2129
Skipped tests: 248
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccDataprocMetastoreService_dataprocMetastoreServiceTelemetryExample|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccLoggingBucketConfigProject_cmekSettings

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataprocMetastoreService_dataprocMetastoreServiceTelemetryExample[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

@SarahFrench SarahFrench self-assigned this Jan 3, 2023
Copy link
Collaborator

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DrFaust92 thanks for your contribution! This PR looks good to me, but could you please remove the diffs resulting from formatting/linting the yaml files? I find it's harder to review when there are diffs making style changes, and I don't want to miss something important while reviewing.

@DrFaust92
Copy link
Contributor Author

DrFaust92 commented Jan 3, 2023 via email

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 134 insertions(+))
Terraform Beta: Diff ( 3 files changed, 134 insertions(+))
TF Validator: Diff ( 3 files changed, 32 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 115 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2387
Passed tests 2138
Skipped tests: 248
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccContainerCluster_withInvalidGatewayApiConfigChannel

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

All tests passed
View the build log or the debug log for each test

SarahFrench
SarahFrench previously approved these changes Jan 5, 2023
Copy link
Collaborator

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the formatting changes - the yaml could definitely benefit from some cleanup in future though!

Approved 🚀

@SarahFrench SarahFrench dismissed their stale review January 5, 2023 17:25

Going to look into the checks

@SarahFrench
Copy link
Collaborator

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 134 insertions(+))
Terraform Beta: Diff ( 3 files changed, 134 insertions(+))
TF Validator: Diff ( 3 files changed, 32 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 115 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2390
Passed tests 2137
Skipped tests: 248
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccDatastreamStream_datastreamStreamFullExample|TestAccDatastreamStream_datastreamStreamBasicExample|TestAccDatastreamStream_update|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDatastreamStream_datastreamStreamFullExample[Debug log]
TestAccDatastreamStream_datastreamStreamBasicExample[Debug log]
TestAccDatastreamStream_update[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

Copy link
Collaborator

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks passed - approving (again!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants