Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud run v2 iam support #7091

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Jan 7, 2023

Closes #13394
If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_cloud_run_v2_job_iam_binding
google_cloud_run_v2_job_iam_member
google_cloud_run_v2_job_iam_policy
google_cloud_run_v2_service_iam_binding
google_cloud_run_v2_service_iam_member
google_cloud_run_v2_service_iam_policy

@DrFaust92 DrFaust92 changed the title job iam cloud run v2 job iam support Jan 7, 2023
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 633 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 633 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 352 insertions(+), 3 deletions(-))

@DrFaust92 DrFaust92 changed the title cloud run v2 job iam support cloud run v2 iam support Jan 7, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1274 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1274 insertions(+), 2 deletions(-))
TF Validator: Diff ( 7 files changed, 701 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2399
Passed tests 2138
Skipped tests: 251
Failed tests: 10

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccCloudRunV2ServiceIamPolicyGenerated|TestAccCloudRunV2ServiceIamMemberGenerated|TestAccCloudRunV2ServiceIamBindingGenerated|TestAccCloudRunV2JobIamPolicyGenerated|TestAccCloudRunV2JobIamBindingGenerated|TestAccCloudRunV2JobIamMemberGenerated|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccComposerEnvironment_UpdateComposerV2|TestAccComposerEnvironment_ComposerV2

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccCloudRunV2ServiceIamPolicyGenerated[Debug log]
TestAccCloudRunV2ServiceIamMemberGenerated[Debug log]
TestAccCloudRunV2ServiceIamBindingGenerated[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

Tests failed during RECORDING mode:
TestAccCloudRunV2JobIamPolicyGenerated[Error message] [Debug log]
TestAccCloudRunV2JobIamBindingGenerated[Error message] [Debug log]
TestAccCloudRunV2JobIamMemberGenerated[Error message] [Debug log]
TestAccComposerEnvironment_UpdateComposerV2[Error message] [Debug log]
TestAccComposerEnvironment_ComposerV2[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@ScottSuarez
Copy link
Contributor

        Error: Error waiting for Deleting Job: timeout while waiting for state to become 'done: true' (last state: 'done: false', timeout: 20m0s)

Might need to extend the timeout for this

@shuyama1
Copy link
Member

This may be a known issue b/264296890 for cloud run v2 job and it should be fixed by now(?)
/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1274 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1274 insertions(+), 2 deletions(-))
TF Validator: Diff ( 7 files changed, 701 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2406
Passed tests 2146
Skipped tests: 251
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccCloudRunV2JobIamPolicyGenerated|TestAccCloudRunV2JobIamMemberGenerated|TestAccCloudRunV2JobIamBindingGenerated|TestAccDataSourceSqlDatabaseInstances_tierFilter|TestAccDataSourceSqlDatabaseInstances_regionFilter|TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter|TestAccDataSourceSqlDatabaseInstances_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccCloudRunV2JobIamPolicyGenerated[Debug log]
TestAccCloudRunV2JobIamMemberGenerated[Debug log]
TestAccCloudRunV2JobIamBindingGenerated[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceSqlDatabaseInstances_tierFilter[Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_regionFilter[Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter[Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@DrFaust92
Copy link
Contributor Author

Nice, thanks shuyama1 and ScottSuarez!

@ScottSuarez
Copy link
Contributor

Could you rebase this pull request? These failures appear to be transient

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1254 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1254 insertions(+), 2 deletions(-))
TF Validator: Diff ( 7 files changed, 701 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2414
Passed tests 2159
Skipped tests: 251
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccCloudRunV2ServiceIamPolicyGenerated|TestAccCloudRunV2ServiceIamMemberGenerated|TestAccCloudRunV2ServiceIamBindingGenerated

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccCloudRunV2ServiceIamPolicyGenerated[Debug log]
TestAccCloudRunV2ServiceIamMemberGenerated[Debug log]
TestAccCloudRunV2ServiceIamBindingGenerated[Debug log]

All tests passed
View the build log or the debug log for each test

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Google Cloud Run Job IAM Binding
4 participants