Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DCL to v1.31.0 #7109

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Upgrade DCL to v1.31.0 #7109

merged 1 commit into from
Jan 11, 2023

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Jan 10, 2023

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: added update support for `google_container_aws_node_pool` `tags` field
container: added `google_container_aws_node_pool` `autoscaling_metrics_collection` field

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 94 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 4 files changed, 98 insertions(+), 40 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2400
Passed tests 2144
Skipped tests: 251
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccDataSourceSqlDatabaseInstances_tierFilter|TestAccDataSourceSqlDatabaseInstances_regionFilter|TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter|TestAccDataSourceSqlDatabaseInstances_basic|TestAccContainerCluster_withInvalidGatewayApiConfigChannel

@trodge trodge requested a review from slevenick January 10, 2023 23:00
@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceSqlDatabaseInstances_tierFilter[Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_regionFilter[Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter[Error message] [Debug log]
TestAccDataSourceSqlDatabaseInstances_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the changelog notes to be more in-line with our standards.

Looks like some SQL DB tests failed, I know those are unrelated but can you either fix those or figure out why they've changed and started failing?

@slevenick
Copy link
Contributor

It may just require a rebase to pull in #7107

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 94 insertions(+), 36 deletions(-))
Terraform Beta: Diff ( 4 files changed, 98 insertions(+), 40 deletions(-))
TF Validator: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2400
Passed tests 2147
Skipped tests: 251
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Debug log]

All tests passed
View the build log or the debug log for each test

@slevenick slevenick self-requested a review January 11, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants