-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds enterprise_config_resource_name field to cloudbuild trigger resource in order to support github enter… #7236
Adds enterprise_config_resource_name field to cloudbuild trigger resource in order to support github enter… #7236
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
7747645
to
424c608
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 48 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful|TestAccComputeForwardingRule_update|TestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccDataSourceDnsRecordSet_basic|TestAccFrameworkProviderMeta_setModuleName |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
424c608
to
55df54b
Compare
…urce in order to support github enterprise triggers
55df54b
to
4f3e927
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was manually tested. We don't currently support the GithubEnterpriseConfig object in Terraform, but we already have a few fields on this resource that allow referencing a GithubEnterpriseConfig object directly.
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 48 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccApigeeAddonsConfig_apigeeAddonsTestExample|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceDnsManagedZone_basic|TestAccFrameworkProviderMeta_setModuleName |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
…urce in order to support github enter… (GoogleCloudPlatform#7236) * Adds enterprise_config_resource_name field to cloudbuild trigger resource in order to support github enterprise triggers * Fix newline at EOF --------- Co-authored-by: Mario Machado <[email protected]>
…urce in order to support github enter… (GoogleCloudPlatform#7236) * Adds enterprise_config_resource_name field to cloudbuild trigger resource in order to support github enterprise triggers * Fix newline at EOF --------- Co-authored-by: Mario Machado <[email protected]>
…prise triggers
Resolves hashicorp/terraform-provider-google#9956
Adds github enterprise trigger support to cloud build triggers by adding
github.enterprise_config_resource_name
field.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)