Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sending disableConnectionDrainOnFailover #7326

Merged
merged 3 commits into from
Mar 2, 2023

Conversation

edwardmedia
Copy link
Contributor

@edwardmedia edwardmedia commented Feb 19, 2023

Fixes hashicorp/terraform-provider-google#13529

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed the error of invalid value for field `resource.failoverPolicy` when UDP is selected on `google_compute_region_backend_service`

@edwardmedia edwardmedia requested a review from a team as a code owner February 19, 2023 19:22
@edwardmedia edwardmedia requested review from shuyama1 and removed request for a team February 19, 2023 19:22
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 5 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 52 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 52 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 5 insertions(+), 5 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2468
Passed tests 2210
Skipped tests: 256
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeRegionBackendService_UDPFailOverPolicy|TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_UDPFailOverPolicy[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that this change may prevent both fields from being able to set to false. Would you mind testing on that?

@edwardmedia
Copy link
Contributor Author

good point. let me add tests @shuyama1

@edwardmedia
Copy link
Contributor Author

@shuyama1 your concern is right.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 95 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 95 insertions(+), 1 deletion(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2464
Passed tests 2207
Skipped tests: 255
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeForwardingRule_update

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

@edwardmedia edwardmedia merged commit a6554af into GoogleCloudPlatform:main Mar 2, 2023
mdtro pushed a commit to mdtro/magic-modules that referenced this pull request Mar 2, 2023
* fix sending disableConnectionDrainOnFailover

* add a test

* update tests

---------

Co-authored-by: Edward Sun <[email protected]>
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
* fix sending disableConnectionDrainOnFailover

* add a test

* update tests

---------

Co-authored-by: Edward Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform Deploy Error of UDP failover disableConnectionDrainOnFailover configuration
3 participants