Support IPV6 for HA VPN.

[600lyy]

Support IPV6/dual stack in HA VPN gateway
hashicorp/terraform-provider-google#13752

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added stack_type to resource `ha_vpn_gateway`

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 89 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 89 insertions(+), 1 deletion(-))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2524
Passed tests 2246
Skipped tests: 264
Affected tests: 14

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeVpnTunnel_router|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example|TestAccComputeHaVpnGateway_haVpnGatewayBasicExample|TestAccNetworkServicesGateway_update|TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic|TestAccDataSourceComputeHaVpnGateway|TestAccDataSourceComputeRouterStatus|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeVpnTunnel_router[Debug log]
TestAccComputeRouterInterface_withTunnel[Debug log]
TestAccComputeRouterPeer_bfd[Debug log]
TestAccComputeRouterPeer_enable[Debug log]
TestAccComputeRouterPeer_advertiseMode[Debug log]
TestAccComputeRouterPeer_basic[Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example[Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample[Debug log]
TestAccNetworkServicesGateway_update[Debug log]
TestAccDataSourceComputeRouterStatus[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic[Error message] [Debug log]
TestAccDataSourceComputeHaVpnGateway[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 97 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 97 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2524
Passed tests 2255
Skipped tests: 264
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_update|TestAccFirebaserulesRelease_BasicRelease|TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic|TestAccDataSourceComputeHaVpnGateway|TestAccDataSourceDnsManagedZone_basic

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_update[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataSourceComputeHaVpnGateway[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleCloudAssetResourcesSearchAll_basic[Error message] [Debug log]
TestAccDataSourceDnsManagedZone_basic[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[600lyy]

@ScottSuarez Can you pls review the PR if you get a chance? Thanks

[ScottSuarez]

I suspect this change isn't effectual. Notice you are using the terraform name instead of the api name. This will pass stack_type to the api which doesn't exist on it's schema.

We can remove ignore read once this value is being properly sent. I suspect the reason you are needing to currently ignore read is because the value is not actually being sent to the api.

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 103 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 4 files changed, 103 insertions(+), 1 deletion(-))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

[shuyama1]

Sorry that the build was interrupted by a CI change testing. Kick off a new build.
/gcbrun

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 95 insertions(+))
Terraform Beta: Diff ( 3 files changed, 95 insertions(+))
TF Validator: Diff ( 3 files changed, 13 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2569
Passed tests 2284
Skipped tests: 267
Affected tests: 18

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNetworkServicesGateway_update|TestAccFrameworkProviderBasePath_setBasePath|TestAccFrameworkProviderMeta_setModuleName|TestAccComputeVpnTunnel_router|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccDataSourceComputeRouterStatus|TestAccDataSourceComputeHaVpnGateway|TestAccDataSourceDnsRecordSet_basic|TestAccDataSourceDnsManagedZone_basic|TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example|TestAccComputeHaVpnGateway_haVpnGatewayBasicExample|TestAccDataSourceDNSKeys_noDnsSec|TestAccDataSourceDNSKeys_basic|TestAccComputeInstanceFromRegionTemplate_basic

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccNetworkServicesGateway_update[Debug log]
TestAccFrameworkProviderBasePath_setBasePath[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]
TestAccComputeVpnTunnel_router[Debug log]
TestAccComputeRouterInterface_withTunnel[Debug log]
TestAccComputeRouterPeer_bfd[Debug log]
TestAccComputeRouterPeer_enable[Debug log]
TestAccComputeRouterPeer_advertiseMode[Debug log]
TestAccComputeRouterPeer_basic[Debug log]
TestAccDataSourceComputeRouterStatus[Debug log]
TestAccDataSourceComputeHaVpnGateway[Debug log]
TestAccDataSourceDnsRecordSet_basic[Debug log]
TestAccDataSourceDnsManagedZone_basic[Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayIpv6Example[Debug log]
TestAccComputeHaVpnGateway_haVpnGatewayBasicExample[Debug log]
TestAccDataSourceDNSKeys_noDnsSec[Debug log]
TestAccDataSourceDNSKeys_basic[Debug log]
TestAccComputeInstanceFromRegionTemplate_basic[Debug log]

All tests passed
View the build log or the debug log for each test

[ScottSuarez]

Hiya ! Could you fix the release note in your initial comment?

ie...
Please only use the types listed in master/.ci/RELEASE_NOTES_GUIDE.md.

[600lyy]

Updated release note

[ScottSuarez]

Thanks for the work !

[rileykarson]

@ScottSuarez please ensure that changelog entries refer to the actual resource name in the provider! I've adjusted this to:

compute: added support for `stack_type` to `google_compute_ha_vpn_gateway`

[ScottSuarez]

Will do !