Added updation capability in google_data_loss_prevention_stored_info_type resource

[abheda-crest]

Added updation capability for dictionary, regex, and large_custom_dictionary fields in the google_data_loss_prevention_stored_info_type resource.

Added updation capability for the group_indexes subfield inside the regex field in the google_data_loss_prevention_stored_info_type resource.

fixes hashicorp/terraform-provider-google#8435

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dlp: Changed `dictionary`, `regex`, `regex.group_indexes` and `large_custom_dictionary` fields in `google_data_loss_prevention_stored_info_type` to be update-in-place

[abheda-crest]

This PR also targets the issue of group_indexes not being updated through the PATCH call. As mentioned in the comment of this issue, there was a temporary solution of force recreation of the resource when group_indexes is updated but support for PATCH call was required. As this PR introduces updation capability for regex field which is parent field for group_indexes, I've removed ForceNew behaviour for group_indexes field and added relevant tests.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 336 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 336 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2548
Passed tests 2269
Skipped tests: 275
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]

All tests passed
View the build log or the debug log for each test

[roaks3]

Just one comment for now, but code looks good. Running the VCR tests now, and if those look good will approve.

[roaks3]

Could we add a comment here to explain why this is needed? It could mention that updates can be done on these fields if they are changed, but not if the user changes between dictionary/regex/large_custom_dictionary.

[abheda-crest]

I've added comments for this customizedDiff in this PR.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 336 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 336 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 32 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2550
Passed tests 2272
Skipped tests: 275
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFirebaserulesRelease_BasicRelease|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeEnvKeystoreAliasPkcs12_apigeeEnvKeystoreAliasPkcs12Example[Debug log]

All tests passed
View the build log or the debug log for each test

[roaks3]

LGTM, just going to update the release notes a bit