Showing error details for quota exceeded error for gce operations

[upaul9705]

Surfacing error details when compute operation has quota exceeded error while creating a GCE resource.
Quota exceeded error details are provided in quota_info. This change will surface the details in the terraform response.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: surface error details for Compute Operation with quota exceeded errors.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @SarahFrench, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 70 insertions(+))
Terraform Beta: Diff ( 2 files changed, 70 insertions(+))
TF Conversion: Diff ( 3 files changed, 11 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2753
Passed tests 2461
Skipped tests: 283
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccDataSourceAlloydbLocations_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]
TestAccBillingSubaccount_basic[Error message] [Debug log]
TestAccBillingSubaccount_renameOnDestroy[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[upaul9705]

Hi Sarah, A gentle ping for reviewing the PR. Thanks.

[SarahFrench]

👋 Thanks for your patience, these changes look fine to me and I'm happy to approve and merge. The merge conflicts with compute_operation.go.erb and compute_operation_test.go.erb are blocking that though - could you please resolve them?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 62 insertions(+))
Terraform Beta: Diff ( 1 file changed, 62 insertions(+))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2781
Passed tests 2483
Skipped tests: 292
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[SarahFrench]

Checks are now failing 🤔

Ah- I think I had missed that this PR included a unit test and there have been changes in our CI that make failing unit tests clearer on PRs.

I can see this in the failing terraform-provider-google-build-and-unit-tests check that there are some problems with QuotaMessageWithDetailsNoDimensions and QuotaMessageWithDetailsWithDimensions test cases :

--- FAIL: TestComputeOperationError_Error (0.00s)
    --- FAIL: TestComputeOperationError_Error/QuotaMessageWithDetailsNoDimensions (0.00s)
        compute_operation_test.go:254: expected
            Quota DISKS_TOTAL_GB exceeded.  Limit: 1100.0 in region us-central1.
            
            to contain, "metric name = compute.googleapis.com/disks_total_storage", and did not
        compute_operation_test.go:254: expected
            Quota DISKS_TOTAL_GB exceeded.  Limit: 1100.0 in region us-central1.
            
            to contain, "limit name = DISKS-TOTAL-GB-per-project-region", and did not
    --- FAIL: TestComputeOperationError_Error/QuotaMessageWithDetailsWithDimensions (0.00s)
        compute_operation_test.go:254: expected
            Quota DISKS_TOTAL_GB exceeded.  Limit: 1100.0 in region us-central1.
            
            to contain, "metric name = compute.googleapis.com/disks_total_storage", and did not
        compute_operation_test.go:254: expected
            Quota DISKS_TOTAL_GB exceeded.  Limit: 1100.0 in region us-central1.
            
            to contain, "limit name = DISKS-TOTAL-GB-per-project-region", and did not
        compute_operation_test.go:254: expected
            Quota DISKS_TOTAL_GB exceeded.  Limit: 1100.0 in region us-central1.
            
            to contain, "dimensions = map[region:us-central1]", and did not

Could you please address these errors?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 70 insertions(+))
Terraform Beta: Diff ( 2 files changed, 70 insertions(+))
TF Conversion: Diff ( 3 files changed, 11 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2782
Passed tests 2485
Skipped tests: 292
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[upaul9705]

The tests are passing now.

[SarahFrench]

LGTM, merging now