Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC code flow fields to WorkforcePoolProvider. #8212

Merged
merged 8 commits into from
Jul 6, 2023

Conversation

misterpoe
Copy link
Contributor

Add OIDC code flow fields to WorkforcePoolProvider.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

iamworkforcepool: added `oidc.client_secret` field to `google_iam_workforce_pool_provider` and new enum values `CODE` and `MERGE_ID_TOKEN_OVER_USER_INFO_CLAIMS` to `oidc.web_sso_config.response_type` and `oidc.web_sso_config.assertion_claims_behavior` respectively

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 266 insertions(+), 24 deletions(-))
Terraform Beta: Diff ( 4 files changed, 266 insertions(+), 24 deletions(-))
TF Conversion: Diff ( 3 files changed, 63 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2821
Passed tests 2515
Skipped tests: 301
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample|TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcBasicExample|TestAccIAMWorkforcePoolWorkforcePoolProvider_oidc|TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_oidc[Debug log]
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]

Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample[Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcBasicExample[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you'll need to add import state ignore during the tests because the value doesn't come back from the server.

I'm seeing these errors:
vcr_utils.go:150: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.

    (map[string]string) (len=1) {
     (string) (len=41) "oidc.0.client_secret.0.value.0.plain_text": (string) ""
    }
    
    
    (map[string]string) (len=1) {
     (string) (len=41) "oidc.0.client_secret.0.value.0.plain_text": (string) (len=13) "client-secret"
    }

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 268 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 4 files changed, 268 insertions(+), 26 deletions(-))
TF Conversion: Diff ( 3 files changed, 63 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2821
Passed tests 2516
Skipped tests: 301
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample|TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcBasicExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeNetworkEndpoints_networkEndpointsBasic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample[Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcBasicExample[Debug log]
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 268 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 4 files changed, 268 insertions(+), 26 deletions(-))
TF Conversion: Diff ( 3 files changed, 63 insertions(+), 3 deletions(-))

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes needed, but overall looks good

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 268 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 4 files changed, 268 insertions(+), 26 deletions(-))
TF Conversion: Diff ( 3 files changed, 63 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2832
Passed tests 2536
Skipped tests: 294
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeNetworkEndpoints_networkEndpointsBasic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2832
Passed tests 2536
Skipped tests: 294
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 300 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 4 files changed, 300 insertions(+), 26 deletions(-))
TF Conversion: Diff ( 3 files changed, 63 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2834
Passed tests 2536
Skipped tests: 295
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFilestoreSnapshot_filestoreSnapshotFullExample|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 300 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 4 files changed, 300 insertions(+), 26 deletions(-))
TF Conversion: Diff ( 3 files changed, 63 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2834
Passed tests 2536
Skipped tests: 295
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFilestoreSnapshot_filestoreSnapshotFullExample|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFilestoreInstance_filestoreInstanceBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

All tests passed after rerunning REPLAYING mode.


Tests failed during RECORDING mode:
TestAccFilestoreSnapshot_filestoreSnapshotFullExample[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…earing plain_text on thumbprint change always triggers a diff.
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 302 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 4 files changed, 302 insertions(+), 26 deletions(-))
TF Conversion: Diff ( 3 files changed, 63 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2834
Passed tests 2538
Skipped tests: 295
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@misterpoe
Copy link
Contributor Author

TestAccComputeFirewallPolicyRule_multipleRules VCR test failure looks like existing issue: hashicorp/terraform-provider-google#14859.

@misterpoe misterpoe closed this Jul 6, 2023
@misterpoe misterpoe reopened this Jul 6, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 302 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 4 files changed, 302 insertions(+), 26 deletions(-))
TF Conversion: Diff ( 3 files changed, 63 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workforce_pool_provider (0 total tests)
Untested fields: oidc.client_secret.value.plain_text

Please add acceptance tests which include these fields.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2843
Passed tests 2502
Skipped tests: 295
Affected tests: 46

Action taken

Found 46 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsCluster_BasicHandWritten|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccComputeRegionInstanceTemplate_regionDisks|TestAccComputeRegionInstanceTemplate_with18TbScratchDisk|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionInstanceTemplate_withScratchDisk|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccComputeInstanceTemplate_withScratchDisk|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip|TestAccComputeRegionInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromRegionTemplate_basic|TestAccComputeInstanceFromTemplate_self_link_unique|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeRegionInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceFromTemplate_basic|TestAccComputeRegionInstanceTemplate_primaryAliasIpRange|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_NetworkAttachment|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_regionDisks|TestAccComputeRegionInstanceTemplate_metadata_startup_script|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_disks|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccCloudbuildv2Connection_GleOldConnection|TestAccCloudbuildv2Connection_GitlabConnection|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline|TestAccCloudbuildv2Connection_GleConnection|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 302 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 4 files changed, 302 insertions(+), 26 deletions(-))
TF Conversion: Diff ( 3 files changed, 63 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workforce_pool_provider (0 total tests)
Untested fields: oidc.client_secret.value.plain_text

Please add acceptance tests which include these fields.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 302 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 4 files changed, 302 insertions(+), 26 deletions(-))
TF Conversion: Diff ( 3 files changed, 63 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_iam_workforce_pool_provider (0 total tests)
Untested fields: oidc.client_secret.value.plain_text

Please add acceptance tests which include these fields.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2843
Passed tests 2502
Skipped tests: 295
Affected tests: 46

Action taken

Found 46 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccContainerAwsNodePool_BasicHandWritten|TestAccComputeRegionInstanceTemplate_regionDisks|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsCluster_BasicHandWritten|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccComputeRegionInstanceTemplate_with18TbScratchDisk|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeInstanceTemplate_withScratchDisk|TestAccComputeRegionInstanceTemplate_withScratchDisk|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeRegionInstanceTemplate_minCpuPlatform|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromRegionTemplate_basic|TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeRegionInstanceTemplate_guestAccelerator|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceFromTemplate_self_link_unique|TestAccComputeInstanceFromTemplate_basic|TestAccComputeRegionInstanceTemplate_primaryAliasIpRange|TestAccComputeRegionInstanceTemplate_metadata_startup_script|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccComputeInstanceTemplate_NetworkAttachment|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccComputeInstanceTemplate_subnet_custom|TestAccCloudbuildv2Connection_GleOldConnection|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeFirewallPolicyRule_multipleRules|TestAccComputeInstanceTemplate_regionDisks|TestAccCloudbuildv2Connection_GleConnection|TestAccComputeInstanceTemplate_disks|TestAccCloudbuildv2Connection_GitlabConnection|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2843
Passed tests 2502
Skipped tests: 295
Affected tests: 46

Action taken

Found 46 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccContainerAwsNodePool_BasicHandWritten|TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsCluster_BasicHandWritten|TestAccComputeRegionInstanceTemplate_minCpuPlatform|TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip|TestAccComputeRegionInstanceTemplate_guestAccelerator|TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange|TestAccComputeRegionInstanceTemplate_primaryAliasIpRange|TestAccComputeRegionInstanceTemplate_metadata_startup_script|TestAccComputeRegionInstanceTemplate_subnet_auto|TestAccComputeRegionInstanceTemplate_regionDisks|TestAccComputeRegionInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_with18TbScratchDisk|TestAccComputeInstanceTemplate_withScratchDisk|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeRegionInstanceTemplate_with18TbScratchDisk|TestAccComputeRegionInstanceTemplate_withScratchDisk|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromRegionTemplate_basic|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceFromTemplate_self_link_unique|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstanceFromTemplate_basic|TestAccComputeInstanceTemplate_NetworkAttachment|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_regionDisks|TestAccComputeInstanceTemplate_disks|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccCloudbuildv2Connection_GlePrivUpdateConnection|TestAccCloudbuildv2Connection_GlePrivConnection|TestAccCloudbuildv2Connection_GleOldConnection|TestAccCloudbuildv2Connection_GleConnection|TestAccCloudbuildv2Connection_GitlabConnection|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccContainerAwsNodePool_BasicHandWritten[Debug log]
TestAccComputeRegionInstanceTemplate_withScratchDisk[Debug log]
TestAccComputeInstanceFromTemplate_overrideScratchDisk[Debug log]
TestAccComputeInstanceFromRegionTemplate_basic[Debug log]
TestAccComputeRegionInstanceTemplate_guestAcceleratorSkip[Debug log]
TestAccComputeInstanceFromTemplate_overrideBootDisk[Debug log]
TestAccComputeRegionInstanceTemplate_guestAccelerator[Debug log]
TestAccComputeRegionInstanceTemplate_secondaryAliasIpRange[Debug log]
TestAccComputeInstanceFromTemplate_self_link_unique[Debug log]
TestAccComputeInstanceFromTemplate_basic[Debug log]
TestAccComputeRegionInstanceTemplate_primaryAliasIpRange[Debug log]
TestAccComputeRegionInstanceTemplate_metadata_startup_script[Debug log]
TestAccComputeInstanceTemplate_minCpuPlatform[Debug log]
TestAccComputeRegionInstanceTemplate_subnet_custom[Debug log]
TestAccComputeInstanceTemplate_guestAcceleratorSkip[Debug log]
TestAccComputeInstanceTemplate_guestAccelerator[Debug log]
TestAccComputeInstanceTemplate_secondaryAliasIpRange[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline[Debug log]
TestAccComputeInstanceTemplate_NetworkAttachment[Debug log]
TestAccComputeInstanceTemplate_metadata_startup_script[Debug log]
TestAccComputeInstanceTemplate_primaryAliasIpRange[Debug log]
TestAccCloudbuildv2Connection_GlePrivUpdateConnection[Debug log]
TestAccCloudbuildv2Connection_GlePrivConnection[Debug log]
TestAccComputeInstanceTemplate_subnet_custom[Debug log]
TestAccCloudbuildv2Connection_GleOldConnection[Debug log]
TestAccComputeInstanceTemplate_subnet_auto[Debug log]
TestAccComputeInstanceTemplate_regionDisks[Debug log]
TestAccCloudbuildv2Connection_GleConnection[Debug log]
TestAccComputeInstanceTemplate_disks[Debug log]
TestAccCloudbuildv2Connection_GitlabConnection[Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline[Debug log]

Rerun these tests in REPLAYING mode to catch issues

All tests passed after rerunning REPLAYING mode.


Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Several tests got terminated during RECORDING mode.
Please fix these to complete your PR
View the build log or the debug log for each test

@slevenick slevenick merged commit 83af5da into GoogleCloudPlatform:main Jul 6, 2023
Khaledmohamedrefaat pushed a commit to Khaledmohamedrefaat/magic-modules that referenced this pull request Jul 13, 2023
…orm#8212)

* Add OIDC code flow fields to WorkforcePoolProvider.

* Add ignore_read_extra for client secret plaintext to bypass ImportStateVerify check.

* Use server-provided  to correct external drift for client secret.

* Handle nil return values from d.Get.

* Validate that client secret plain_text is non-empty to ensure that clearing plain_text on thumbprint change always triggers a diff.
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…orm#8212)

* Add OIDC code flow fields to WorkforcePoolProvider.

* Add ignore_read_extra for client secret plaintext to bypass ImportStateVerify check.

* Use server-provided  to correct external drift for client secret.

* Handle nil return values from d.Get.

* Validate that client secret plain_text is non-empty to ensure that clearing plain_text on thumbprint change always triggers a diff.
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
…orm#8212)

* Add OIDC code flow fields to WorkforcePoolProvider.

* Add ignore_read_extra for client secret plaintext to bypass ImportStateVerify check.

* Use server-provided  to correct external drift for client secret.

* Handle nil return values from d.Get.

* Validate that client secret plain_text is non-empty to ensure that clearing plain_text on thumbprint change always triggers a diff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants