Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked google_compute_router_peer.peer_ip_address as default from api #8256

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

melinath
Copy link
Member

Resolved hashicorp/terraform-provider-google#14981

Release Note Template for Downstream PRs (will be copied)

compute: made `google_compute_router_peer.peer_ip_address` optional

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 12 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 3 files changed, 12 insertions(+), 21 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@melinath melinath requested review from a team and shuyama1 and removed request for a team June 30, 2023 23:02
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2834
Passed tests 2535
Skipped tests: 295
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_basic|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeRouterPeer_bfd[Debug log]
TestAccComputeRouterPeer_enable[Debug log]
TestAccComputeRouterPeer_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

All tests passed after rerunning REPLAYING mode.


Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@jameswinegar
Copy link

@melinath Is there anything you need to get this merged? It's blocking some of our networking upgrades.

@shuyama1
Copy link
Member

shuyama1 commented Jul 7, 2023

@melinath is OOO. Merging the PR now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_router_peer requires peer_ip_address
4 participants