-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marked google_compute_router_peer.peer_ip_address as default from api #8256
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 12 insertions(+), 21 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeRouterPeer_bfd|TestAccComputeRouterPeer_enable|TestAccComputeRouterPeer_basic|TestAccComputeFirewallPolicyRule_multipleRules |
Tests passed during RECORDING mode: Rerun these tests in REPLAYING mode to catch issuesAll tests passed after rerunning REPLAYING mode. Tests failed during RECORDING mode: Please fix these to complete your PR |
@melinath Is there anything you need to get this merged? It's blocking some of our networking upgrades. |
@melinath is OOO. Merging the PR now |
Resolved hashicorp/terraform-provider-google#14981
Release Note Template for Downstream PRs (will be copied)