-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bigquery table - add json and parquet options #8296
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @NickElliot, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 278 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccBigQueryExternalDataTable_json|TestAccBigQueryExternalDataTable_parquetOptions|TestAccContainerAwsNodePool_BetaBasicHandWritten |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple formatting issues to resolve but otherwise LGTM, will do a final passover once these are resolved.
mmv1/third_party/terraform/tests/resource_bigquery_table_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_bigquery_table_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_bigquery_table_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_bigquery_table_test.go
Outdated
Show resolved
Hide resolved
NickElliot, fixed formatting. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 278 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, to @melinath for final review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add json and parquet option to bq table * fmt * fmt
* add json and parquet option to bq table * fmt * fmt
* add json and parquet option to bq table * fmt * fmt
* add json and parquet option to bq table * fmt * fmt
planning to add more missing args to this resource but splitting thos to several PRs for maintainer sanity
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)