Add continuousBackupConfig and continuousBackupInfo to AlloyDB cluster #8406

GoogleMarcfont · 2023-07-20T16:39:48Z

Add continuousBackupConfig and continuousBackupInfo to AlloyDB cluster.

Fixes hashicorp/terraform-provider-google#15110
b/291745106
Part of hashicorp/terraform-provider-google#13757
b/284523617

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

AlloyDB: added `continuous_backup_config` and `continuous_backup_info` fields to `cluster` resource

…c-modules into marcfont/cbr Merge with main

modular-magician · 2023-07-20T16:40:20Z

Hello! I am a robot. It looks like you are a community contributor. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-07-20T17:02:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 838 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 4 files changed, 838 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 3 files changed, 73 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 5 insertions(+))

modular-magician · 2023-07-20T18:45:49Z

Tests analytics

Total tests: 2877
Passed tests 2566
Skipped tests: 299
Affected tests: 12

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbCluster_continuousBackup_updateDisable|TestAccAlloydbCluster_continuousBackup_updateRecoveryWindowDays|TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight|TestAccAlloydbCluster_continuousBackup_noChangeIfRemoved|TestAccAlloydbCluster_alloydbClusterFullExample|TestAccAlloydbCluster_update|TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable|TestAccAlloydbCluster_maximumFields|TestAccAlloydbCluster_continuousBackup_update_noChangeIfDefaultsSet|TestAccAlloydbCluster_continuousBackup_enabledByDefault|TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

modular-magician · 2023-07-20T18:57:17Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_continuousBackup_updateDisable[Debug log]
TestAccAlloydbCluster_continuousBackup_updateRecoveryWindowDays[Debug log]
TestAccAlloydbCluster_AutomatedBackupPolicyHandlesMidnight[Debug log]
TestAccAlloydbCluster_continuousBackup_noChangeIfRemoved[Debug log]
TestAccAlloydbCluster_alloydbClusterFullExample[Debug log]
TestAccAlloydbCluster_update[Debug log]
TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable[Debug log]
TestAccAlloydbCluster_maximumFields[Debug log]
TestAccAlloydbCluster_continuousBackup_update_noChangeIfDefaultsSet[Debug log]
TestAccAlloydbCluster_continuousBackup_enabledByDefault[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

melinath

a few questions and change requests below.

mmv1/products/alloydb/Cluster.yaml

mmv1/third_party/terraform/tests/resource_alloydb_cluster_test.go

mmv1/products/alloydb/Cluster.yaml

modular-magician · 2023-07-31T23:06:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 708 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 4 files changed, 708 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 3 files changed, 73 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 5 insertions(+))

modular-magician · 2023-08-01T00:23:54Z

Tests analytics

Total tests: 2915
Passed tests 2610
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccAlloydbCluster_continuousBackup_update|TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable

Get to know how VCR tests work

modular-magician · 2023-08-01T00:29:52Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_continuousBackup_update[Debug log]
TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-01T16:34:06Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 708 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 4 files changed, 708 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 3 files changed, 73 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 5 insertions(+))

melinath

LGTM overall, just needs one change to the kms tests.

mmv1/third_party/terraform/tests/resource_alloydb_cluster_test.go

modular-magician · 2023-08-01T17:50:34Z

Tests analytics

Total tests: 2915
Passed tests 2612
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

modular-magician · 2023-08-01T17:51:12Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-01T20:20:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 708 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 4 files changed, 708 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 3 files changed, 73 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 5 insertions(+))

modular-magician · 2023-08-01T20:45:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 720 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 4 files changed, 720 insertions(+), 9 deletions(-))
TF Conversion: Diff ( 3 files changed, 73 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 1 file changed, 5 insertions(+))

modular-magician · 2023-08-01T22:30:45Z

Tests analytics

Total tests: 2917
Passed tests 2613
Skipped tests: 302
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable

Get to know how VCR tests work

modular-magician · 2023-08-01T22:36:30Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_continuousBackup_CMEKIsUpdatable[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

melinath

LGTM, thanks!

GoogleCloudPlatform#8406) * Properly handle ABP midnight (hours = 0) * Add ExpectNonEmptyPlan to test * Add continuous backup config to alloydb cluster * add more unit tests * Adding more tests * Fix cluster.yaml lint * Add default value and update cmek test * Update test to use kms key bootstrapping util * condense update tests * Change encryptionType output field to string * use two different keys * Only update encryption in CBR

GoogleMarcfont added 8 commits July 11, 2023 16:42

Properly handle ABP midnight (hours = 0)

a705911

Add ExpectNonEmptyPlan to test

145121a

Add continuous backup config to alloydb cluster

01bdf49

Properly handle ABP midnight (hours = 0)

1698b7b

add more unit tests

a0a2a68

Merge branch 'marcfont/cbr' of https://github.com/GoogleMarcfont/magi…

cd32e8d

…c-modules into marcfont/cbr Merge with main

Adding more tests

e886c86

Merge branch 'main' into marcfont/cbr

50611a2

modular-magician requested a review from melinath July 20, 2023 16:40

Fix cluster.yaml lint

22dcd5c

melinath requested changes Jul 24, 2023

View reviewed changes

GoogleMarcfont added 4 commits July 31, 2023 16:47

Add default value and update cmek test

6910f0f

Merge branch 'main' into marcfont/cbr

ce93ae5

Update test to use kms key bootstrapping util

9c2350c

condense update tests

95b98e6

modular-magician requested a review from melinath July 31, 2023 22:53

Change encryptionType output field to string

35a8028

melinath requested changes Aug 1, 2023

View reviewed changes

mmv1/third_party/terraform/tests/resource_alloydb_cluster_test.go Outdated Show resolved Hide resolved

use two different keys

6dc4e77

modular-magician requested a review from melinath August 1, 2023 20:06

Only update encryption in CBR

2019c17

melinath approved these changes Aug 1, 2023

View reviewed changes

melinath merged commit ed8f2d4 into GoogleCloudPlatform:main Aug 1, 2023
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add continuousBackupConfig and continuousBackupInfo to AlloyDB cluster #8406

Add continuousBackupConfig and continuousBackupInfo to AlloyDB cluster #8406

GoogleMarcfont commented Jul 20, 2023

modular-magician commented Jul 20, 2023

modular-magician commented Jul 20, 2023

modular-magician commented Jul 20, 2023

modular-magician commented Jul 20, 2023

melinath left a comment

modular-magician commented Jul 31, 2023

modular-magician commented Aug 1, 2023

modular-magician commented Aug 1, 2023

modular-magician commented Aug 1, 2023

melinath left a comment

modular-magician commented Aug 1, 2023

modular-magician commented Aug 1, 2023

modular-magician commented Aug 1, 2023

modular-magician commented Aug 1, 2023

modular-magician commented Aug 1, 2023

modular-magician commented Aug 1, 2023

melinath left a comment

Add continuousBackupConfig and continuousBackupInfo to AlloyDB cluster #8406

Add continuousBackupConfig and continuousBackupInfo to AlloyDB cluster #8406

Conversation

GoogleMarcfont commented Jul 20, 2023

modular-magician commented Jul 20, 2023

modular-magician commented Jul 20, 2023

Diff report

modular-magician commented Jul 20, 2023

Tests analytics

Action taken

modular-magician commented Jul 20, 2023

Rerun these tests in REPLAYING mode to catch issues

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Jul 31, 2023

Diff report

modular-magician commented Aug 1, 2023

Tests analytics

Action taken

modular-magician commented Aug 1, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Aug 1, 2023

Diff report

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 1, 2023

Tests analytics

Action taken

modular-magician commented Aug 1, 2023

modular-magician commented Aug 1, 2023

Diff report

modular-magician commented Aug 1, 2023

Diff report

modular-magician commented Aug 1, 2023

Tests analytics

Action taken

modular-magician commented Aug 1, 2023

Rerun these tests in REPLAYING mode to catch issues

melinath left a comment

Choose a reason for hiding this comment