Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated fields from Cloud Run v2 resources #8529

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Remove deprecated fields from Cloud Run v2 resources #8529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 0 additions & 158 deletions mmv1/products/cloudrunv2/Job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,164 +337,6 @@ properties:
name: 'workingDir'
description: |-
Container's working directory. If not specified, the container runtime's default will be used, which might be configured in the container image.
- !ruby/object:Api::Type::NestedObject
name: 'livenessProbe'
description: |-
Periodic probe of container liveness. Container will be restarted if the probe fails. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes
This field is not supported in Cloud Run Job currently.
deprecation_message:
Cloud Run Job does not support liveness probe and
`liveness_probe` field will be removed in a future major
release.
properties:
- !ruby/object:Api::Type::Integer
name: 'initialDelaySeconds'
description: |-
Number of seconds after the container has started before the probe is initiated. Defaults to 0 seconds. Minimum value is 0. Maximum value for liveness probe is 3600. Maximum value for startup probe is 240. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes
default_value: 0
- !ruby/object:Api::Type::Integer
name: 'timeoutSeconds'
description: |-
Number of seconds after which the probe times out. Defaults to 1 second. Minimum value is 1. Maximum value is 3600. Must be smaller than periodSeconds. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes
default_value: 1
- !ruby/object:Api::Type::Integer
name: 'periodSeconds'
description: |-
How often (in seconds) to perform the probe. Default to 10 seconds. Minimum value is 1. Maximum value for liveness probe is 3600. Maximum value for startup probe is 240. Must be greater or equal than timeoutSeconds
default_value: 10
- !ruby/object:Api::Type::Integer
name: 'failureThreshold'
description: |-
Minimum consecutive failures for the probe to be considered failed after having succeeded. Defaults to 3. Minimum value is 1.
default_value: 3
- !ruby/object:Api::Type::NestedObject
name: 'httpGet'
description: |-
HTTPGet specifies the http request to perform. Exactly one of HTTPGet or TCPSocket must be specified.
send_empty_value: true
allow_empty_object:
true
# exactly_one_of:
# - template.0.template.0.containers.0.livenessProbe.0.httpGet
# - template.0.template.0.containers.0.livenessProbe.0.tcpSocket
properties:
- !ruby/object:Api::Type::String
name: 'path'
default_value: '/'
description: |-
Path to access on the HTTP server. Defaults to '/'.
- !ruby/object:Api::Type::Array
name: httpHeaders
description: |-
Custom headers to set in the request. HTTP allows repeated headers.
item_type: !ruby/object:Api::Type::NestedObject
properties:
- !ruby/object:Api::Type::String
name: name
required: true
description: |-
The header field name
- !ruby/object:Api::Type::String
name: value
description: |-
The header field value
default_value: ''
send_empty_value: true
- !ruby/object:Api::Type::NestedObject
name: 'tcpSocket'
description: |-
TCPSocket specifies an action involving a TCP port. Exactly one of HTTPGet or TCPSocket must be specified.
send_empty_value: true
allow_empty_object:
true
# exactly_one_of:
# - template.0.template.0.containers.0.livenessProbe.0.httpGet
# - template.0.template.0.containers.0.livenessProbe.0.tcpSocket
properties:
- !ruby/object:Api::Type::Integer
name: port
description: |-
Port number to access on the container. Must be in the range 1 to 65535. If not specified, defaults to 8080.
- !ruby/object:Api::Type::NestedObject
name: 'startupProbe'
description: |-
Startup probe of application within the container. All other probes are disabled if a startup probe is provided, until it succeeds. Container will not be added to service endpoints if the probe fails. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes
This field is not supported in Cloud Run Job currently.
deprecation_message:
Cloud Run Job does not support startup probe and
`startup_probe` field will be removed in a future major
release.
default_from_api: true
properties:
- !ruby/object:Api::Type::Integer
name: 'initialDelaySeconds'
description: |-
Number of seconds after the container has started before the probe is initiated. Defaults to 0 seconds. Minimum value is 0. Maximum value for liveness probe is 3600. Maximum value for startup probe is 240. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes
default_value: 0
- !ruby/object:Api::Type::Integer
name: 'timeoutSeconds'
description: |-
Number of seconds after which the probe times out. Defaults to 1 second. Minimum value is 1. Maximum value is 3600. Must be smaller than periodSeconds. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes
default_value: 1
- !ruby/object:Api::Type::Integer
name: 'periodSeconds'
description: |-
How often (in seconds) to perform the probe. Default to 10 seconds. Minimum value is 1. Maximum value for liveness probe is 3600. Maximum value for startup probe is 240. Must be greater or equal than timeoutSeconds
default_value: 10
- !ruby/object:Api::Type::Integer
name: 'failureThreshold'
description: |-
Minimum consecutive failures for the probe to be considered failed after having succeeded. Defaults to 3. Minimum value is 1.
default_value: 3
- !ruby/object:Api::Type::NestedObject
name: 'httpGet'
description: |-
HTTPGet specifies the http request to perform. Exactly one of HTTPGet or TCPSocket must be specified.
send_empty_value: true
allow_empty_object:
true
# exactly_one_of:
# - template.0.template.0.containers.startupProbe.0.httpGet
# - template.0.template.0.containers.startupProbe.0.tcpSocket
properties:
- !ruby/object:Api::Type::String
name: 'path'
default_value: '/'
description: |-
Path to access on the HTTP server. Defaults to '/'.
- !ruby/object:Api::Type::Array
name: 'httpHeaders'
description: |-
Custom headers to set in the request. HTTP allows repeated headers.
item_type: !ruby/object:Api::Type::NestedObject
properties:
- !ruby/object:Api::Type::String
name: name
required: true
description: |-
The header field name
- !ruby/object:Api::Type::String
name: value
description: |-
The header field value
default_value: ''
send_empty_value: true
- !ruby/object:Api::Type::NestedObject
name: 'tcpSocket'
description: |-
TCPSocket specifies an action involving a TCP port. Exactly one of HTTPGet or TCPSocket must be specified.
send_empty_value: true
allow_empty_object:
true
# exactly_one_of:
# - template.0.template.0.containers.startupProbe.0.httpGet
# - template.0.template.0.containers.startupProbe.0.tcpSocket
properties:
- !ruby/object:Api::Type::Integer
name: port
description: |-
Port number to access on the container. Must be in the range 1 to 65535. If not specified, defaults to 8080.
default_from_api: true
- !ruby/object:Api::Type::Array
name: 'volumes'
description: |-
Expand Down
15 changes: 0 additions & 15 deletions mmv1/products/cloudrunv2/Service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,21 +459,6 @@ properties:
The header field value
default_value: ''
send_empty_value: true
- !ruby/object:Api::Type::NestedObject
name: 'tcpSocket'
description: |-
TCPSocket specifies an action involving a TCP port. This field is not supported in liveness probe currently.
deprecation_message:
Cloud Run does not support tcp socket in liveness probe and
`liveness_probe.tcp_socket` field will be removed in a
future major release.
send_empty_value: true
allow_empty_object: true
properties:
- !ruby/object:Api::Type::Integer
name: port
description: |-
Port number to access on the container. Must be in the range 1 to 65535. If not specified, defaults to 8080.
- !ruby/object:Api::Type::NestedObject
name: grpc
description: |-
Expand Down