Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated fields #8531

Conversation

gfxcc
Copy link
Contributor

@gfxcc gfxcc commented Aug 3, 2023

Remove deprecated fields

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

privateca: removed deprecated fields `configValues`, `pemCertificates`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field certificate_description.config_values.key_usage.base_key_usage.key_usage_options.cert_sign within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.base_key_usage.key_usage_options.content_commitment within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.base_key_usage.key_usage_options.crl_sign within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.base_key_usage.key_usage_options.data_encipherment within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.base_key_usage.key_usage_options.decipher_only within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.base_key_usage.key_usage_options.digital_signature within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.base_key_usage.key_usage_options.encipher_only within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.base_key_usage.key_usage_options.key_agreement within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.base_key_usage.key_usage_options.key_encipherment within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.base_key_usage.key_usage_options within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.base_key_usage within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.extended_key_usage.client_auth within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.extended_key_usage.code_signing within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.extended_key_usage.email_protection within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.extended_key_usage.ocsp_signing within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.extended_key_usage.server_auth within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.extended_key_usage.time_stamping within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.extended_key_usage within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.unknown_extended_key_usages.obect_id.object_id_path within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.unknown_extended_key_usages.obect_id within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage.unknown_extended_key_usages within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values.key_usage within resource google_privateca_certificate was either removed or renamed - reference
  • Field certificate_description.config_values within resource google_privateca_certificate was either removed or renamed - reference
  • Field pem_certificates within resource google_privateca_certificate was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 476 deletions(-))
Terraform Beta: Diff ( 2 files changed, 476 deletions(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2873
Passed tests 2572
Skipped tests: 300
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}
View the build log or the debug log for each test

@gfxcc gfxcc marked this pull request as ready for review August 3, 2023 04:53
@gfxcc
Copy link
Contributor Author

gfxcc commented Aug 7, 2023

@trodge , PTAL

@trodge
Copy link
Contributor

trodge commented Aug 14, 2023

Have you created a separate PR with an upgrade guide as per these instructions?

@gfxcc
Copy link
Contributor Author

gfxcc commented Aug 16, 2023

Have you created a separate PR with an upgrade guide as per these instructions?

#8666 is created to add upgrade guide

@trodge trodge added the override-breaking-change Allows a potential breaking change to be merged label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
override-breaking-change Allows a potential breaking change to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants