Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync 5.0.0 with main Part 2 #8551

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Sync 5.0.0 with main Part 2 #8551

merged 1 commit into from
Aug 3, 2023

Conversation

shuyama1
Copy link
Member

@shuyama1 shuyama1 commented Aug 3, 2023 •
edited
Loading

This is only to merge #7797 to the 5.0.0 branch and the generate-diffs check is expected to fail within this PR, I think.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@iyabchen @melinath
tgc build on tpg-beta (#7797)
9faed08 
* tgc build on tpg-beta

* gcb-push-downstream.yml change ga to beta for tgc

* fix forward rule test file

* Address comment

* compute forwarding rule test file set to beta

* switch tgc-base to use beta

* tgc make always use beta

* generate downstream always use beta for tgc

---------

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
@shuyama1 shuyama1 changed the title tgc build on tpg-beta (#7797) Sync 5.0.0 with main Part 2 Aug 3, 2023
@shuyama1 shuyama1 requested a review from melinath August 3, 2023 22:17
melinath
melinath approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generates cleanly on top of the tgc major release branch

@shuyama1 shuyama1 merged commit 5441a1d into FEATURE-BRANCH-major-release-5.0.0 Aug 3, 2023
20 of 21 checks passed
@shuyama1 shuyama1 deleted the post_tgc_beta branch August 3, 2023 23:07
@modular-magician modular-magician mentioned this pull request Aug 3, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuyama1 @melinath @iyabchen