-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guides for labels and annotations #8608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a provider-level change, so please but it slightly lower in the
Provider section
You can then remove the example where it says "Provider-level change example header"
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
Thanks so much for the comments. |
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Section looks much better, thank you for adding clarifications! Can we move the entire section below the ## Provider line on line 119? Then delete the
Provider-level change example header
Description of the change and how users should adjust their configuration (if needed).
lines?
mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
Outdated
Show resolved
Hide resolved
Done. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 28 insertions(+), 2 deletions(-)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 28 insertions(+), 2 deletions(-)) |
* Add guides for labels and annotations * Modify the guides * Modify the guide * Modify the guide * Modify the guide * Add more spaces * Move 'Provider-level Labels Rework' below Provider
* Add guides for labels and annotations * Modify the guides * Modify the guide * Modify the guide * Modify the guide * Add more spaces * Move 'Provider-level Labels Rework' below Provider
Add the introduction to the new labels and annotations models and will add more details later.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)