-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add region security policy in target pool #8614
Add region security policy in target pool #8614
Conversation
…-policy-in-target-pool
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
Hello! I am a robot. It looks like you are a community contributor. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@NickElliot I am moving this task to draft because this feature is only available for whitelist projects. The build project has already been whitelisted so we can start reviewing it. It is expected that this feature might be public available in few days so it would be nice if we are prepared for merging once this happens. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 7 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_target_pool" "primary" {
security_policy = # value needed
}
|
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeTargetPool_withSecurityPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please update when it is ready for a final passover when feature officially reaches public beta status
…-policy-in-target-pool
@NickElliot the feature is public available now. There were bunch of updates on the main branch. Could you please trigger the test once more before we merge it? Thanks |
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 7 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_target_pool" "primary" {
security_policy = # value needed
}
|
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeTargetPool_withSecurityPolicy|TestAccProjectIamPolicy_invalidMembers|TestAccSpannerDatabaseIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Changelog check error resolved. Missing test field report is inaccurate, verified through CI debug logs.
* adding security_policy field to targetPool * updating target pool documentation with security policy
* adding security_policy field to targetPool * updating target pool documentation with security policy
* adding security_policy field to targetPool * updating target pool documentation with security policy
Fixes:
hashicorp/terraform-provider-google#15464
Adding security_policy field in google_compute_target_pool resource.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)