Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region security policy in target pool #8614

Conversation

felipegc
Copy link
Contributor

@felipegc felipegc commented Aug 10, 2023

Fixes:
hashicorp/terraform-provider-google#15464

Adding security_policy field in google_compute_target_pool resource.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added support for `security_policy` field to `google_compute_target_pool`

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 10, 2023
@felipegc felipegc marked this pull request as draft August 10, 2023 19:48
@felipegc
Copy link
Contributor Author

@NickElliot I am moving this task to draft because this feature is only available for whitelist projects. The build project has already been whitelisted so we can start reviewing it. It is expected that this feature might be public available in few days so it would be nice if we are prepared for merging once this happens.
Thanks

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 10, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 7 insertions(+))
Terraform Beta: Diff ( 4 files changed, 166 insertions(+))
TF Conversion: Diff ( 1 file changed, 4 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_target_pool (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_target_pool" "primary" {
  security_policy = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2940
Passed tests 2637
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeTargetPool_withSecurityPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeTargetPool_withSecurityPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please update when it is ready for a final passover when feature officially reaches public beta status

@felipegc felipegc marked this pull request as ready for review August 15, 2023 20:23
@felipegc
Copy link
Contributor Author

@NickElliot the feature is public available now. There were bunch of updates on the main branch. Could you please trigger the test once more before we merge it? Thanks

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Aug 15, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 7 insertions(+))
Terraform Beta: Diff ( 4 files changed, 166 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_target_pool (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_target_pool" "primary" {
  security_policy = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2969
Passed tests 2664
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeTargetPool_withSecurityPolicy|TestAccProjectIamPolicy_invalidMembers|TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeTargetPool_withSecurityPolicy[Debug log]
TestAccProjectIamPolicy_invalidMembers[Debug log]
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Changelog check error resolved. Missing test field report is inaccurate, verified through CI debug logs.

@NickElliot NickElliot merged commit 2a11fe2 into GoogleCloudPlatform:main Aug 18, 2023
7 of 8 checks passed
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 21, 2023
* adding security_policy field to targetPool

* updating target pool documentation with security policy
pl04351820 pushed a commit to pl04351820/magic-modules that referenced this pull request Aug 30, 2023
* adding security_policy field to targetPool

* updating target pool documentation with security policy
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
* adding security_policy field to targetPool

* updating target pool documentation with security policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants