feat(vertexai): Make it possible to use Private Service Connect in Vertex AI Index Endpoint #8851

shotarok · 2023-09-02T17:16:55Z

part of hashicorp/terraform-provider-google#12818

Release Note Template for Downstream PRs (will be copied)

vertexai: added `private_service_connect_config` to `google_vertex_ai_index_endpoint`

…dex endpoint

modular-magician · 2023-09-02T17:17:26Z

Hello! I am a robot. It looks like you are a: Community Contributor ~~Googler~~ ~~Core Contributor~~. Tests will require approval to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

shotarok · 2023-09-02T17:25:30Z

@shuyama1 Hello, when you have time, could you approve the cloud builder to run the acceptance tests? Thanks

mmv1/products/vertexai/IndexEndpoint.yaml

modular-magician · 2023-09-05T16:44:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 180 insertions(+))
Terraform Beta: Diff ( 3 files changed, 180 insertions(+))
TF Conversion: Diff ( 1 file changed, 40 insertions(+))
TF OiCS: Diff ( 4 files changed, 118 insertions(+))

modular-magician · 2023-09-05T17:57:09Z

Tests analytics

Total tests: 3009
Passed tests 2712
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithPscExample

Get to know how VCR tests work

modular-magician · 2023-09-05T17:59:53Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithPscExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

shuyama1 · 2023-09-06T00:14:19Z

mmv1/products/vertexai/IndexEndpoint.yaml

+      - !ruby/object:Api::Type::Boolean
+        name: enablePrivateServiceConnect
+        description: If set to true, the IndexEndpoint is created without private service access.
+      - !ruby/object:Api::Type::Array
+        name: projectAllowlist
+        description: A list of Projects from which the forwarding rule will target the service attachment.
+        item_type: Api::Type::String


Are these two subfields also immutable? If so, I think we need to add immutable as well. If not, it's be nice that we add an update test on it.

Plus, can we make at least one of the subfields required. We 'd try to avoid users from sending empty object.

The subfields were immutable although I tested a PATCH request. Based on your advice, I added immutable: and required: in debd2d1.

shuyama1 · 2023-09-06T00:18:55Z

mmv1/products/vertexai/IndexEndpoint.yaml

+    test_vars_overrides:
+      network_name: 'acctest.BootstrapSharedTestNetwork(t, "vertex-ai-index-endpoint")'


It doesn't look like that network_name is being used anywhere in the test. Feel free to remove it if it's not needed

I confirmed an acceptance test succeeded after removing it. Therefore, I've deleted it in 1a0f1ea.

mmv1/products/vertexai/IndexEndpoint.yaml

shotarok · 2023-09-06T05:08:49Z

@shuyama1 Thank you for your feedback! I've updated the code. Please approve the cloud build job again. Thanks

shotarok · 2023-09-06T19:04:56Z

I merged main to resolve a conflict because another PR for IndexEndpoint was merged

modular-magician · 2023-09-06T20:17:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 183 insertions(+))
Terraform Beta: Diff ( 3 files changed, 183 insertions(+))
TF Conversion: Diff ( 1 file changed, 40 insertions(+))
TF OiCS: Diff ( 4 files changed, 118 insertions(+))

shuyama1

Overall looks good. Only small comment though

shuyama1 · 2023-09-06T21:10:56Z

mmv1/products/vertexai/IndexEndpoint.yaml

@@ -65,7 +68,6 @@ parameters:
    url_param_only: true
    immutable: true
 properties:
-  # Intentionally deployedIndexes[] is not included because it's an output-only field and another terraform resource will manage a deployed index.


Any reason we're removing this comment?

Ah, I initially defined deployedIndexes in this PR, but I reverted it because of #8851 (comment). At that time, I forgot to revert the comment. I'll restore it. Thank you for the catch!

@shuyama1 I fixed it in 40903e2 👍 When you have time, could you approve CI again? Thanks

modular-magician · 2023-09-06T21:30:17Z

Tests analytics

Total tests: 3015
Passed tests 2718
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocClusterIamPolicy

Get to know how VCR tests work

modular-magician · 2023-09-06T21:36:04Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

modular-magician · 2023-09-06T21:49:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 183 insertions(+))
Terraform Beta: Diff ( 3 files changed, 183 insertions(+))
TF Conversion: Diff ( 1 file changed, 40 insertions(+))
TF OiCS: Diff ( 4 files changed, 118 insertions(+))

shotarok · 2023-11-06T04:33:08Z

@shuyama1 I updated the code and replied to the comments. If the changes look good, please approve the CI to run the acceptance tests. Thanks!

shuyama1 · 2023-11-06T17:11:26Z

mmv1/products/vertexai/IndexEndpoint.yaml

@@ -48,11 +48,20 @@ examples:
  - !ruby/object:Provider::Terraform::Examples
    name: "vertex_ai_index_endpoint"
    primary_resource_id: "index_endpoint"
+    skip_docs: true


we'd prefer to keep example of this config in the test but skip vertex_ai_index_endpoint_with_false_psc instead, since vertex_ai_index_endpoint is a standard basic config for the resource

@shuyama1 Thank you for catching this mistake 🙏 It was unintentional. I moved skip_docs: true to the example: 8d0230b. It seems an additional approval is required for triggering cloud builder jobs.

modular-magician · 2023-11-06T17:21:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 232 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 3 files changed, 232 insertions(+), 21 deletions(-))
TF Conversion: Diff ( 1 file changed, 40 insertions(+))
TF OiCS: Diff ( 8 files changed, 231 insertions(+))

modular-magician · 2023-11-06T17:41:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 226 insertions(+))
Terraform Beta: Diff ( 3 files changed, 226 insertions(+))
TF Conversion: Diff ( 1 file changed, 40 insertions(+))
TF OiCS: Diff ( 8 files changed, 231 insertions(+))

modular-magician · 2023-11-06T18:54:05Z

Tests analytics

Total tests: 3205
Passed tests 2876
Skipped tests: 323
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsCluster_BetaBasicHandWritten|TestAccContainerAwsCluster_BetaBasicEnumHandWritten|TestAccDataprocClusterIamPolicy|TestAccLoggingProjectSink_updatePreservesCustomWriter|TestAccSpannerDatabaseIamPolicy|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithFalsePscExample

Get to know how VCR tests work

modular-magician · 2023-11-06T19:05:43Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerAwsCluster_BetaBasicHandWritten[Debug log]
TestAccContainerAwsCluster_BetaBasicEnumHandWritten[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccSpannerDatabaseIamPolicy[Debug log]
TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithFalsePscExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccLoggingProjectSink_updatePreservesCustomWriter[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

shuyama1 · 2023-11-07T20:36:45Z

I think the failed tests/checks should resolve themselves in a rerun
/gcbrun

modular-magician · 2023-11-07T22:14:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 226 insertions(+))
Terraform Beta: Diff ( 3 files changed, 226 insertions(+))
TF Conversion: Diff ( 1 file changed, 40 insertions(+))
TF OiCS: Diff ( 8 files changed, 231 insertions(+))

modular-magician · 2023-11-07T23:28:40Z

Tests analytics

Total tests: 3221
Passed tests 2893
Skipped tests: 328
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

shuyama1

Thank you!

shotarok · 2023-11-08T01:24:15Z

@shuyama1 Thank you so much for your support and reviews! I'm excited to be able to use this new function through terraform!

…rtex AI Index Endpoint (GoogleCloudPlatform#8851)

feat: make it possible to use private service connect in vertex ai in…

04dc267

…dex endpoint

modular-magician requested a review from shuyama1 September 2, 2023 17:17

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 2, 2023

shotarok commented Sep 2, 2023

View reviewed changes

mmv1/products/vertexai/IndexEndpoint.yaml Outdated Show resolved Hide resolved

fix: revert changes regarding deployedIndexes

a00f213

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 5, 2023

shuyama1 requested changes Sep 6, 2023

View reviewed changes

shotarok added 3 commits September 5, 2023 21:34

refactor: removed unnecessary test_vars_overrides

1a0f1ea

feat: update the field's immutability and requirement

debd2d1

feat: define conflicted fields

4970888

modular-magician requested a review from shuyama1 September 6, 2023 05:05

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 6, 2023

Merge branch 'main' into support-psc-in-vertex-ai-index-endpoint

6269755

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 6, 2023

shuyama1 approved these changes Sep 6, 2023

View reviewed changes

refactor: restore a deleted comment

40903e2

modular-magician requested a review from shuyama1 September 6, 2023 21:24

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 6, 2023

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 6, 2023

modular-magician requested a review from shuyama1 November 6, 2023 04:31

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 6, 2023

shuyama1 reviewed Nov 6, 2023

View reviewed changes

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 6, 2023

fix: move 'skip_docs: true' to the expected example

8d0230b

modular-magician requested a review from shuyama1 November 6, 2023 17:30

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Nov 6, 2023

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/aiplatform-matching-engine and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Nov 7, 2023

shuyama1 approved these changes Nov 7, 2023

View reviewed changes

shuyama1 merged commit 20ab4e9 into GoogleCloudPlatform:main Nov 7, 2023
15 checks passed

shotarok deleted the support-psc-in-vertex-ai-index-endpoint branch November 8, 2023 03:05

swamitagupta pushed a commit to swamitagupta/magic-modules that referenced this pull request Nov 14, 2023

feat(vertexai): Make it possible to use Private Service Connect in Ve…

1d77c0e

…rtex AI Index Endpoint (GoogleCloudPlatform#8851)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 28, 2023

feat(vertexai): Make it possible to use Private Service Connect in Ve…

dea4b32

…rtex AI Index Endpoint (GoogleCloudPlatform#8851)

jialei-chen pushed a commit to jialei-chen/magic-modules that referenced this pull request Nov 29, 2023

feat(vertexai): Make it possible to use Private Service Connect in Ve…

1054ba2

…rtex AI Index Endpoint (GoogleCloudPlatform#8851)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(vertexai): Make it possible to use Private Service Connect in Vertex AI Index Endpoint #8851

feat(vertexai): Make it possible to use Private Service Connect in Vertex AI Index Endpoint #8851

shotarok commented Sep 2, 2023

modular-magician commented Sep 2, 2023

shotarok commented Sep 2, 2023

modular-magician commented Sep 5, 2023

modular-magician commented Sep 5, 2023

modular-magician commented Sep 5, 2023

shuyama1 Sep 6, 2023

shotarok Sep 6, 2023

shuyama1 Sep 6, 2023

shotarok Sep 6, 2023 •

edited

Loading

shotarok commented Sep 6, 2023

shotarok commented Sep 6, 2023 •

edited

Loading

modular-magician commented Sep 6, 2023

shuyama1 left a comment

shuyama1 Sep 6, 2023

shotarok Sep 6, 2023 •

edited

Loading

shotarok Sep 6, 2023

modular-magician commented Sep 6, 2023

modular-magician commented Sep 6, 2023

modular-magician commented Sep 6, 2023

shotarok commented Nov 6, 2023

shuyama1 Nov 6, 2023

shotarok Nov 6, 2023 •

edited

Loading

modular-magician commented Nov 6, 2023

modular-magician commented Nov 6, 2023

modular-magician commented Nov 6, 2023

modular-magician commented Nov 6, 2023

shuyama1 commented Nov 7, 2023

modular-magician commented Nov 7, 2023

modular-magician commented Nov 7, 2023

shuyama1 left a comment

shotarok commented Nov 8, 2023

		test_vars_overrides:
		network_name: 'acctest.BootstrapSharedTestNetwork(t, "vertex-ai-index-endpoint")'

feat(vertexai): Make it possible to use Private Service Connect in Vertex AI Index Endpoint #8851

feat(vertexai): Make it possible to use Private Service Connect in Vertex AI Index Endpoint #8851

Conversation

shotarok commented Sep 2, 2023

modular-magician commented Sep 2, 2023

shotarok commented Sep 2, 2023

modular-magician commented Sep 5, 2023

Diff report

modular-magician commented Sep 5, 2023

Tests analytics

Action taken

modular-magician commented Sep 5, 2023

Rerun these tests in REPLAYING mode to catch issues

shuyama1 Sep 6, 2023

Choose a reason for hiding this comment

shotarok Sep 6, 2023

Choose a reason for hiding this comment

shuyama1 Sep 6, 2023

Choose a reason for hiding this comment

shotarok Sep 6, 2023 • edited Loading

Choose a reason for hiding this comment

shotarok commented Sep 6, 2023

shotarok commented Sep 6, 2023 • edited Loading

modular-magician commented Sep 6, 2023

Diff report

shuyama1 left a comment

Choose a reason for hiding this comment

shuyama1 Sep 6, 2023

Choose a reason for hiding this comment

shotarok Sep 6, 2023 • edited Loading

Choose a reason for hiding this comment

shotarok Sep 6, 2023

Choose a reason for hiding this comment

modular-magician commented Sep 6, 2023

Tests analytics

Action taken

modular-magician commented Sep 6, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Sep 6, 2023

Diff report

shotarok commented Nov 6, 2023

shuyama1 Nov 6, 2023

Choose a reason for hiding this comment

shotarok Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

modular-magician commented Nov 6, 2023

Diff report

modular-magician commented Nov 6, 2023

Diff report

modular-magician commented Nov 6, 2023

Tests analytics

Action taken

modular-magician commented Nov 6, 2023

Rerun these tests in REPLAYING mode to catch issues

shuyama1 commented Nov 7, 2023

modular-magician commented Nov 7, 2023

Diff report

modular-magician commented Nov 7, 2023

Tests analytics

shuyama1 left a comment

Choose a reason for hiding this comment

shotarok commented Nov 8, 2023

shotarok Sep 6, 2023 •

edited

Loading

shotarok commented Sep 6, 2023 •

edited

Loading

shotarok Sep 6, 2023 •

edited

Loading

shotarok Nov 6, 2023 •

edited

Loading