Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertexai): Make it possible to create a public Vertex AI Index Endpoint #8852

Conversation

shotarok
Copy link
Contributor

@shotarok shotarok commented Sep 2, 2023

part of hashicorp/terraform-provider-google#12818

Release Note Template for Downstream PRs (will be copied)

vertexai: added `public_endpoint_enabled` to `google_vertex_ai_index_endpoint`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 2, 2023
Comment on lines +107 to +108
immutable: true
ignore_read: true
Copy link
Contributor Author

@shotarok shotarok Sep 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEMO]

I confirmed a response of projects.locations.indexEndpoints.get didn't include the publicEndpointEnabled like below.

Details
$ curl -X GET -H "Authorization: Bearer $(gcloud auth print-access-token)" https://us-central1-aiplatform.googleapis.com/v1/projects/xxx/locations/us-central1/indexEndpoints/5155064664874287104
{
  "name": "projects/xxxxx/locations/us-central1/indexEndpoints/5155064664874287104",
  "displayName": "sample-endpoint",
  "description": "A sample vertex endpoint with an public endpoint",
  "etag": "AMEw9yPkWvTjGqy1FSFN3Dc9NTn8J7Qaf09YteDcAF8JL6QaABLNasuBBOT1Cd9vTH4O",
  "labels": {
    "label-one": "value-one"
  },
  "createTime": "2023-09-02T19:29:32.917516Z",
  "updateTime": "2023-09-02T19:29:33.681500Z",
  "publicEndpointDomainName": "2086866499.us-central1-415528280434.vdb.vertexai.goog"
}

In addition, I confirmed projects.locations.indexEndpoints.patch couldn't update the field like below.

Details
$ curl -X PATCH -H "Authorization: Bearer $(gcloud auth print-access-token)" https://us-central1-aiplatform.googleapis.com/v1/projects/xxxx/locations/us-central1/indexEndpoints/5155064664874287104\?updateMask\=publicEndpointEnabled -H 'Content-Type: application/json' -d '{
 "description": "A sample vertex endpoint with an public endpoint",
 "displayName": "sample-endpoint",
 "labels": {
  "label-one": "value-one"
 },
 "publicEndpointEnabled": false
}'

{
  "name": "projects/xxxx/locations/us-central1/indexEndpoints/5155064664874287104",
  "displayName": "sample-endpoint",
  "description": "A sample vertex endpoint with an public endpoint",
  "labels": {
    "label-one": "value-one"
  },
  "createTime": "2023-09-02T19:29:32.917516Z",
  "updateTime": "2023-09-02T19:37:58.913067Z",
  "publicEndpointDomainName": "2086866499.us-central1-415528280434.vdb.vertexai.goog"
}

@shotarok
Copy link
Contributor Author

shotarok commented Sep 2, 2023

@ScottSuarez Hello 👋 When you have time, could you approve the cloud builder to run acceptance tests? Thanks

@ScottSuarez
Copy link
Contributor

ah thanks for the ping !

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 5, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 97 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 97 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3011
Passed tests 2713
Skipped tests: 296
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFolderIamPolicy_basic|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithPublicEndpointExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFolderIamPolicy_basic[Debug log]
TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithPublicEndpointExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@ScottSuarez ScottSuarez merged commit 90c2cc7 into GoogleCloudPlatform:main Sep 6, 2023
8 checks passed
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Sep 7, 2023
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Sep 7, 2023
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants