-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vertexai): Make it possible to create a public Vertex AI Index Endpoint #8852
feat(vertexai): Make it possible to create a public Vertex AI Index Endpoint #8852
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
immutable: true | ||
ignore_read: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[MEMO]
I confirmed a response of projects.locations.indexEndpoints.get didn't include the publicEndpointEnabled like below.
Details
$ curl -X GET -H "Authorization: Bearer $(gcloud auth print-access-token)" https://us-central1-aiplatform.googleapis.com/v1/projects/xxx/locations/us-central1/indexEndpoints/5155064664874287104
{
"name": "projects/xxxxx/locations/us-central1/indexEndpoints/5155064664874287104",
"displayName": "sample-endpoint",
"description": "A sample vertex endpoint with an public endpoint",
"etag": "AMEw9yPkWvTjGqy1FSFN3Dc9NTn8J7Qaf09YteDcAF8JL6QaABLNasuBBOT1Cd9vTH4O",
"labels": {
"label-one": "value-one"
},
"createTime": "2023-09-02T19:29:32.917516Z",
"updateTime": "2023-09-02T19:29:33.681500Z",
"publicEndpointDomainName": "2086866499.us-central1-415528280434.vdb.vertexai.goog"
}
In addition, I confirmed projects.locations.indexEndpoints.patch couldn't update the field like below.
Details
$ curl -X PATCH -H "Authorization: Bearer $(gcloud auth print-access-token)" https://us-central1-aiplatform.googleapis.com/v1/projects/xxxx/locations/us-central1/indexEndpoints/5155064664874287104\?updateMask\=publicEndpointEnabled -H 'Content-Type: application/json' -d '{
"description": "A sample vertex endpoint with an public endpoint",
"displayName": "sample-endpoint",
"labels": {
"label-one": "value-one"
},
"publicEndpointEnabled": false
}'
{
"name": "projects/xxxx/locations/us-central1/indexEndpoints/5155064664874287104",
"displayName": "sample-endpoint",
"description": "A sample vertex endpoint with an public endpoint",
"labels": {
"label-one": "value-one"
},
"createTime": "2023-09-02T19:29:32.917516Z",
"updateTime": "2023-09-02T19:37:58.913067Z",
"publicEndpointDomainName": "2086866499.us-central1-415528280434.vdb.vertexai.goog"
}
@ScottSuarez Hello 👋 When you have time, could you approve the cloud builder to run acceptance tests? Thanks |
ah thanks for the ping ! |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 97 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFolderIamPolicy_basic|TestAccVertexAIIndexEndpoint_vertexAiIndexEndpointWithPublicEndpointExample |
Rerun these tests in REPLAYING mode to catch issues
|
part of hashicorp/terraform-provider-google#12818
Release Note Template for Downstream PRs (will be copied)