Use Create instead of Patch to create google_service_networking_connection

mmv1/products/alloydb/Backup.yaml

@@ -42,8 +42,6 @@ examples:
       alloydb_cluster_name: 'alloydb-cluster'
       alloydb_instance_name: 'alloydb-instance'
       network_name: 'alloydb-network'
-    test_vars_overrides:
-      network_name: 'acctest.BootstrapSharedTestNetwork(t, "alloydb-backup-basic")'
     ignore_read_extra:
       - 'reconciling'
       - 'update_time'
@@ -55,8 +53,6 @@ examples:
       alloydb_cluster_name: 'alloydb-cluster'
       alloydb_instance_name: 'alloydb-instance'
       network_name: 'alloydb-network'
-    test_vars_overrides:
-      network_name: 'acctest.BootstrapSharedTestNetwork(t, "alloydb-backup-full")'
     ignore_read_extra:
       - 'reconciling'
       - 'update_time'

mmv1/products/alloydb/Instance.yaml

@@ -57,8 +57,6 @@ examples:
       alloydb_cluster_name: 'alloydb-cluster'
       alloydb_instance_name: 'alloydb-instance'
       network_name: 'alloydb-network'
-    test_vars_overrides:
-      network_name: 'acctest.BootstrapSharedTestNetwork(t, "alloydb-instance-basic")'
     ignore_read_extra:
       - 'reconciling'
       - 'update_time'

mmv1/products/databasemigrationservice/connectionprofile.yaml

@@ -87,8 +87,6 @@ examples:
       profile: 'my-profileid'
       global_address_name: 'private-ip-alloc'
       network_name: 'vpc-network'
-    test_vars_overrides:
-      network_name: 'acctest.BootstrapSharedTestNetwork(t, "profile-alloydb")'
 parameters:
   - !ruby/object:Api::Type::String
     name: 'connectionProfileId'

mmv1/products/looker/Instance.yaml

@@ -57,7 +57,6 @@ examples:
       client_id: 'my-client-id'
       client_secret: 'my-client-secret'
     test_vars_overrides:
-      network_name: 'acctest.BootstrapSharedTestNetwork(t, "looker-instance-enterprise")'
       kms_key_name: 'acctest.BootstrapKMSKeyInLocation(t, "us-central1").CryptoKey.Name'
 parameters:
   - !ruby/object:Api::Type::String

mmv1/products/memcache/Instance.yaml

@@ -37,8 +37,6 @@ examples:
       instance_name: 'test-instance'
       network_name: 'test-network'
       address_name: 'address'
-    test_vars_overrides:
-      network_name: 'acctest.BootstrapSharedTestNetwork(t, "memcache-instance-basic")'
 parameters:
   - !ruby/object:Api::Type::String
     name: 'region'

mmv1/products/redis/Instance.yaml

@@ -67,8 +67,6 @@ examples:
       instance_name: 'private-cache'
       address_name: 'address'
       network_name: 'redis-test-network'
-    test_vars_overrides:
-      network_name: 'acctest.BootstrapSharedTestNetwork(t, "redis-private-service")'
   - !ruby/object:Provider::Terraform::Examples
     name: 'redis_instance_mrr'
     primary_resource_id: 'cache'

mmv1/templates/terraform/examples/alloydb_backup_basic.tf.erb

@@ -9,7 +9,7 @@ resource "google_alloydb_backup" "<%= ctx[:primary_resource_id] %>" {
 resource "google_alloydb_cluster" "<%= ctx[:primary_resource_id] %>" {
   cluster_id = "<%= ctx[:vars]['alloydb_cluster_name'] %>"
   location   = "us-central1"
-  network    = data.google_compute_network.default.id
+  network    = google_compute_network.default.id
 }
 
 resource "google_alloydb_instance" "<%= ctx[:primary_resource_id] %>" {
@@ -25,15 +25,15 @@ resource "google_compute_global_address" "private_ip_alloc" {
   address_type  = "INTERNAL"
   purpose       = "VPC_PEERING"
   prefix_length = 16
-  network       = data.google_compute_network.default.id
+  network       = google_compute_network.default.id
 }
 
 resource "google_service_networking_connection" "vpc_connection" {
-  network                 = data.google_compute_network.default.id
+  network                 = google_compute_network.default.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
 }
 
-data "google_compute_network" "default" {
+resource "google_compute_network" "default" {
   name = "<%= ctx[:vars]['network_name'] %>"
 }

mmv1/templates/terraform/examples/alloydb_backup_full.tf.erb

@@ -13,7 +13,7 @@ resource "google_alloydb_backup" "<%= ctx[:primary_resource_id] %>" {
 resource "google_alloydb_cluster" "<%= ctx[:primary_resource_id] %>" {
   cluster_id = "<%= ctx[:vars]['alloydb_cluster_name'] %>"
   location   = "us-central1"
-  network    = data.google_compute_network.default.id
+  network    = google_compute_network.default.id
 }
 
 resource "google_alloydb_instance" "<%= ctx[:primary_resource_id] %>" {
@@ -29,15 +29,15 @@ resource "google_compute_global_address" "private_ip_alloc" {
   address_type  = "INTERNAL"
   purpose       = "VPC_PEERING"
   prefix_length = 16
-  network       = data.google_compute_network.default.id
+  network       = google_compute_network.default.id
 }
 
 resource "google_service_networking_connection" "vpc_connection" {
-  network                 = data.google_compute_network.default.id
+  network                 = google_compute_network.default.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
 }
 
-data "google_compute_network" "default" {
+resource "google_compute_network" "default" {
   name = "<%= ctx[:vars]['network_name'] %>"
 }

mmv1/templates/terraform/examples/alloydb_instance_basic.tf.erb

@@ -13,7 +13,7 @@ resource "google_alloydb_instance" "<%= ctx[:primary_resource_id] %>" {
 resource "google_alloydb_cluster" "<%= ctx[:primary_resource_id] %>" {
   cluster_id = "<%= ctx[:vars]['alloydb_cluster_name'] %>"
   location   = "us-central1"
-  network    = data.google_compute_network.default.id
+  network    = google_compute_network.default.id
 
   initial_user {
     password = "<%= ctx[:vars]['alloydb_cluster_name'] %>"
@@ -22,7 +22,7 @@ resource "google_alloydb_cluster" "<%= ctx[:primary_resource_id] %>" {
 
 data "google_project" "project" {}
 
-data "google_compute_network" "default" {
+resource "google_compute_network" "default" {
   name = "<%= ctx[:vars]['network_name'] %>"
 }
 
@@ -31,11 +31,11 @@ resource "google_compute_global_address" "private_ip_alloc" {
   address_type  = "INTERNAL"
   purpose       = "VPC_PEERING"
   prefix_length = 16
-  network       = data.google_compute_network.default.id
+  network       = google_compute_network.default.id
 }
 
 resource "google_service_networking_connection" "vpc_connection" {
-  network                 = data.google_compute_network.default.id
+  network                 = google_compute_network.default.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
 }

mmv1/templates/terraform/examples/database_migration_service_connection_profile_alloydb.tf.erb

@@ -1,7 +1,7 @@
 data "google_project" "project" {
 }
 
-data "google_compute_network" "default" {
+resource "google_compute_network" "default" {
   name = "<%= ctx[:vars]['network_name'] %>"
 }
 
@@ -10,11 +10,11 @@ resource "google_compute_global_address" "private_ip_alloc" {
   address_type  = "INTERNAL"
   purpose       = "VPC_PEERING"
   prefix_length = 16
-  network       = data.google_compute_network.default.id
+  network       = google_compute_network.default.id
 }
 
 resource "google_service_networking_connection" "vpc_connection" {
-  network                 = data.google_compute_network.default.id
+  network                 = google_compute_network.default.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
 }
@@ -34,7 +34,7 @@ resource "google_database_migration_service_connection_profile" "<%= ctx[:primar
         user = "alloyuser%{random_suffix}"
         password = "alloypass%{random_suffix}"
       }
-      vpc_network = data.google_compute_network.default.id
+      vpc_network = google_compute_network.default.id
       labels  = { 
         alloyfoo = "alloybar" 
       }

mmv1/templates/terraform/examples/looker_instance_enterprise_full.tf.erb

@@ -5,7 +5,7 @@ resource "google_looker_instance" "<%= ctx[:primary_resource_id] %>" {
   private_ip_enabled = true
   public_ip_enabled  = false
   reserved_range     = "${google_compute_global_address.looker_range.name}"
-  consumer_network   = data.google_compute_network.looker_network.id
+  consumer_network   = google_compute_network.looker_network.id
   admin_settings {
     allowed_email_domains = ["google.com"]
   }
@@ -49,7 +49,7 @@ resource "google_looker_instance" "<%= ctx[:primary_resource_id] %>" {
 }
 
 resource "google_service_networking_connection" "looker_vpc_connection" {
-  network                 = data.google_compute_network.looker_network.id
+  network                 = google_compute_network.looker_network.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.looker_range.name]
 }
@@ -59,12 +59,12 @@ resource "google_compute_global_address" "looker_range" {
   purpose       = "VPC_PEERING"
   address_type  = "INTERNAL"
   prefix_length = 20
-  network       = data.google_compute_network.looker_network.id
+  network       = google_compute_network.looker_network.id
 }
 
 data "google_project" "project" {}
 
-data "google_compute_network" "looker_network" {
+resource "google_compute_network" "looker_network" {
   name = "<%= ctx[:vars]["network_name"] %>"
 }
 

mmv1/templates/terraform/examples/memcache_instance_basic.tf.erb

@@ -6,7 +6,7 @@
 // If this network hasn't been created and you are using this example in your
 // config, add an additional network resource or change
 // this from "data"to "resource"
-data "google_compute_network" "memcache_network" {
+resource "google_compute_network" "memcache_network" {
   name = "<%= ctx[:vars]['network_name'] %>"
 }
 
@@ -15,11 +15,11 @@ resource "google_compute_global_address" "service_range" {
   purpose       = "VPC_PEERING"
   address_type  = "INTERNAL"
   prefix_length = 16
-  network       = data.google_compute_network.memcache_network.id
+  network       = google_compute_network.memcache_network.id
 }
 
 resource "google_service_networking_connection" "private_service_connection" {
-  network                 = data.google_compute_network.memcache_network.id
+  network                 = google_compute_network.memcache_network.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.service_range.name]
 }

mmv1/templates/terraform/examples/redis_instance_private_service.tf.erb

@@ -6,7 +6,7 @@
 // If this network hasn't been created and you are using this example in your
 // config, add an additional network resource or change
 // this from "data"to "resource"
-data "google_compute_network" "redis-network" {
+resource "google_compute_network" "redis-network" {
   name = "<%= ctx[:vars]['network_name'] %>"
 }
 
@@ -15,11 +15,11 @@ resource "google_compute_global_address" "service_range" {
   purpose       = "VPC_PEERING"
   address_type  = "INTERNAL"
   prefix_length = 16
-  network       = data.google_compute_network.redis-network.id
+  network       = google_compute_network.redis-network.id
 }
 
 resource "google_service_networking_connection" "private_service_connection" {
-  network                 = data.google_compute_network.redis-network.id
+  network                 = google_compute_network.redis-network.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.service_range.name]
 }
@@ -32,7 +32,7 @@ resource "google_redis_instance" "<%= ctx[:primary_resource_id] %>" {
   location_id             = "us-central1-a"
   alternative_location_id = "us-central1-f"
 
-  authorized_network = data.google_compute_network.redis-network.id
+  authorized_network = google_compute_network.redis-network.id
   connect_mode       = "PRIVATE_SERVICE_ACCESS"
 
   redis_version     = "REDIS_4_0"

mmv1/third_party/terraform/services/alloydb/resource_alloydb_backup_test.go

@@ -10,9 +10,10 @@ import (
 func TestAccAlloydbBackup_update(t *testing.T) {
 	t.Parallel()
 
+	random_suffix := acctest.RandString(t, 10)
 	context := map[string]interface{}{
-		"network_name":  acctest.BootstrapSharedTestNetwork(t, "alloydb-backup-update"),
-		"random_suffix": acctest.RandString(t, 10),
+		"network_name":  "tf-test-alloydb-network" + random_suffix,
+		"random_suffix": random_suffix,
 	}
 
 	acctest.VcrTest(t, resource.TestCase{
@@ -61,7 +62,7 @@ resource "google_alloydb_backup" "default" {
 resource "google_alloydb_cluster" "default" {
   cluster_id = "tf-test-alloydb-cluster%{random_suffix}"
   location   = "us-central1"
-  network    = data.google_compute_network.default.id
+  network    = google_compute_network.default.id
 }
 
 resource "google_alloydb_instance" "default" {
@@ -77,16 +78,16 @@ resource "google_compute_global_address" "private_ip_alloc" {
   address_type  = "INTERNAL"
   purpose       = "VPC_PEERING"
   prefix_length = 16
-  network       = data.google_compute_network.default.id
+  network       = google_compute_network.default.id
 }
 
 resource "google_service_networking_connection" "vpc_connection" {
-  network                 = data.google_compute_network.default.id
+  network                 = google_compute_network.default.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
 }
 
-data "google_compute_network" "default" {
+resource "google_compute_network" "default" {
   name = "%{network_name}"
 }
 `, context)
@@ -98,7 +99,7 @@ func TestAccAlloydbBackup_createBackupWithMandatoryFields(t *testing.T) {
 
 	context := map[string]interface{}{
 		"random_suffix": acctest.RandString(t, 10),
-		"network_name":  acctest.BootstrapSharedTestNetwork(t, "alloydbbackup-mandatory"),
+		"network_name":  "tf-test-" + acctest.RandString(t, 10),
 	}
 
 	acctest.VcrTest(t, resource.TestCase{
@@ -125,12 +126,12 @@ resource "google_alloydb_backup" "default" {
 resource "google_alloydb_cluster" "default" {
   location = "us-central1"
   cluster_id = "tf-test-alloydb-cluster%{random_suffix}"
-  network    = data.google_compute_network.default.id
+  network    = google_compute_network.default.id
 }
 
 data "google_project" "project" { }
 
-data "google_compute_network" "default" {
+resource "google_compute_network" "default" {
   name = "%{network_name}"
 }
 
@@ -147,7 +148,7 @@ resource "google_compute_global_address" "private_ip_alloc" {
   address_type  = "INTERNAL"
   purpose       = "VPC_PEERING"
   prefix_length = 16
-  network       = data.google_compute_network.default.id
+  network       = google_compute_network.default.id
   lifecycle {
 	ignore_changes = [
 		address,
@@ -161,7 +162,7 @@ resource "google_compute_global_address" "private_ip_alloc" {
 }
 
 resource "google_service_networking_connection" "vpc_connection" {
-  network                 = data.google_compute_network.default.id
+  network                 = google_compute_network.default.id
   service                 = "servicenetworking.googleapis.com"
   reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
 }
@@ -172,7 +173,7 @@ func TestAccAlloydbBackup_usingCMEK(t *testing.T) {
 	t.Parallel()
 
 	context := map[string]interface{}{
-		"network_name":  acctest.BootstrapSharedTestNetwork(t, "alloydb-backup-cmek"),
+		"network_name":  "tf-test-" + acctest.RandString(t, 10),
 		"random_suffix": acctest.RandString(t, 10),
 		"key_name":      "tf-test-key-" + acctest.RandString(t, 10),
 	}
@@ -215,7 +216,7 @@ resource "google_alloydb_backup" "default" {
 resource "google_alloydb_cluster" "default" {
 	cluster_id = "tf-test-alloydb-cluster%{random_suffix}"
 	location   = "us-central1"
-	network    = data.google_compute_network.default.id
+	network    = google_compute_network.default.id
 }
 
 resource "google_alloydb_instance" "default" {
@@ -231,16 +232,16 @@ resource "google_compute_global_address" "private_ip_alloc" {
 	address_type  = "INTERNAL"
 	purpose       = "VPC_PEERING"
 	prefix_length = 16
-	network       = data.google_compute_network.default.id
+	network       = google_compute_network.default.id
 }
 
 resource "google_service_networking_connection" "vpc_connection" {
-	network                 = data.google_compute_network.default.id
+	network                 = google_compute_network.default.id
 	service                 = "servicenetworking.googleapis.com"
 	reserved_peering_ranges = [google_compute_global_address.private_ip_alloc.name]
 }
 
-data "google_compute_network" "default" {
+resource "google_compute_network" "default" {
 	name = "%{network_name}"
 }
 data "google_project" "project" {}