Added is_secret_data_base64 field to google_secret_manager_secret_version

[abheda-crest]

Added the is_secret_data_base64 field to the google_secret_manager_secret_version resource
fixes hashicorp/terraform-provider-google#10129

Release Note Template for Downstream PRs (will be copied)

secretmanager: added `is_secret_data_base64` field to `google_secret_manager_secret_version` resource

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[abheda-crest]

Just to clarify, while importing the secret_version resources having the is_secret_data_base64 field set to true, the secret_data is decoded from the base64-encoded string received from API. It is potentially due to the condition of the flattener. It seems the import is working fine when the is_secret_data_base64 is not provided or set to false(again due to the same condition).

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 102 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 102 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+))
TF OiCS: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3028
Passed tests 2729
Skipped tests: 297
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocClusterIamPolicy|TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataprocClusterIamPolicy[Debug log]
TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[abheda-crest]

@trodge This PR is now ready for review

[trodge]

Why does this field need to be added this way as opposed to being in the yaml properties?

[abheda-crest]

This field is a terraform-only field that decides whether the secret_data is to be sent as is or after base64-encoding and whether to decode it while flattening. As this field affects the state value of secret_data, we need to keep it ForceNew. The virtual_field property doesn't provide a way to mark the fields immutable. Hence, I've used extra_schema_entry for this purpose.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 102 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 102 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 3 insertions(+))
TF OiCS: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3043
Passed tests 2745
Skipped tests: 297
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountIdToken_impersonation

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test