Update to wrap generated import format regex in ^ and $ #8913

NickElliot · 2023-09-11T17:12:01Z

Part of hashicorp/terraform-provider-google#14731

Currently generated import_format regex in TPG is not wrapped in start of line and end of line tokens, which allows for certain edge case false positives in non-standard import formats supplied via override.

Release Note Template for Downstream PRs (will be copied)

provider: fixed many import functions throughout the provider that matched a subset of the provided input when possible. Now, the GCP resource id supplied to "terraform import" must match exactly.

modular-magician · 2023-09-11T17:20:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 220 files changed, 680 insertions(+), 680 deletions(-))
Terraform Beta: Diff ( 275 files changed, 852 insertions(+), 852 deletions(-))

modular-magician · 2023-09-11T18:31:33Z

Tests analytics

Total tests: 3008
Passed tests 2703
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeVpnTunnel_regionFromGateway|TestAccCoreBillingProjectInfo_billingProjectInfoBasicExample|TestAccBillingProjectInfo_update

Get to know how VCR tests work

modular-magician · 2023-09-11T18:36:57Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeVpnTunnel_regionFromGateway[Error message] [Debug log]
TestAccCoreBillingProjectInfo_billingProjectInfoBasicExample[Error message] [Debug log]
TestAccBillingProjectInfo_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

…ng supplied uris wth a trailing

modular-magician · 2023-09-15T20:22:46Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 225 files changed, 689 insertions(+), 690 deletions(-))
Terraform Beta: Diff ( 280 files changed, 861 insertions(+), 862 deletions(-))

modular-magician · 2023-09-15T21:33:57Z

Tests analytics

Total tests: 3035
Passed tests 2728
Skipped tests: 304
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCoreBillingProjectInfo_billingProjectInfoBasicExample|TestAccBillingProjectInfo_update|TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBasic

Get to know how VCR tests work

modular-magician · 2023-09-15T21:38:29Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccGkeonpremBareMetalCluster_bareMetalClusterUpdateBasic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCoreBillingProjectInfo_billingProjectInfoBasicExample[Error message] [Debug log]
TestAccBillingProjectInfo_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-09-15T22:52:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 227 files changed, 692 insertions(+), 695 deletions(-))
Terraform Beta: Diff ( 282 files changed, 864 insertions(+), 867 deletions(-))

modular-magician · 2023-09-16T00:03:54Z

Tests analytics

Total tests: 3035
Passed tests 2729
Skipped tests: 304
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBillingProjectInfo_update|TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

modular-magician · 2023-09-16T00:07:36Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBillingProjectInfo_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-09-16T00:55:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 227 files changed, 692 insertions(+), 695 deletions(-))
Terraform Beta: Diff ( 282 files changed, 864 insertions(+), 867 deletions(-))

modular-magician · 2023-09-16T02:06:38Z

Tests analytics

Total tests: 3035
Passed tests 2730
Skipped tests: 304
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

modular-magician · 2023-09-16T02:09:16Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

rileykarson

LGTM- edited out "Fixes" In the parent since we'll need to add an upgrade guide as well, and proposed a changelog entry.

rileykarson · 2023-09-18T20:43:28Z

mmv1/third_party/terraform/services/compute/resource_compute_vpn_tunnel_test.go

@@ -31,7 +31,6 @@ func TestAccComputeVpnTunnel_regionFromGateway(t *testing.T) {
 				ResourceName:            "google_compute_vpn_tunnel.foobar",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateIdPrefix:     fmt.Sprintf("%s/%s/", envvar.GetTestProjectFromEnv(), region),


updated regex

aaf66e0

removing prefix fron vpntunnel text, updating billing info for allowi…

0e10aa1

…ng supplied uris wth a trailing

replacing importstateid, skipping import in generated sample

eb19800

NickElliot marked this pull request as ready for review September 16, 2023 00:39

incorrect var

eed6635

NickElliot requested a review from rileykarson September 18, 2023 00:15

rileykarson approved these changes Sep 18, 2023

View reviewed changes

NickElliot mentioned this pull request Sep 21, 2023

Version 5 Upgrade docs updated for flex_template_job, node_group, and import format regex #9045

Merged

NickElliot merged commit 6cdbf4d into GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0 Sep 25, 2023
9 checks passed

This was referenced Sep 26, 2023

Update import_format regex to include ^ and $ tokens hashicorp/terraform-provider-google#14731

Closed

Sync Feature branch major release 5.0.0 into main #9110

Merged

This was referenced Sep 28, 2023

Sync Feature branch major release 5.0.0 into main terraform-google-modules/docs-examples#553

Merged

Sync Feature branch major release 5.0.0 into main hashicorp/terraform-provider-google-beta#6395

Merged

This was referenced Sep 28, 2023

Sync Feature branch major release 5.0.0 into main hashicorp/terraform-provider-google#16034

Merged

Sync Feature branch major release 5.0.0 into main GoogleCloudPlatform/terraform-google-conversion#1518

Merged

zli82016 mentioned this pull request Sep 28, 2023

Failing test(s): TestAccComputeNetworkEndpoints_networkEndpointsBasic hashicorp/terraform-provider-google#16039

Closed

NickElliot mentioned this pull request Oct 6, 2023

Update resource Ids with extraneous prefixes or affixes to match eligible import formats hashicorp/terraform-provider-google#16160

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to wrap generated import format regex in ^ and $ #8913

Update to wrap generated import format regex in ^ and $ #8913

NickElliot commented Sep 11, 2023 •

edited by rileykarson

Loading

modular-magician commented Sep 11, 2023

modular-magician commented Sep 11, 2023

modular-magician commented Sep 11, 2023

modular-magician commented Sep 15, 2023

modular-magician commented Sep 15, 2023

modular-magician commented Sep 15, 2023

modular-magician commented Sep 15, 2023

modular-magician commented Sep 16, 2023

modular-magician commented Sep 16, 2023

modular-magician commented Sep 16, 2023

modular-magician commented Sep 16, 2023

modular-magician commented Sep 16, 2023

rileykarson left a comment

rileykarson Sep 18, 2023

Update to wrap generated import format regex in ^ and $ #8913

Update to wrap generated import format regex in ^ and $ #8913

Conversation

NickElliot commented Sep 11, 2023 • edited by rileykarson Loading

modular-magician commented Sep 11, 2023

Diff report

modular-magician commented Sep 11, 2023

Tests analytics

Action taken

modular-magician commented Sep 11, 2023

modular-magician commented Sep 15, 2023

Diff report

modular-magician commented Sep 15, 2023

Tests analytics

Action taken

modular-magician commented Sep 15, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Sep 15, 2023

Diff report

modular-magician commented Sep 16, 2023

Tests analytics

Action taken

modular-magician commented Sep 16, 2023

Rerun these tests in REPLAYING mode to catch issues

modular-magician commented Sep 16, 2023

Diff report

modular-magician commented Sep 16, 2023

Tests analytics

Action taken

modular-magician commented Sep 16, 2023

Rerun these tests in REPLAYING mode to catch issues

rileykarson left a comment

Choose a reason for hiding this comment

rileykarson Sep 18, 2023

Choose a reason for hiding this comment

NickElliot commented Sep 11, 2023 •

edited by rileykarson

Loading