-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Direct VPC egress support for Cloud Run V2 resources #8932
Conversation
Hello! I am a robot. It looks like you are a: @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 456 insertions(+)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloud_run_v2_service" "primary" {
template {
vpc_access {
network_interfaces {
subnetwork = # value needed
tags = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudRunV2Job_cloudrunv2JobDirectvpcExample|TestAccCloudRunV2Service_cloudrunv2ServiceDirectvpcExample|TestAccGKEHub2Scope_gkehubScopeBasicExample|TestAccGKEHub2ScopeIamMemberGenerated|TestAccGKEHub2ScopeIamBindingGenerated|TestAccGKEHub2ScopeIamPolicyGenerated |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 6 files changed, 460 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccCloudRunV2Service_cloudrunv2ServiceDirectvpcExample|TestAccCloudRunV2Job_cloudrunv2JobDirectvpcExample|TestAccGKEHub2Scope_gkehubScopeBasicExample|TestAccGKEHub2ScopeIamBindingGenerated|TestAccGKEHub2ScopeIamMemberGenerated|TestAccGKEHub2ScopeIamPolicyGenerated |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are any of these fields support in-place update? If so, would you mind adding/ modifying an update test to the update functionality of it?
mmv1/templates/terraform/examples/cloudrunv2_job_directvpc.tf.erb
Outdated
Show resolved
Hide resolved
Added tests. For Service, I can only use existing "default" network. For Job, non-existing networks are fine. While adding the tests, found that existing |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 8 files changed, 632 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudRunV2Job_cloudrunv2JobWithDirectVPCUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceWithDirectVPCUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceDirectvpcExample|TestAccCloudRunV2Job_cloudrunv2JobDirectvpcExample |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes hashicorp/terraform-provider-google#15568
Release Note Template for Downstream PRs (will be copied)