-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Instance.yaml to remove LOOKER_MODELER edition #9033
Update Instance.yaml to remove LOOKER_MODELER edition #9033
Conversation
Hello! I am a robot. It looks like you are a: @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 3 insertions(+), 5 deletions(-)) |
Is there a GH issue and upgrade guide associated with this PR? |
@c2thorn No, this is an internal issue to remove LOOKER_MODELER edition as we will not be GA'ing that offering. b/301270835 |
created hashicorp/terraform-provider-google#15923 to track and updated the changelog. We require an upgrade guide entry for breaking changes to explain what users should use instead. This will need to be in a separate pull request to the |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbInstance_createInstanceWithNetworkConfigAndAllocatedIPRange|TestAccVertexAIIndexEndpoint_updated |
|
@efeelaiho have you seen this? |
756e2d9
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
fixes hashicorp/terraform-provider-google#15923
Release Note Template for Downstream PRs (will be copied)