fix(vertexai): make contents_delta_uri a required field in google_vertex_ai_index

[shotarok]

Fixes hashicorp/terraform-provider-google#15962
Part of hashicorp/terraform-provider-google#12818

Add required: true to contens_delta_url to be able to avoid the following error at terraform apply:

Error: Error creating Index: googleapi: Error 400: contentsDeltaUri is required but missing from Index metadata.

Release Note Template for Downstream PRs (will be copied)

vertexai: made `contents_delta_uri` a required field in `google_vertex_ai_index` as omitting it would result in an error

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[c2thorn]

This is a breaking change and can usually only be added within a major release (of which we have a very short window for this to get into)

Additionally, I cannot find it written that this field is required in all scenarios. The wording in https://cloud.google.com/vertex-ai/docs/vector-search/configuring-indexes makes it seem like it is not strictly required, where other required fields are explicitly labeled so. What do you think?

[shotarok]

This is a breaking change and can usually only be added within a major release

Hello @c2thorn, this change looks to correspond to the second example. So I believed we can release this in a minor release.

magic-modules/docs/content/develop/make-a-breaking-change.md

Lines 41 to 54 in aef0da0

	## In minor releases
	If a breaking change fixes a bug that impacts **all configurations** that
	include a field or resource, it is generally allowed in a minor release. For
	example:
	* Removing update support from a field if that field is not actually updatable
	in the API.
	* Marking a field required if omitting the field always causes an API error.
	The following types of changes can be made if the default behavior stays the
	same and new behavior can be enabled with a flag:
	* Major resource-level or field-level behavioural changes

Additionally, I cannot find it written that this field is required in all scenarios.

That's true. I couldn't find any description either. I also want to know if it's optional or required. Can you reach out to the product team? Or should I reach out to the team by creating a support ticket or asking a technical account manager?

[c2thorn]

I'll reach out to the product team

[c2thorn]

It's required on Create but not Update, which is maybe why the wording is not concrete. I think moving forward with marking it as required overall is the best choice.

Hello @c2thorn, this change looks to correspond to the second example. So I believed we can release this in a minor release.

Thanks for pointing this out, that looks to be correct. Let's move forward with it.

[shotarok]

It's required on Create but not Update

I see. Thank you for letting me know!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field metadata.contents_delta_uri changed from optional to required on google_vertex_ai_index - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 11 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 2 files changed, 11 insertions(+), 11 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3084
Passed tests 2780
Skipped tests: 299
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccFolderIamPolicy_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccFolderIamPolicy_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[c2thorn]

Overriding breaking change lock due to this field causing an error if omitted.