-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary fix for TGC tests #9116
Temporary fix for TGC tests #9116
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. TF Conversion: Diff ( 25 files changed, 28 insertions(+), 1675 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccContainerCluster_withAddons|TestAccDataSourceGoogleServiceAccountJwt|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccSecurityCenterFolderCustomModule |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. TF Conversion: Diff ( 57 files changed, 5973 deletions(-)) |
d7c4745
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccContainerCluster_withAddons|TestAccSecurityCenterFolderCustomModule |
|
This reverts commit d7c4745.
labels - don't know if this is a proper fix, but it stops the error for now.other tests - these fail due to the schema change from list to Set, I've just moved these to the "ignore" folder.I've just moved all failing to the "ignore" folder.
Release Note Template for Downstream PRs (will be copied)