Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for TGC tests #9116

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Sep 28, 2023

labels - don't know if this is a proper fix, but it stops the error for now.
other tests - these fail due to the schema change from list to Set, I've just moved these to the "ignore" folder.

I've just moved all failing to the "ignore" folder.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 25 files changed, 28 insertions(+), 1675 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3099
Passed tests 2781
Skipped tests: 313
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccContainerCluster_withAddons|TestAccDataSourceGoogleServiceAccountJwt|TestAccDataSourceGoogleServiceAccountAccessToken_basic|TestAccSecurityCenterFolderCustomModule

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Conversion: Diff ( 57 files changed, 5973 deletions(-))

@c2thorn c2thorn merged commit d7c4745 into GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0 Sep 28, 2023
11 of 14 checks passed
@c2thorn c2thorn deleted the 5.0.0-tgc-fix branch September 28, 2023 16:34
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3099
Passed tests 2783
Skipped tests: 313
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample|TestAccContainerCluster_withAddons|TestAccSecurityCenterFolderCustomModule

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccArtifactRegistryRepository_artifactRegistryRepositoryRemoteYumExample[Error message] [Debug log]
TestAccContainerCluster_withAddons[Error message] [Debug log]
TestAccSecurityCenterFolderCustomModule[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

c2thorn added a commit to c2thorn/magic-modules that referenced this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants