Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TestAccFirebaseWebApp_firebaseWebAppFull #9251

Merged
merged 3 commits into from
Nov 14, 2023
Merged

fix TestAccFirebaseWebApp_firebaseWebAppFull #9251

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe1566b
fix test
shuyama1 Oct 12, 2023
09cd488
fix
shuyama1 Nov 9, 2023
6ff2313
remove restrictions block
shuyama1 Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions mmv1/third_party/terraform/services/firebase/resource_firebase_web_app_test.go.erb
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug in the API. Just to unblock this test, could you change the two instances ofbrowser_key_restrictions to allowed_referrers = []?

Original file line number Diff line number Diff line change
Expand Up @@ -66,25 +66,13 @@ resource "google_apikeys_key" "key1" {
name = "tf-test-api-key1%{random_suffix}"
display_name = "Test api key 1"
project = "%{project_id}"

restrictions {
browser_key_restrictions {
allowed_referrers = ["*"]
}
}
}

resource "google_apikeys_key" "key2" {
provider = google-beta
name = "tf-test-api-key2%{random_suffix}"
display_name = "Test api key 2"
project = google_project.default.project_id

restrictions {
browser_key_restrictions {
allowed_referrers = ["*"]
}
}
project = "%{project_id}"
}

resource "google_firebase_web_app" "default" {
Expand Down